From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master a6b5985: Avoid duplicated character classes in rx Date: Wed, 4 Dec 2019 12:22:31 +0100 Message-ID: References: <20191203142243.9552.27513@vcs0.savannah.gnu.org> <20191203142246.0615C20A2B@vcs0.savannah.gnu.org> <79A83C7D-610F-4CA4-B5E9-7F11FD8A9365@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="81436"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Juanma Barranquero , Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 04 13:26:42 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1icTjs-000L3Z-QA for ged-emacs-devel@m.gmane.org; Wed, 04 Dec 2019 13:26:41 +0100 Original-Received: from localhost ([::1]:37768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icTjq-0005Gi-KT for ged-emacs-devel@m.gmane.org; Wed, 04 Dec 2019 07:26:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58717) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icSk9-00008c-9j for emacs-devel@gnu.org; Wed, 04 Dec 2019 06:22:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icSjz-0005qK-1C for emacs-devel@gnu.org; Wed, 04 Dec 2019 06:22:45 -0500 Original-Received: from mail209c50.megamailservers.eu ([91.136.10.219]:55456 helo=mail194c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1icSjy-0005Lx-BT for emacs-devel@gnu.org; Wed, 04 Dec 2019 06:22:42 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1575458555; bh=01m/6gVbhUW+F5eJkQitVUOqfpQ9WUhBacuPU0+1WSQ=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=GCIWquEO7uEJue1S7zGt/Fbl/KG3bKXA+aZI73tc3vc1A1saC5h2RtsCkfEn5k3ke RnybA1zui17iywf0EospyZnXRMTM4TqxsYmR+X9dbRGFsg7K9GyblqT/F5N2ikdhnA gCQFAGkixabfCvSsrp9ZAD8v8ZXJCDiaCK1vnan8= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-6f4fe655.032-75-73746f71.bbcust.telenor.se [85.230.79.111]) (authenticated bits=0) by mail194c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id xB4BMWxP009775; Wed, 4 Dec 2019 11:22:34 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0202.5DE796FB.0037, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=A9kSwJeG c=1 sm=1 tr=0 a=fHaj9vQUQVKQ4sUldAaXuQ==:117 a=fHaj9vQUQVKQ4sUldAaXuQ==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=iRZporoAAAAA:8 a=pGLkceISAAAA:8 a=Cv0Dft6o2a7pwTnH5ZcA:9 a=CjuIK1q_8ugA:10 a=NOBgFS-JBQ2l-kSd6-zu:22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.136.10.219 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243117 Archived-At: Stefan Monnier : > Probably, but I still think it's bad practice to use the return value = of > an operation which is fundamentally a side-effect. Very well, it has now been wrapped in (progn ... t). Juanma Barranquero : > So you've never written >=20 > (if (setq var value) ...) Not so much, but I find it harder to avoid (while (setq v e) ...) lacking tail-recursive loops. > Thinking about converting it to cl-pushnew is what made me look closer = at this code in > the first place ;-) I prefer not using cl in rx.el at all for messy bootstrap reasons. = (cl-pushnew is a macro, but I'd rather not tempt fate.)