From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Welsh Duggan <mwd@cert.org>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: master a6b5985: Avoid duplicated character classes in rx
Date: Tue, 03 Dec 2019 15:21:02 -0500 [thread overview]
Message-ID: <jwvtv6h88q1.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <y2tdefmuc9usfn.fsf@lx-birch.ad.sei.cmu.edu> (Michael Welsh Duggan's message of "Tue, 03 Dec 2019 14:20:44 -0500")
>>>> I'd rather fix the code not to rely on the return value.
>>> I'm sure a lot more code relies on the return value of 'push'.
>> Probably, but I still think it's bad practice to use the return value of
>> an operation which is fundamentally a side-effect.
> But isn't that standard practice? From the elisp manual, for example:
> (setq x (nreverse x))
I don't think `nreverse` is "fundamentally a side-effect": its return
value is of critical importance.
Similarly return values which correspond to side-information about how
the side-effect was done (e.g. status or error codes) aren't subject to
the above "rule".
Stefan
next prev parent reply other threads:[~2019-12-03 20:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191203142243.9552.27513@vcs0.savannah.gnu.org>
[not found] ` <20191203142246.0615C20A2B@vcs0.savannah.gnu.org>
2019-12-03 15:08 ` master a6b5985: Avoid duplicated character classes in rx Juanma Barranquero
2019-12-03 15:26 ` Stefan Monnier
2019-12-03 15:33 ` Mattias Engdegård
2019-12-03 16:01 ` Stefan Monnier
2019-12-03 16:06 ` Juanma Barranquero
2019-12-03 17:37 ` Eli Zaretskii
2019-12-03 17:46 ` Juanma Barranquero
2019-12-03 18:34 ` Stefan Monnier
2019-12-03 18:12 ` Drew Adams
2019-12-03 17:39 ` Stefan Monnier
2019-12-03 17:51 ` Juanma Barranquero
2019-12-03 18:36 ` Stefan Monnier
2019-12-03 18:43 ` Juanma Barranquero
2019-12-04 4:36 ` Richard Stallman
2019-12-04 5:38 ` Juanma Barranquero
2019-12-03 19:20 ` Michael Welsh Duggan
2019-12-03 20:21 ` Stefan Monnier [this message]
2019-12-04 11:22 ` Mattias Engdegård
2019-12-06 18:49 ` Juanma Barranquero
2019-12-06 19:45 ` Drew Adams
2019-12-06 20:11 ` Juanma Barranquero
2019-12-10 3:27 ` Adam Porter
2019-12-10 4:13 ` Stefan Monnier
2019-12-10 4:20 ` Adam Porter
2019-12-10 6:09 ` Juanma Barranquero
2019-12-10 6:32 ` Juanma Barranquero
2019-12-06 19:46 ` Eli Zaretskii
2019-12-07 4:48 ` Richard Stallman
2019-12-07 5:45 ` Juanma Barranquero
2019-12-07 15:18 ` Drew Adams
2019-12-08 5:13 ` Richard Stallman
2019-12-03 17:39 ` Drew Adams
2019-12-03 15:36 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtv6h88q1.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=mwd@cert.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).