Re: [PATCH PING] Honor 'SOURCE_DATE_EPOCH' when generating autoloads.

[Philipp Stephani <p.stephani2@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1163 bytes --]

Philipp Stephani <p.stephani2@gmail.com> schrieb am Mi., 23. Dez. 2015 um
17:52 Uhr:

>
>> (If we do change the option, we should also change the name of the
>> variable and the cpp symbol.)
>>
>> > +(defconst emacs-build-system
>> > +  (if deterministic-dump "unknown" (system-name))
>> >    "Name of the system on which Emacs was built.")
>>
>> Can we find a better string, like "elided" or "undisclosed"?
>> "Unknown" sounds too self-derogatory.
>>
>
> Sure, 'elided' is fine.
>
>
>>
>> > +  DEFVAR_BOOL ("deterministic-dump", Vdeterministic_dump,
>> > +    doc: /* If t, attempt to make dumping deterministic by avoiding
>>
>> I think the usual style is "If non-nil".
>>
>
> ok
>
>
>>
>> > +sources of nondeterminism such as absolute paths, the hostname, or
>>
>> GNU coding standards frown on using "path" for anything that isn't
>> PATH-style list of directories.  Please use "file name" instead.
>>
>>
> ok
>

Attached a new patch with the requested changes. It would be great to defer
the discussion about naming, string vs. nil etc. until later so that this
project can make progress; there's still enough time to discuss until the
changes get releases.

[-- Attachment #1.2: Type: text/html, Size: 2350 bytes --]

[-- Attachment #2: 0001-Remove-build-system-name-from-deterministic-dumps.patch --]
[-- Type: application/octet-stream, Size: 4319 bytes --]

From 6ac74525e09456e0be32f8a25dcd313af0ac537d Mon Sep 17 00:00:00 2001
From: Philipp Stephani <phst@google.com>
Date: Sun, 20 Dec 2015 01:57:34 +0100
Subject: [PATCH] Remove build system name from deterministic dumps.

* configure.ac (DETERMINISTIC_DUMP): New configuration option.
* emacs.c (main): Initialize `deterministic-dump' from the
  configuration option.
  (syms_of_emacs): New constant `deterministic-dump'.
* sysdep.c (init_system_name): Use a constant if a deterministic dump is
  requested.
* version.el (emacs-build-time): Add a comment to make the build time
  deterministic if requested.
  (emacs-build-system): Make variable deterministic if requested.
---
 configure.ac    | 13 +++++++++++++
 lisp/version.el |  7 ++++---
 src/emacs.c     | 10 ++++++++++
 src/sysdep.c    |  7 +++++++
 4 files changed, 34 insertions(+), 3 deletions(-)

diff --git a/configure.ac b/configure.ac
index 0b7b403..abbe7f8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -542,6 +542,19 @@ AC_ARG_ENABLE(gtk-deprecation-warnings,
 		[Show Gtk+/Gdk deprecation warnings for Gtk+ >= 3.0])],
 [ac_enable_gtk_deprecation_warnings="${enableval}"],[])
 
+AC_ARG_ENABLE(deterministic-dump,
+[AS_HELP_STRING([--enable-deterministic-dump],
+                [Make dumping deterministic by removing system-specific
+                information from the dump, such as host names and
+                timestamps.])])
+if test "x${enableval}" = xno ; then
+   AC_DEFINE(DETERMINISTIC_DUMP, false,
+   [Set this to true to make dumping deterministic.])
+else
+   AC_DEFINE(DETERMINISTIC_DUMP, true,
+   [Set this to true to make dumping deterministic.])
+fi
+
 dnl This used to use changequote, but, apart from 'changequote is evil'
 dnl per the autoconf manual, we can speed up autoconf somewhat by quoting
 dnl the great gob of text.  Thus it's not processed for possible expansion.
diff --git a/lisp/version.el b/lisp/version.el
index 43103fd..a3f0ea0 100644
--- a/lisp/version.el
+++ b/lisp/version.el
@@ -38,12 +38,13 @@ emacs-minor-version
   "Minor version number of this version of Emacs.
 This variable first existed in version 19.23.")
 
+;; FIXME: The next variable should also be a constant if
+;; `deterministic-dump' is t.
 (defconst emacs-build-time (current-time)
   "Time at which Emacs was dumped out.")
 
-;; I think this should be obsoleted/removed.  It's just one more meaningless
-;; difference between different builds.  It's usually not even an fqdn.
-(defconst emacs-build-system (system-name)
+(defconst emacs-build-system
+  (if deterministic-dump "elided" (system-name))
   "Name of the system on which Emacs was built.")
 
 (defvar motif-version-string)
diff --git a/src/emacs.c b/src/emacs.c
index 2e9f950..863473a 100644
--- a/src/emacs.c
+++ b/src/emacs.c
@@ -925,6 +925,9 @@ main (int argc, char **argv)
   SET_BINARY (fileno (stdout));
 #endif /* MSDOS */
 
+  if (DETERMINISTIC_DUMP)
+    Vdeterministic_dump = Qt;
+
   /* Skip initial setlocale if LC_ALL is "C", as it's not needed in that case.
      The build procedure uses this while dumping, to ensure that the
      dumped Emacs does not have its system locale tables initialized,
@@ -2566,6 +2569,13 @@ libraries; only those already known by Emacs will be loaded.  */);
   Vdynamic_library_alist = Qnil;
   Fput (intern_c_string ("dynamic-library-alist"), Qrisky_local_variable, Qt);
 
+  DEFVAR_BOOL ("deterministic-dump", Vdeterministic_dump,
+    doc: /* If non-nil, attempt to make dumping deterministic by
+avoiding sources of nondeterminism such as absolute file names, the
+hostname, or timestamps.  */);
+  Vdeterministic_dump = DETERMINISTIC_DUMP ? Qt : Qnil;
+  XSYMBOL (intern_c_string ("deterministic-dump"))->constant = 1;
+
 #ifdef WINDOWSNT
   Vlibrary_cache = Qnil;
   staticpro (&Vlibrary_cache);
diff --git a/src/sysdep.c b/src/sysdep.c
index 1af323e..5bbf723 100644
--- a/src/sysdep.c
+++ b/src/sysdep.c
@@ -1399,6 +1399,13 @@ setup_pty (int fd)
 void
 init_system_name (void)
 {
+  if (DETERMINISTIC_DUMP && (might_dump || ! NILP (Vpurify_flag)))
+    {
+      /* If we're dumping, set the hostname to a literal so that the
+         dump is deterministic.  */
+      Vsystem_name = build_pure_c_string ("elided");
+      return;
+    }
   char *hostname_alloc = NULL;
   char *hostname;
 #ifndef HAVE_GETHOSTNAME
-- 
2.6.3