From: Paul Eggert <eggert@cs.ucla.edu>
To: Philipp Stephani <p.stephani2@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH PING] Honor 'SOURCE_DATE_EPOCH' when generating autoloads.
Date: Wed, 23 Dec 2015 13:09:21 -0800 [thread overview]
Message-ID: <567B0D81.2000106@cs.ucla.edu> (raw)
In-Reply-To: <CAArVCkQd_3UihF4urUO7qrYvSSHNL-DBBRXFX68ZJP1UpwKWnQ@mail.gmail.com>
Philipp Stephani wrote:
> I thought that too, but on second thought it seems rather difficult: the
> variable should be set to nil by default in an initialized Emacs (and
> probably also in temacs), yet we need a way to set it to t based on the
> configuration option.
Doesn't your proposed patch already set deterministic-dump to t based on the
configuration option? I don't see the difficulty.
> + (if deterministic-dump "unknown" (system-name))
How about changing this to:
(when (not deterministic-dump) (system-name))
and document that the value is nil when unavailable? That should be cleaner than
the confusion if a system name actually happens to be "unknown". Similarly,
init_system_name should leave Vsystem_name alone when DETERMINISTIC_DUMP.
> +#ifdef DETERMINISTIC_DUMP
Please change this to "if (DETERMINISTIC_DUMP)", and similarly for other uses,
and arrange for DETERMINISTIC_DUMP to be a constant false or true. Nowadays we
should prefer macros to constants only when they're really necessary, which
isn't the case here.
next prev parent reply other threads:[~2015-12-23 21:09 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 17:03 [PATCH] Honor 'SOURCE_DATE_EPOCH' when generating autoloads Ludovic Courtès
2015-11-29 10:44 ` [PATCH PING] " Ludovic Courtès
2015-11-29 16:02 ` Eli Zaretskii
2015-11-29 16:57 ` Ludovic Courtès
2015-11-29 18:12 ` Eli Zaretskii
2015-11-29 20:38 ` Ludovic Courtès
2015-11-30 17:00 ` John Wiegley
2015-11-30 19:30 ` Ludovic Courtès
2015-12-07 18:36 ` Philipp Stephani
2015-12-07 18:58 ` Paul Eggert
2015-12-07 19:00 ` Philipp Stephani
2015-12-07 19:14 ` Paul Eggert
2015-12-20 12:48 ` Philipp Stephani
2015-12-20 16:37 ` Eli Zaretskii
2015-12-20 18:39 ` Philipp Stephani
2015-12-20 19:03 ` Eli Zaretskii
2015-12-20 21:27 ` Paul Eggert
2015-12-23 1:13 ` John Wiegley
2015-12-23 16:01 ` Philipp Stephani
2015-12-23 16:39 ` Eli Zaretskii
2015-12-23 16:52 ` Philipp Stephani
2015-12-23 17:10 ` Eli Zaretskii
2015-12-23 17:38 ` Philipp Stephani
2015-12-23 21:09 ` Paul Eggert [this message]
2015-12-24 3:33 ` Eli Zaretskii
2015-12-24 6:54 ` Paul Eggert
2015-12-24 16:18 ` Eli Zaretskii
2015-12-27 9:53 ` Philipp Stephani
2015-12-27 16:10 ` Eli Zaretskii
2016-02-29 21:52 ` Philipp Stephani
2016-03-01 16:36 ` Paul Eggert
2016-03-01 21:46 ` Philipp Stephani
2016-03-02 18:24 ` Paul Eggert
2016-03-02 18:30 ` Philipp Stephani
2016-03-22 13:30 ` Philipp Stephani
2016-03-22 20:37 ` Paul Eggert
2016-03-22 21:46 ` Philipp Stephani
2016-03-22 21:58 ` Paul Eggert
2016-03-23 8:03 ` Andreas Schwab
2016-04-06 21:29 ` Philipp Stephani
2015-12-27 23:26 ` Paul Eggert
2015-12-28 16:26 ` Eli Zaretskii
2015-12-28 18:00 ` Paul Eggert
2015-12-28 18:23 ` Eli Zaretskii
2015-12-29 3:01 ` Paul Eggert
2015-12-29 15:38 ` Eli Zaretskii
2015-12-29 16:47 ` Paul Eggert
2015-12-29 17:59 ` Eli Zaretskii
2015-12-29 20:33 ` Paul Eggert
2015-12-07 23:11 ` Ludovic Courtès
2015-11-30 9:22 ` Alex Kost
2015-11-29 20:22 ` Paul Eggert
2015-11-29 20:42 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567B0D81.2000106@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).