Philipp Stephani <p.stephani2@gmail.com> schrieb am Mi., 23. Dez. 2015 um
17:52 Uhr:

>
>> (If we do change the option, we should also change the name of the
>> variable and the cpp symbol.)
>>
>> > +(defconst emacs-build-system
>> > +  (if deterministic-dump "unknown" (system-name))
>> >    "Name of the system on which Emacs was built.")
>>
>> Can we find a better string, like "elided" or "undisclosed"?
>> "Unknown" sounds too self-derogatory.
>>
>
> Sure, 'elided' is fine.
>
>
>>
>> > +  DEFVAR_BOOL ("deterministic-dump", Vdeterministic_dump,
>> > +    doc: /* If t, attempt to make dumping deterministic by avoiding
>>
>> I think the usual style is "If non-nil".
>>
>
> ok
>
>
>>
>> > +sources of nondeterminism such as absolute paths, the hostname, or
>>
>> GNU coding standards frown on using "path" for anything that isn't
>> PATH-style list of directories.  Please use "file name" instead.
>>
>>
> ok
>

Attached a new patch with the requested changes. It would be great to defer
the discussion about naming, string vs. nil etc. until later so that this
project can make progress; there's still enough time to discuss until the
changes get releases.