From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: p.stephani2@gmail.com, emacs-devel@gnu.org
Subject: Re: [PATCH PING] Honor 'SOURCE_DATE_EPOCH' when generating autoloads.
Date: Mon, 28 Dec 2015 18:26:58 +0200 [thread overview]
Message-ID: <83ege6fsj1.fsf@gnu.org> (raw)
In-Reply-To: <568073A4.3010604@cs.ucla.edu> (message from Paul Eggert on Sun, 27 Dec 2015 15:26:28 -0800)
> Cc: emacs-devel@gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Sun, 27 Dec 2015 15:26:28 -0800
>
> * Document the changes in etc/NEWS and in the relevant part of the manual.
>
> * Use "deterministic-build", not "deterministic-dump", for the name. I didn't
> understand the need for two variables here; we can add another one if needed.
>
> * Represent unknown values with nil, not with magic strings like "elided" or
> "unknown".
>
> * Make emacs-build-time deterministic, too.
>
> * Adjust the output of emacs-version and similar functions to omit the build date.
>
> * Remove what appears to be an unnecessary initialization in 'main'.
Fine with me in general, with the following comments:
> --- a/doc/lispref/intro.texi
> +++ b/doc/lispref/intro.texi
> @@ -491,19 +491,6 @@ Version Info
> giving a prefix argument makes @var{here} non-@code{nil}.
> @end deffn
>
> -@defvar emacs-build-time
> -The value of this variable indicates the time at which Emacs was
> -built. It is a list of four integers, like the value of
> -@code{current-time} (@pxref{Time of Day}).
> -
> -@example
> -@group
> -emacs-build-time
> - @result{} (20614 63694 515336 438000)
> -@end group
> -@end example
> -@end defvar
Please let's nott remove this part, we are not removing the variable
(and won't be any time soon). Let's just document that the value can
be nil in a "deterministic build".
> -;; I think this should be obsoleted/removed. It's just one more meaningless
> -;; difference between different builds. It's usually not even an fqdn.
> -(defconst emacs-build-system (system-name)
> - "Name of the system on which Emacs was built.")
> +(defconst emacs-build-system
> + (if (not deterministic-build) (system-name))
> + "Name of the system on which Emacs was built, or nil if not available.")
This causes an error in "M-x report-emacs-bug", so something should be
done here or there. (I don't understand why you are so objected to
keeping this a string, even though I specifically stated that I would
like to keep it a string. Is it really worth another dispute?)
Thanks.
next prev parent reply other threads:[~2015-12-28 16:26 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 17:03 [PATCH] Honor 'SOURCE_DATE_EPOCH' when generating autoloads Ludovic Courtès
2015-11-29 10:44 ` [PATCH PING] " Ludovic Courtès
2015-11-29 16:02 ` Eli Zaretskii
2015-11-29 16:57 ` Ludovic Courtès
2015-11-29 18:12 ` Eli Zaretskii
2015-11-29 20:38 ` Ludovic Courtès
2015-11-30 17:00 ` John Wiegley
2015-11-30 19:30 ` Ludovic Courtès
2015-12-07 18:36 ` Philipp Stephani
2015-12-07 18:58 ` Paul Eggert
2015-12-07 19:00 ` Philipp Stephani
2015-12-07 19:14 ` Paul Eggert
2015-12-20 12:48 ` Philipp Stephani
2015-12-20 16:37 ` Eli Zaretskii
2015-12-20 18:39 ` Philipp Stephani
2015-12-20 19:03 ` Eli Zaretskii
2015-12-20 21:27 ` Paul Eggert
2015-12-23 1:13 ` John Wiegley
2015-12-23 16:01 ` Philipp Stephani
2015-12-23 16:39 ` Eli Zaretskii
2015-12-23 16:52 ` Philipp Stephani
2015-12-23 17:10 ` Eli Zaretskii
2015-12-23 17:38 ` Philipp Stephani
2015-12-23 21:09 ` Paul Eggert
2015-12-24 3:33 ` Eli Zaretskii
2015-12-24 6:54 ` Paul Eggert
2015-12-24 16:18 ` Eli Zaretskii
2015-12-27 9:53 ` Philipp Stephani
2015-12-27 16:10 ` Eli Zaretskii
2016-02-29 21:52 ` Philipp Stephani
2016-03-01 16:36 ` Paul Eggert
2016-03-01 21:46 ` Philipp Stephani
2016-03-02 18:24 ` Paul Eggert
2016-03-02 18:30 ` Philipp Stephani
2016-03-22 13:30 ` Philipp Stephani
2016-03-22 20:37 ` Paul Eggert
2016-03-22 21:46 ` Philipp Stephani
2016-03-22 21:58 ` Paul Eggert
2016-03-23 8:03 ` Andreas Schwab
2016-04-06 21:29 ` Philipp Stephani
2015-12-27 23:26 ` Paul Eggert
2015-12-28 16:26 ` Eli Zaretskii [this message]
2015-12-28 18:00 ` Paul Eggert
2015-12-28 18:23 ` Eli Zaretskii
2015-12-29 3:01 ` Paul Eggert
2015-12-29 15:38 ` Eli Zaretskii
2015-12-29 16:47 ` Paul Eggert
2015-12-29 17:59 ` Eli Zaretskii
2015-12-29 20:33 ` Paul Eggert
2015-12-07 23:11 ` Ludovic Courtès
2015-11-30 9:22 ` Alex Kost
2015-11-29 20:22 ` Paul Eggert
2015-11-29 20:42 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ege6fsj1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).