From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [PATCH PING] Honor 'SOURCE_DATE_EPOCH' when generating autoloads. Date: Sun, 27 Dec 2015 09:53:00 +0000 Message-ID: References: <87k2ph3mgx.fsf@gnu.org> <87io4lnkyz.fsf@gnu.org> <83mvtwoktg.fsf@gnu.org> <878u5gkakj.fsf@gnu.org> <83a8pwoesc.fsf@gnu.org> <87two3475d.fsf@gnu.org> <5665D6B9.4030309@cs.ucla.edu> <5665DAA1.2080208@cs.ucla.edu> <83k2o9t6t1.fsf@gnu.org> <56771D52.2070406@cs.ucla.edu> <83fuytp1au.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=089e0102def4f80a440527de2739 X-Trace: ger.gmane.org 1451210000 18620 80.91.229.3 (27 Dec 2015 09:53:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Dec 2015 09:53:20 +0000 (UTC) Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 27 10:53:20 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aD80s-0007Gm-Mu for ged-emacs-devel@m.gmane.org; Sun, 27 Dec 2015 10:53:18 +0100 Original-Received: from localhost ([::1]:41152 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aD80r-0000wd-Vs for ged-emacs-devel@m.gmane.org; Sun, 27 Dec 2015 04:53:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aD80o-0000wO-Ap for emacs-devel@gnu.org; Sun, 27 Dec 2015 04:53:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aD80n-00049w-CA for emacs-devel@gnu.org; Sun, 27 Dec 2015 04:53:14 -0500 Original-Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:35071) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aD80l-00049k-HV; Sun, 27 Dec 2015 04:53:11 -0500 Original-Received: by mail-wm0-x230.google.com with SMTP id l126so237878986wml.0; Sun, 27 Dec 2015 01:53:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-type; bh=1QtyIjvm1PGK9PPJEpjCF+BucZdz4veXnqObpNRmuOg=; b=uKJiHUMgRNyYUFoKoCmolFHTBy3jzs63YRW5P0BRDP5hOKngPoLc/ztPPdVeYUyfxb b7a/H+Tt+78FCar37iOa4XEmfqfXTv7GXD4yVTL7P9Xqfr8VQ9z9PWozj7tqlY+xXJF3 cM9WxOKbRPzvZJxajfhuXPJyQN94NG0cUtAGOt/wC7y6pSA7+I1piX4RhgSFEMN9NMJb UZTNVMlX689OwXrghQbB/pUQegKmDdnwVaNRh8hMYozGBh1rsomf711jWMvL04iHrBgA Gge2gcPQg7QLzfSBRpHaXXSyDWWUprm0yW/hci8a5/dkqzdGc0w8EAKwFQ+oOSX9eh7N 6mrA== X-Received: by 10.194.87.39 with SMTP id u7mr52409580wjz.11.1451209990335; Sun, 27 Dec 2015 01:53:10 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196969 Archived-At: --089e0102def4f80a440527de2739 Content-Type: multipart/alternative; boundary=089e0102def4f80a3f0527de2737 --089e0102def4f80a3f0527de2737 Content-Type: text/plain; charset=UTF-8 Philipp Stephani schrieb am Mi., 23. Dez. 2015 um 17:52 Uhr: > >> (If we do change the option, we should also change the name of the >> variable and the cpp symbol.) >> >> > +(defconst emacs-build-system >> > + (if deterministic-dump "unknown" (system-name)) >> > "Name of the system on which Emacs was built.") >> >> Can we find a better string, like "elided" or "undisclosed"? >> "Unknown" sounds too self-derogatory. >> > > Sure, 'elided' is fine. > > >> >> > + DEFVAR_BOOL ("deterministic-dump", Vdeterministic_dump, >> > + doc: /* If t, attempt to make dumping deterministic by avoiding >> >> I think the usual style is "If non-nil". >> > > ok > > >> >> > +sources of nondeterminism such as absolute paths, the hostname, or >> >> GNU coding standards frown on using "path" for anything that isn't >> PATH-style list of directories. Please use "file name" instead. >> >> > ok > Attached a new patch with the requested changes. It would be great to defer the discussion about naming, string vs. nil etc. until later so that this project can make progress; there's still enough time to discuss until the changes get releases. --089e0102def4f80a3f0527de2737 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Philip= p Stephani <p.stephani2@gmail.c= om> schrieb am Mi., 23. Dez. 2015 um 17:52=C2=A0Uhr:

(If we do change the option, we should also change the name of the
variable and the cpp symbol.)

> +(defconst emacs-build-system
> +=C2=A0 (if deterministic-dump "unknown" (system-name))
>=C2=A0 =C2=A0 "Name of the system on which Emacs was built.")=

Can we find a better string, like "elided" or "undisclosed&q= uot;?
"Unknown" sounds too self-derogatory.

Sure, '= ;elided' is fine.
=C2=A0

> +=C2=A0 DEFVAR_BOOL ("deterministic-dump", Vdeterministic_du= mp,
> +=C2=A0 =C2=A0 doc: /* If t, attempt to make dumping deterministic by = avoiding

I think the usual style is "If non-nil".
ok
=C2=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
> +sources of nondeterminism such as absolute paths, the hostname, or
GNU coding standards frown on using "path" for anything that isn&= #39;t
PATH-style list of directories.=C2=A0 Please use "file name" inst= ead.


ok=C2=A0

Attached a new patch with the requested changes. It would be great to def= er the discussion about naming, string vs. nil etc. until later so that thi= s project can make progress; there's still enough time to discuss until= the changes get releases.=C2=A0
--089e0102def4f80a3f0527de2737-- --089e0102def4f80a440527de2739 Content-Type: application/octet-stream; name="0001-Remove-build-system-name-from-deterministic-dumps.patch" Content-Disposition: attachment; filename="0001-Remove-build-system-name-from-deterministic-dumps.patch" Content-Transfer-Encoding: base64 Content-ID: <151e2daf23598c980db1> X-Attachment-Id: 151e2daf23598c980db1 RnJvbSA2YWM3NDUyNWUwOTQ1NmUwYmUzMmY4YTI1ZGNkMzEzYWYwYWM1MzdkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwIFN0ZXBoYW5pIDxwaHN0QGdvb2dsZS5jb20+CkRh dGU6IFN1biwgMjAgRGVjIDIwMTUgMDE6NTc6MzQgKzAxMDAKU3ViamVjdDogW1BBVENIXSBSZW1v dmUgYnVpbGQgc3lzdGVtIG5hbWUgZnJvbSBkZXRlcm1pbmlzdGljIGR1bXBzLgoKKiBjb25maWd1 cmUuYWMgKERFVEVSTUlOSVNUSUNfRFVNUCk6IE5ldyBjb25maWd1cmF0aW9uIG9wdGlvbi4KKiBl bWFjcy5jIChtYWluKTogSW5pdGlhbGl6ZSBgZGV0ZXJtaW5pc3RpYy1kdW1wJyBmcm9tIHRoZQog IGNvbmZpZ3VyYXRpb24gb3B0aW9uLgogIChzeW1zX29mX2VtYWNzKTogTmV3IGNvbnN0YW50IGBk ZXRlcm1pbmlzdGljLWR1bXAnLgoqIHN5c2RlcC5jIChpbml0X3N5c3RlbV9uYW1lKTogVXNlIGEg Y29uc3RhbnQgaWYgYSBkZXRlcm1pbmlzdGljIGR1bXAgaXMKICByZXF1ZXN0ZWQuCiogdmVyc2lv bi5lbCAoZW1hY3MtYnVpbGQtdGltZSk6IEFkZCBhIGNvbW1lbnQgdG8gbWFrZSB0aGUgYnVpbGQg dGltZQogIGRldGVybWluaXN0aWMgaWYgcmVxdWVzdGVkLgogIChlbWFjcy1idWlsZC1zeXN0ZW0p OiBNYWtlIHZhcmlhYmxlIGRldGVybWluaXN0aWMgaWYgcmVxdWVzdGVkLgotLS0KIGNvbmZpZ3Vy ZS5hYyAgICB8IDEzICsrKysrKysrKysrKysKIGxpc3AvdmVyc2lvbi5lbCB8ICA3ICsrKystLS0K IHNyYy9lbWFjcy5jICAgICB8IDEwICsrKysrKysrKysKIHNyYy9zeXNkZXAuYyAgICB8ICA3ICsr KysrKysKIDQgZmlsZXMgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9jb25maWd1cmUuYWMgYi9jb25maWd1cmUuYWMKaW5kZXggMGI3YjQwMy4u YWJiZTdmOCAxMDA2NDQKLS0tIGEvY29uZmlndXJlLmFjCisrKyBiL2NvbmZpZ3VyZS5hYwpAQCAt NTQyLDYgKzU0MiwxOSBAQCBBQ19BUkdfRU5BQkxFKGd0ay1kZXByZWNhdGlvbi13YXJuaW5ncywK IAkJW1Nob3cgR3RrKy9HZGsgZGVwcmVjYXRpb24gd2FybmluZ3MgZm9yIEd0aysgPj0gMy4wXSld LAogW2FjX2VuYWJsZV9ndGtfZGVwcmVjYXRpb25fd2FybmluZ3M9IiR7ZW5hYmxldmFsfSJdLFtd KQogCitBQ19BUkdfRU5BQkxFKGRldGVybWluaXN0aWMtZHVtcCwKK1tBU19IRUxQX1NUUklORyhb LS1lbmFibGUtZGV0ZXJtaW5pc3RpYy1kdW1wXSwKKyAgICAgICAgICAgICAgICBbTWFrZSBkdW1w aW5nIGRldGVybWluaXN0aWMgYnkgcmVtb3Zpbmcgc3lzdGVtLXNwZWNpZmljCisgICAgICAgICAg ICAgICAgaW5mb3JtYXRpb24gZnJvbSB0aGUgZHVtcCwgc3VjaCBhcyBob3N0IG5hbWVzIGFuZAor ICAgICAgICAgICAgICAgIHRpbWVzdGFtcHMuXSldKQoraWYgdGVzdCAieCR7ZW5hYmxldmFsfSIg PSB4bm8gOyB0aGVuCisgICBBQ19ERUZJTkUoREVURVJNSU5JU1RJQ19EVU1QLCBmYWxzZSwKKyAg IFtTZXQgdGhpcyB0byB0cnVlIHRvIG1ha2UgZHVtcGluZyBkZXRlcm1pbmlzdGljLl0pCitlbHNl CisgICBBQ19ERUZJTkUoREVURVJNSU5JU1RJQ19EVU1QLCB0cnVlLAorICAgW1NldCB0aGlzIHRv IHRydWUgdG8gbWFrZSBkdW1waW5nIGRldGVybWluaXN0aWMuXSkKK2ZpCisKIGRubCBUaGlzIHVz ZWQgdG8gdXNlIGNoYW5nZXF1b3RlLCBidXQsIGFwYXJ0IGZyb20gJ2NoYW5nZXF1b3RlIGlzIGV2 aWwnCiBkbmwgcGVyIHRoZSBhdXRvY29uZiBtYW51YWwsIHdlIGNhbiBzcGVlZCB1cCBhdXRvY29u ZiBzb21ld2hhdCBieSBxdW90aW5nCiBkbmwgdGhlIGdyZWF0IGdvYiBvZiB0ZXh0LiAgVGh1cyBp dCdzIG5vdCBwcm9jZXNzZWQgZm9yIHBvc3NpYmxlIGV4cGFuc2lvbi4KZGlmZiAtLWdpdCBhL2xp c3AvdmVyc2lvbi5lbCBiL2xpc3AvdmVyc2lvbi5lbAppbmRleCA0MzEwM2ZkLi5hM2YwZWEwIDEw MDY0NAotLS0gYS9saXNwL3ZlcnNpb24uZWwKKysrIGIvbGlzcC92ZXJzaW9uLmVsCkBAIC0zOCwx MiArMzgsMTMgQEAgZW1hY3MtbWlub3ItdmVyc2lvbgogICAiTWlub3IgdmVyc2lvbiBudW1iZXIg b2YgdGhpcyB2ZXJzaW9uIG9mIEVtYWNzLgogVGhpcyB2YXJpYWJsZSBmaXJzdCBleGlzdGVkIGlu IHZlcnNpb24gMTkuMjMuIikKIAorOzsgRklYTUU6IFRoZSBuZXh0IHZhcmlhYmxlIHNob3VsZCBh bHNvIGJlIGEgY29uc3RhbnQgaWYKKzs7IGBkZXRlcm1pbmlzdGljLWR1bXAnIGlzIHQuCiAoZGVm Y29uc3QgZW1hY3MtYnVpbGQtdGltZSAoY3VycmVudC10aW1lKQogICAiVGltZSBhdCB3aGljaCBF bWFjcyB3YXMgZHVtcGVkIG91dC4iKQogCi07OyBJIHRoaW5rIHRoaXMgc2hvdWxkIGJlIG9ic29s ZXRlZC9yZW1vdmVkLiAgSXQncyBqdXN0IG9uZSBtb3JlIG1lYW5pbmdsZXNzCi07OyBkaWZmZXJl bmNlIGJldHdlZW4gZGlmZmVyZW50IGJ1aWxkcy4gIEl0J3MgdXN1YWxseSBub3QgZXZlbiBhbiBm cWRuLgotKGRlZmNvbnN0IGVtYWNzLWJ1aWxkLXN5c3RlbSAoc3lzdGVtLW5hbWUpCisoZGVmY29u c3QgZW1hY3MtYnVpbGQtc3lzdGVtCisgIChpZiBkZXRlcm1pbmlzdGljLWR1bXAgImVsaWRlZCIg KHN5c3RlbS1uYW1lKSkKICAgIk5hbWUgb2YgdGhlIHN5c3RlbSBvbiB3aGljaCBFbWFjcyB3YXMg YnVpbHQuIikKIAogKGRlZnZhciBtb3RpZi12ZXJzaW9uLXN0cmluZykKZGlmZiAtLWdpdCBhL3Ny Yy9lbWFjcy5jIGIvc3JjL2VtYWNzLmMKaW5kZXggMmU5Zjk1MC4uODYzNDczYSAxMDA2NDQKLS0t IGEvc3JjL2VtYWNzLmMKKysrIGIvc3JjL2VtYWNzLmMKQEAgLTkyNSw2ICs5MjUsOSBAQCBtYWlu IChpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiAgIFNFVF9CSU5BUlkgKGZpbGVubyAoc3Rkb3V0KSk7 CiAjZW5kaWYgLyogTVNET1MgKi8KIAorICBpZiAoREVURVJNSU5JU1RJQ19EVU1QKQorICAgIFZk ZXRlcm1pbmlzdGljX2R1bXAgPSBRdDsKKwogICAvKiBTa2lwIGluaXRpYWwgc2V0bG9jYWxlIGlm IExDX0FMTCBpcyAiQyIsIGFzIGl0J3Mgbm90IG5lZWRlZCBpbiB0aGF0IGNhc2UuCiAgICAgIFRo ZSBidWlsZCBwcm9jZWR1cmUgdXNlcyB0aGlzIHdoaWxlIGR1bXBpbmcsIHRvIGVuc3VyZSB0aGF0 IHRoZQogICAgICBkdW1wZWQgRW1hY3MgZG9lcyBub3QgaGF2ZSBpdHMgc3lzdGVtIGxvY2FsZSB0 YWJsZXMgaW5pdGlhbGl6ZWQsCkBAIC0yNTY2LDYgKzI1NjksMTMgQEAgbGlicmFyaWVzOyBvbmx5 IHRob3NlIGFscmVhZHkga25vd24gYnkgRW1hY3Mgd2lsbCBiZSBsb2FkZWQuICAqLyk7CiAgIFZk eW5hbWljX2xpYnJhcnlfYWxpc3QgPSBRbmlsOwogICBGcHV0IChpbnRlcm5fY19zdHJpbmcgKCJk eW5hbWljLWxpYnJhcnktYWxpc3QiKSwgUXJpc2t5X2xvY2FsX3ZhcmlhYmxlLCBRdCk7CiAKKyAg REVGVkFSX0JPT0wgKCJkZXRlcm1pbmlzdGljLWR1bXAiLCBWZGV0ZXJtaW5pc3RpY19kdW1wLAor ICAgIGRvYzogLyogSWYgbm9uLW5pbCwgYXR0ZW1wdCB0byBtYWtlIGR1bXBpbmcgZGV0ZXJtaW5p c3RpYyBieQorYXZvaWRpbmcgc291cmNlcyBvZiBub25kZXRlcm1pbmlzbSBzdWNoIGFzIGFic29s dXRlIGZpbGUgbmFtZXMsIHRoZQoraG9zdG5hbWUsIG9yIHRpbWVzdGFtcHMuICAqLyk7CisgIFZk ZXRlcm1pbmlzdGljX2R1bXAgPSBERVRFUk1JTklTVElDX0RVTVAgPyBRdCA6IFFuaWw7CisgIFhT WU1CT0wgKGludGVybl9jX3N0cmluZyAoImRldGVybWluaXN0aWMtZHVtcCIpKS0+Y29uc3RhbnQg PSAxOworCiAjaWZkZWYgV0lORE9XU05UCiAgIFZsaWJyYXJ5X2NhY2hlID0gUW5pbDsKICAgc3Rh dGljcHJvICgmVmxpYnJhcnlfY2FjaGUpOwpkaWZmIC0tZ2l0IGEvc3JjL3N5c2RlcC5jIGIvc3Jj L3N5c2RlcC5jCmluZGV4IDFhZjMyM2UuLjViYmY3MjMgMTAwNjQ0Ci0tLSBhL3NyYy9zeXNkZXAu YworKysgYi9zcmMvc3lzZGVwLmMKQEAgLTEzOTksNiArMTM5OSwxMyBAQCBzZXR1cF9wdHkgKGlu dCBmZCkKIHZvaWQKIGluaXRfc3lzdGVtX25hbWUgKHZvaWQpCiB7CisgIGlmIChERVRFUk1JTklT VElDX0RVTVAgJiYgKG1pZ2h0X2R1bXAgfHwgISBOSUxQIChWcHVyaWZ5X2ZsYWcpKSkKKyAgICB7 CisgICAgICAvKiBJZiB3ZSdyZSBkdW1waW5nLCBzZXQgdGhlIGhvc3RuYW1lIHRvIGEgbGl0ZXJh bCBzbyB0aGF0IHRoZQorICAgICAgICAgZHVtcCBpcyBkZXRlcm1pbmlzdGljLiAgKi8KKyAgICAg IFZzeXN0ZW1fbmFtZSA9IGJ1aWxkX3B1cmVfY19zdHJpbmcgKCJlbGlkZWQiKTsKKyAgICAgIHJl dHVybjsKKyAgICB9CiAgIGNoYXIgKmhvc3RuYW1lX2FsbG9jID0gTlVMTDsKICAgY2hhciAqaG9z dG5hbWU7CiAjaWZuZGVmIEhBVkVfR0VUSE9TVE5BTUUKLS0gCjIuNi4zCgo= --089e0102def4f80a440527de2739--