Re: master d7e848ccda 2/3: Use icons in outline

Re: master d7e848ccda 2/3: Use icons in outline

[Michael Heerdegen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> branch: master
> commit d7e848ccdaab81fed187b415e95c436b6deb2657
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>

> +(defcustom outline-minor-mode-use-buttons '(derived-mode . special-mode)
> +  "Whether to display clickable buttons on the headings.

>  (defvar outline-level #'outline-level
> @@ -434,7 +434,10 @@ outline font-lock faces to those of major mode."
>                           (goto-char (match-beginning 0))
>                           (not (get-text-property (point) 'face))))
>              (overlay-put overlay 'face (outline-font-lock-face)))
> -          (when outline-minor-mode-use-buttons
> +          (when (and outline-minor-mode-use-buttons
> +                     (or (eq outline-minor-mode-use-buttons t)
> +                         (buffer-match-p outline-minor-mode-use-buttons
> +                                         (current-buffer))))

Lars, this has an unintended effect for me: If I ediff buffers with
outline-minor-mode turned on, and do

#+begin_src emacs-lisp
(add-hook 'ediff-prepare-buffer-hook
          (defun test ()
            (when (bound-and-true-p outline-minor-mode)
              (outline-show-all))))
#+end_src

then the ediffed buffers will get buttons.  Worse: they stay even after
finishing Ediff.  Tested with emacs -Q.

Seems that when `ediff-prepare-buffer-hook' is run the buffers are in a
temporary state where the (derived-mode . special-mode) condition is
fulfilled, or something like that.


TIA,

Michael.

Re: master d7e848ccda 2/3: Use icons in outline

[Michael Heerdegen]

Michael Heerdegen <michael_heerdegen@web.de> writes:

> > branch: master
> > commit d7e848ccdaab81fed187b415e95c436b6deb2657
> > Author: Lars Ingebrigtsen <larsi@gnus.org>
> > Commit: Lars Ingebrigtsen <larsi@gnus.org>

Not sure anymore which part of the change is the eval one:

M-x revert-buffer in an elisp-mode buffer with outline-minor-mode on is
enough to let the buttons appear.

Michael.

Re: master d7e848ccda 2/3: Use icons in outline

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> branch: master
> commit d7e848ccdaab81fed187b415e95c436b6deb2657
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Use icons in outline
>     
>     * lisp/help.el (describe-bindings): Don't force buttons on
>     (bug#56691).
>     
>     * lisp/outline.el (outline-minor-mode-use-buttons): Default
>     buttons on in special-mode buffers.

Could this be turned off by default?  In NEWS, this results in the first
asterisk in a nested heading turning into an icon, and the second
asterisk being displayed normally.

In addition to that, the button shown when the heading is hidden is
different from the button shown when it is not.

Re: master d7e848ccda 2/3: Use icons in outline

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Fri, 29 Jul 2022 11:17:16 +0800
> 
> Lars Ingebrigtsen <larsi@gnus.org> writes:
> 
> > branch: master
> > commit d7e848ccdaab81fed187b415e95c436b6deb2657
> > Author: Lars Ingebrigtsen <larsi@gnus.org>
> > Commit: Lars Ingebrigtsen <larsi@gnus.org>
> >
> >     Use icons in outline
> >     
> >     * lisp/help.el (describe-bindings): Don't force buttons on
> >     (bug#56691).
> >     
> >     * lisp/outline.el (outline-minor-mode-use-buttons): Default
> >     buttons on in special-mode buffers.
> 
> Could this be turned off by default?  In NEWS, this results in the first
> asterisk in a nested heading turning into an icon, and the second
> asterisk being displayed normally.

Isn't that a bug?  I'd expect the entire string of asterisks to be
replaced by the icon.

Re: master d7e848ccda 2/3: Use icons in outline

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> Isn't that a bug?  I'd expect the entire string of asterisks to be
> replaced by the icon.

In that case the depth of the heading isn't visible, so using an icon
there loses information.

And IMNSHO there is no point in using icons instead of asterisks, so
either way this should really just be turned off.

Re: master d7e848ccda 2/3: Use icons in outline

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org,  larsi@gnus.org
> Date: Fri, 29 Jul 2022 14:47:10 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Isn't that a bug?  I'd expect the entire string of asterisks to be
> > replaced by the icon.
> 
> In that case the depth of the heading isn't visible, so using an icon
> there loses information.

That depends on how the icon is displayed, doesn't it?

Btw, why don't we support6 the "standard" way of displaying multilevel
itemized lists: with '+' and '-' icons and suitable indentation?

> And IMNSHO there is no point in using icons instead of asterisks

I disagree, FWIW.  You are, in effect, saying that the entire feature
should be deleted from Emacs, and that is definitely not so.

Re: master d7e848ccda 2/3: Use icons in outline

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> That depends on how the icon is displayed, doesn't it?

At present it is only displayed in column 0.

> Btw, why don't we support6 the "standard" way of displaying multilevel
> itemized lists: with '+' and '-' icons and suitable indentation?

That would be nice, yes.

> I disagree, FWIW.  You are, in effect, saying that the entire feature
> should be deleted from Emacs, and that is definitely not so.

I meant that specifically in the case of outline-mode in files such as
NEWS, not customizable icons in general.

Re: master d7e848ccda 2/3: Use icons in outline

[Lars Ingebrigtsen]

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Lars, this has an unintended effect for me: If I ediff buffers with
> outline-minor-mode turned on, and do
>
> #+begin_src emacs-lisp
> (add-hook 'ediff-prepare-buffer-hook
>           (defun test ()
>             (when (bound-and-true-p outline-minor-mode)
>               (outline-show-all))))
> #+end_src
>
> then the ediffed buffers will get buttons.  Worse: they stay even after
> finishing Ediff.  Tested with emacs -Q.
>
> Seems that when `ediff-prepare-buffer-hook' is run the buffers are in a
> temporary state where the (derived-mode . special-mode) condition is
> fulfilled, or something like that.

The logic for using buttons was completely wrong -- I've now fixed it on
the trunk.  Can you see whether this fixes this problem, too?

Re: master d7e848ccda 2/3: Use icons in outline

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> Could this be turned off by default?  In NEWS, this results in the first
> asterisk in a nested heading turning into an icon, and the second
> asterisk being displayed normally.

Which one of the NEWS modes is this with?

> In addition to that, the button shown when the heading is hidden is
> different from the button shown when it is not.

That's on purpose?  It's open/close icons.

Re: master d7e848ccda 2/3: Use icons in outline

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> The logic for using buttons was completely wrong -- I've now fixed it on
> the trunk.  Can you see whether this fixes this problem, too?

(I think perhaps the button stuff needs even more tweaking, but I'm not
sure.  In major modes we have more freedom to do things, but getting
these defaults right for minor modes is more tricky.  I'm thinking of
adding some more stuff here to allow major modes to "opt in" to
buttonising when they're prepared for it.  But
`outline-minor-mode-use-buttons' would still let users opt out of it, of
course.)

Re: master d7e848ccda 2/3: Use icons in outline

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Po Lu <luangruo@yahoo.com> writes:
>
>> Could this be turned off by default?  In NEWS, this results in the first
>> asterisk in a nested heading turning into an icon, and the second
>> asterisk being displayed normally.
>
> Which one of the NEWS modes is this with?

Both.

>> In addition to that, the button shown when the heading is hidden is
>> different from the button shown when it is not.
>
> That's on purpose?  It's open/close icons.

I meant that the size of the two buttons are different.

Re: master d7e848ccda 2/3: Use icons in outline

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

>> Which one of the NEWS modes is this with?
>
> Both.
>
>>> In addition to that, the button shown when the heading is hidden is
>>> different from the button shown when it is not.
>>
>> That's on purpose?  It's open/close icons.
>
> I meant that the size of the two buttons are different.

Perhaps it's better to open a bug report for this, with a complete
recipe to reproduce the problem, and some screenshots.

Re: master d7e848ccda 2/3: Use icons in outline

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Perhaps it's better to open a bug report for this, with a complete
> recipe to reproduce the problem, and some screenshots.

Will do.

Re: master d7e848ccda 2/3: Use icons in outline

[Michael Heerdegen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> The logic for using buttons was completely wrong -- I've now fixed it
> on the trunk.  Can you see whether this fixes this problem, too?

Yes, I didn't see something like that today, and I also can't reproduce
it with the recipe from yesterday.

Thanks for fixing,

Michael.