From: Lars Ingebrigtsen <larsi@gnus.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: emacs-devel@gnu.org
Subject: Re: master d7e848ccda 2/3: Use icons in outline
Date: Fri, 29 Jul 2022 13:36:30 +0200 [thread overview]
Message-ID: <874jz0m9q9.fsf@gnus.org> (raw)
In-Reply-To: <87sfmkznvv.fsf@web.de> (Michael Heerdegen's message of "Fri, 29 Jul 2022 03:52:20 +0200")
Michael Heerdegen <michael_heerdegen@web.de> writes:
> Lars, this has an unintended effect for me: If I ediff buffers with
> outline-minor-mode turned on, and do
>
> #+begin_src emacs-lisp
> (add-hook 'ediff-prepare-buffer-hook
> (defun test ()
> (when (bound-and-true-p outline-minor-mode)
> (outline-show-all))))
> #+end_src
>
> then the ediffed buffers will get buttons. Worse: they stay even after
> finishing Ediff. Tested with emacs -Q.
>
> Seems that when `ediff-prepare-buffer-hook' is run the buffers are in a
> temporary state where the (derived-mode . special-mode) condition is
> fulfilled, or something like that.
The logic for using buttons was completely wrong -- I've now fixed it on
the trunk. Can you see whether this fixes this problem, too?
next prev parent reply other threads:[~2022-07-29 11:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165901198499.7036.2651373879831716862@vcs2.savannah.gnu.org>
[not found] ` <20220728123946.8E45DC0F203@vcs2.savannah.gnu.org>
2022-07-29 1:52 ` master d7e848ccda 2/3: Use icons in outline Michael Heerdegen
2022-07-29 2:28 ` Michael Heerdegen
2022-07-29 11:36 ` Lars Ingebrigtsen [this message]
2022-07-29 11:43 ` Lars Ingebrigtsen
2022-07-30 4:22 ` Michael Heerdegen
2022-07-29 3:17 ` Po Lu
2022-07-29 6:08 ` Eli Zaretskii
2022-07-29 6:47 ` Po Lu
2022-07-29 7:22 ` Eli Zaretskii
2022-07-29 8:07 ` Po Lu
2022-07-29 11:39 ` Lars Ingebrigtsen
2022-07-29 11:53 ` Po Lu
2022-07-29 12:02 ` Lars Ingebrigtsen
2022-07-29 12:35 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jz0m9q9.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).