From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: master d7e848ccda 2/3: Use icons in outline Date: Fri, 29 Jul 2022 03:52:20 +0200 Message-ID: <87sfmkznvv.fsf@web.de> References: <165901198499.7036.2651373879831716862@vcs2.savannah.gnu.org> <20220728123946.8E45DC0F203@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13280"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 29 03:54:05 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHFCX-0003Jc-7i for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Jul 2022 03:54:05 +0200 Original-Received: from localhost ([::1]:53850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oHFCW-0000pW-6z for ged-emacs-devel@m.gmane-mx.org; Thu, 28 Jul 2022 21:54:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHFAw-0007vY-6p for emacs-devel@gnu.org; Thu, 28 Jul 2022 21:52:28 -0400 Original-Received: from mout.web.de ([212.227.15.3]:59757) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHFAu-0004Or-F8 for emacs-devel@gnu.org; Thu, 28 Jul 2022 21:52:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1659059541; bh=UxUOANlBM97skYpqr3BfetfjaGY0T2U4xB/Fqb/QIvs=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=dNl26azwf0xazF/I74bOnpyTCj6aMEmsw/i/D+JpjBrzfWhvckot6XHLGL+mHKaOK Hn8m4Sk7IWTYVuaKI4/YHIS4urinMo3o7SFSaJCHg05Hhcw4sKgjjzjISpo0MKcumE WWa4iO8rrFPp0P/pclUD2T+PWNMBmvTdeDuxSeNs= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MWiA0-1nxSAv3DI0-00XVUo; Fri, 29 Jul 2022 03:52:21 +0200 In-Reply-To: <20220728123946.8E45DC0F203@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Thu, 28 Jul 2022 08:39:46 -0400 (EDT)") X-Provags-ID: V03:K1:JGcRt94cDEKYXgJ6OPcM9bn6VgiY9brs+9UqRVBfu/nAYs4PikD 3lDzO+nApj/ZaWp2aUMY3in5jVH/zTYB2bEMnhlahvcb6ypDmh4yoBIxhKuzShfi62vozU2 laElFFsuPbnDrcvQZ/RpO9kQm5I0VzyTLtXS04LgEZJ2/LpVHHEMIsOTDofS6Mor97YAzu8 KUojyQ1gxY06bykjlMuFg== X-UI-Out-Filterresults: notjunk:1;V03:K0:81CuylNj4wE=:H4GV9OKe7SjJ6wo/NzMF6F 2iCvC8BLZX+plUuJ45kYnbkYzU1O47W9Y1HdRIe79/f/bfiA1sByIcvJHkEBfyiGzqhDIAu+I xhOnk6B210Zfz3SPwWNG5YuBuW2NoHNKeoNv298LKIu44gHscGZ+PDkWBDQaerV1rVxI7Rq5r rdW4n5sso6pr0DJVWeOBlCg4LrSI4w+wXZdJe+lMqnPSG5q+89Ir0oqfmHaYB/ubj9ExtSQ44 V2DZr5oHSlIeBQppLe21a3aAa7Uete5lHKPS95AhjjeAVAEujn2aBcqSWeDMfDiRCP1pKcSc8 LR8Lj295ft0E1eESQPheYuIkEp2JfIGX7Sn1EEN95MFfezHfHtaz9cLvDVuovLFHbE/oR5r0a 3N12p1k91mkaAHABaze4UZtSzhmYF7mihBYx49IHfK0FqmatP4tGohSHGMMuUgNb8vdfzwtvz ItyuA/mDMwKZKvD8/pLAh1velV5vEvcfilWR1xIwXQCZ0HhCDA8lSs20ASQAhC28bfEUq5qi3 L0P7f18QkKjmF/+TuKpbDS0OuAHSnDaJC0/2CC8+8pxk9wNmEKdpw19v1L1B8fzG1FeRSWiWt W3n7pEyIM6G7zMRXrcD2fn7aX2P+G6Ww49/HrSXSdjsY8d1RBulUefFa3QgxYZy046dBjisBC CTyPsR8ltEzdtCFMC2pQq4I/t1OK/hU2TEofCWE2YJeTilMAN7lLAab+jzUHt/QErvz3C2SNT toACxg100kQxirr7txM+FwnNJ7SgYM6smiW7H8kC42EYndmn+wzw/tcD1nHRrP0mPB8A/70V Received-SPF: pass client-ip=212.227.15.3; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292808 Archived-At: Lars Ingebrigtsen writes: > branch: master > commit d7e848ccdaab81fed187b415e95c436b6deb2657 > Author: Lars Ingebrigtsen > Commit: Lars Ingebrigtsen > +(defcustom outline-minor-mode-use-buttons '(derived-mode . special-mode) > + "Whether to display clickable buttons on the headings. > (defvar outline-level #'outline-level > @@ -434,7 +434,10 @@ outline font-lock faces to those of major mode." > (goto-char (match-beginning 0)) > (not (get-text-property (point) 'face)))) > (overlay-put overlay 'face (outline-font-lock-face))) > - (when outline-minor-mode-use-buttons > + (when (and outline-minor-mode-use-buttons > + (or (eq outline-minor-mode-use-buttons t) > + (buffer-match-p outline-minor-mode-use-buttons > + (current-buffer)))) Lars, this has an unintended effect for me: If I ediff buffers with outline-minor-mode turned on, and do #+begin_src emacs-lisp (add-hook 'ediff-prepare-buffer-hook (defun test () (when (bound-and-true-p outline-minor-mode) (outline-show-all)))) #+end_src then the ediffed buffers will get buttons. Worse: they stay even after finishing Ediff. Tested with emacs -Q. Seems that when `ediff-prepare-buffer-hook' is run the buffers are in a temporary state where the (derived-mode . special-mode) condition is fulfilled, or something like that. TIA, Michael.