From: Michael Heerdegen <michael_heerdegen@web.de>
To: emacs-devel@gnu.org
Cc: Lars Ingebrigtsen <larsi@gnus.org>
Subject: Re: master d7e848ccda 2/3: Use icons in outline
Date: Fri, 29 Jul 2022 03:52:20 +0200 [thread overview]
Message-ID: <87sfmkznvv.fsf@web.de> (raw)
In-Reply-To: <20220728123946.8E45DC0F203@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Thu, 28 Jul 2022 08:39:46 -0400 (EDT)")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> branch: master
> commit d7e848ccdaab81fed187b415e95c436b6deb2657
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
> +(defcustom outline-minor-mode-use-buttons '(derived-mode . special-mode)
> + "Whether to display clickable buttons on the headings.
> (defvar outline-level #'outline-level
> @@ -434,7 +434,10 @@ outline font-lock faces to those of major mode."
> (goto-char (match-beginning 0))
> (not (get-text-property (point) 'face))))
> (overlay-put overlay 'face (outline-font-lock-face)))
> - (when outline-minor-mode-use-buttons
> + (when (and outline-minor-mode-use-buttons
> + (or (eq outline-minor-mode-use-buttons t)
> + (buffer-match-p outline-minor-mode-use-buttons
> + (current-buffer))))
Lars, this has an unintended effect for me: If I ediff buffers with
outline-minor-mode turned on, and do
#+begin_src emacs-lisp
(add-hook 'ediff-prepare-buffer-hook
(defun test ()
(when (bound-and-true-p outline-minor-mode)
(outline-show-all))))
#+end_src
then the ediffed buffers will get buttons. Worse: they stay even after
finishing Ediff. Tested with emacs -Q.
Seems that when `ediff-prepare-buffer-hook' is run the buffers are in a
temporary state where the (derived-mode . special-mode) condition is
fulfilled, or something like that.
TIA,
Michael.
next parent reply other threads:[~2022-07-29 1:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165901198499.7036.2651373879831716862@vcs2.savannah.gnu.org>
[not found] ` <20220728123946.8E45DC0F203@vcs2.savannah.gnu.org>
2022-07-29 1:52 ` Michael Heerdegen [this message]
2022-07-29 2:28 ` master d7e848ccda 2/3: Use icons in outline Michael Heerdegen
2022-07-29 11:36 ` Lars Ingebrigtsen
2022-07-29 11:43 ` Lars Ingebrigtsen
2022-07-30 4:22 ` Michael Heerdegen
2022-07-29 3:17 ` Po Lu
2022-07-29 6:08 ` Eli Zaretskii
2022-07-29 6:47 ` Po Lu
2022-07-29 7:22 ` Eli Zaretskii
2022-07-29 8:07 ` Po Lu
2022-07-29 11:39 ` Lars Ingebrigtsen
2022-07-29 11:53 ` Po Lu
2022-07-29 12:02 ` Lars Ingebrigtsen
2022-07-29 12:35 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfmkznvv.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).