From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master d7e848ccda 2/3: Use icons in outline Date: Fri, 29 Jul 2022 13:36:30 +0200 Message-ID: <874jz0m9q9.fsf@gnus.org> References: <165901198499.7036.2651373879831716862@vcs2.savannah.gnu.org> <20220728123946.8E45DC0F203@vcs2.savannah.gnu.org> <87sfmkznvv.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19356"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 29 13:37:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHOJA-0004tV-Kw for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Jul 2022 13:37:32 +0200 Original-Received: from localhost ([::1]:57074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oHOJ9-0007If-Lh for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Jul 2022 07:37:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHOII-0006cA-64 for emacs-devel@gnu.org; Fri, 29 Jul 2022 07:36:38 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:60250) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHOIG-0001YZ-N0 for emacs-devel@gnu.org; Fri, 29 Jul 2022 07:36:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QKpzft1eGaAvOgQBzlZ4ipYw9ckkJsk3O0hF3SvG1Rk=; b=thOyFG4Ho7i9UIB3nKpzUTJwKU oUvh6zOeU+5JZi8Ic0TvYcGZaJh0la4SzoaUyLQc4sqwAOgIcyy2hp5I2Hg5vsvharb1ru4R3YyDD LQG4HERF7WqJsK4sTxsQWlZ3+AqX+DQT6Boq7ICIqtWo3R2dm86bHcllRRRoGjSRZHXU=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHOIC-000653-0R; Fri, 29 Jul 2022 13:36:34 +0200 In-Reply-To: <87sfmkznvv.fsf@web.de> (Michael Heerdegen's message of "Fri, 29 Jul 2022 03:52:20 +0200") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEX8/PzT1c7Cxbub n5tbXl09P0B9goAjIyP///9OMG5TAAAAAWJLR0QIht6VegAAAAd0SU1FB+YHHQsUGC0NoY8AAAG2 SURBVDjLzZJNbtswEIWd+gKW1WQdU84BzGHVtcOhsy5KgvvE6AUigdfPeyM7bdptUXQgAtJ8mr83 XK3+a+tcd9PB/gAi0uPI7///Yh//Dz7KMCAi+H86wWazWa1shs0H/2dFP5IKLO+6rWNr4xHgk3TB 3LDvFyAHgLXbBoVTaY8gVwAhFCCr4tFDtx0u4G7U58AIC4os49w9i5+1Z6rMIJCOxMCP+JQTvFbl FDzJjkBeqnkT/C/MD8KIO5EliZmw3V23gNBm+tJCaP5gqb62Rlf+CeQdTOIlxHD1CyW5zQ+tzSwT 3yudjibiFwJYmAtFw3Y9273ZAkwnVBye3R7vGbpwAf2w54fqqHEMqbUCwHYfUm1zJoGYKeFFvIE1 5pgoVaHIbY4izlIZSPk6R/QDJrca4xkAYuVlaOf8Ikl/1jZpLnU+JaZxDqnubcDSpqChtNyOAwDP EoGuWCPF+uqUwNs+ekHvjcNrbVGZzjsTMWqt7WIWiv6o1fqJ3/QWnBzPqdTyjVrtkX5OiFJtLdr4 +mg30aWCFSYGAIhdPJt8LFxhnUheZbwC3HNcPghh52D3zVb71+wNr3qtX4v6ItAAAAAldEVYdGRh dGU6Y3JlYXRlADIwMjItMDctMjlUMTE6MjA6MjQrMDA6MDDPKhh8AAAAJXRFWHRkYXRlOm1vZGlm eQAyMDIyLTA3LTI5VDExOjIwOjI0KzAwOjAwvnegwAAAAABJRU5ErkJggg== X-Now-Playing: Normil Hawaiians's _More Wealth Than Money_: "Other Ways Of Knowing" Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292827 Archived-At: Michael Heerdegen writes: > Lars, this has an unintended effect for me: If I ediff buffers with > outline-minor-mode turned on, and do > > #+begin_src emacs-lisp > (add-hook 'ediff-prepare-buffer-hook > (defun test () > (when (bound-and-true-p outline-minor-mode) > (outline-show-all)))) > #+end_src > > then the ediffed buffers will get buttons. Worse: they stay even after > finishing Ediff. Tested with emacs -Q. > > Seems that when `ediff-prepare-buffer-hook' is run the buffers are in a > temporary state where the (derived-mode . special-mode) condition is > fulfilled, or something like that. The logic for using buttons was completely wrong -- I've now fixed it on the trunk. Can you see whether this fixes this problem, too?