Re: Ellama comments

Re: Ellama comments

[Philip Kaludercic]

The development mailing list got dropped, I've added it again.

Sergey Kostyaev <sskostyaev@gmail.com> writes:

> Today I finally got signed CA. What’s my next steps to move ellama to GNU Elpa?

The first thing that you'll need to do is to update the copyright
string, and replace it with

  ;; Copyright (C) 2023  Free Software Foundation, Inc.

and bump the version header.

Unless we find any further issues, I can just add the package to
elpa.git and that is that.

> I have fixed most of your comments and fix customization group
> soon. Spinner instead of progress-reporter because it was contribution
> from other person. And I like it - it has high level api. And it’s
> informative enough.

OK, if you say so, it just seems like an unnecessary dependency to me,
that might also be a soft dependency.

> Best Regards,
> Sergei Kostiaev
>
>> 3 нояб. 2023 г., в 00:24, Philip Kaludercic <philipk@posteo.net> написал(а):
>> 
>> Sergey Kostyaev <sskostyaev@gmail.com> writes:
>> 
>>> Hi, Philip. I'm honored. It's OK for me in general. I need to check my
>>> job contract about signature for GNU Elpa. And I'm in Russia now, can
>>> this be a problem? I need some time to investigate your comments. I
>>> will reply more specifically a few days later.
>> 
>> I don't expect that there should be an issue wrt to Russia, but I cannot
>> say for sure.
>> 
>>> Best regards,
>>> Sergey Kostyaev 
>>> 
>>> 2 ноября 2023 г. 11:23:04 UTC, Philip Kaludercic <philipk@posteo.net> пишет:
>>>> 
>>>> Hi, I was looking into proposing the inclusion of Ellama to NonGNU ELPA
>>>> (or ideally GNU ELPA if you are OK with it), but I first wanted to send
>>>> you a few comments on the code:
>>>> 
>> 
>> Sergey Kostyaev <sskostyaev@gmail.com> writes:
>> 
>>> About job contract all fine. What should I do with code by other
>>> contributors to move project to GNU Elpa? Are there any cheatsheets
>>> about it? About code comments I will reply later.
>> 
>> It is necessary that all significant contributors have signed the FSF
>> copyright assignment (CA), but from what I see you seem to be the only one
>> that would qualify as such (more than 15 lines of substantial code is
>> the way this is usually approximated).
>> 
>> Have you already signed the CA?  If not, send an email to
>> emacs-devel@gnu.org to request the form.
>> 
>>> 2 ноября 2023 г. 11:23:04 UTC, Philip Kaludercic <philipk@posteo.net> пишет:
>>>> 
>>>> Hi, I was looking into proposing the inclusion of Ellama to NonGNU ELPA
>>>> (or ideally GNU ELPA if you are OK with it), but I first wanted to send
>>>> you a few comments on the code:
>>>> 

Re: Ellama comments

[Sergey Kostyaev]

Done.

> 14 дек. 2023 г., в 18:18, Philip Kaludercic <philipk@posteo.net> написал(а):
> 
> The development mailing list got dropped, I've added it again.
> 
> Sergey Kostyaev <sskostyaev@gmail.com> writes:
> 
>> Today I finally got signed CA. What’s my next steps to move ellama to GNU Elpa?
> 
> The first thing that you'll need to do is to update the copyright
> string, and replace it with
> 
>  ;; Copyright (C) 2023  Free Software Foundation, Inc.
> 
> and bump the version header.
> 
> Unless we find any further issues, I can just add the package to
> elpa.git and that is that.
> 
>> I have fixed most of your comments and fix customization group
>> soon. Spinner instead of progress-reporter because it was contribution
>> from other person. And I like it - it has high level api. And it’s
>> informative enough.
> 
> OK, if you say so, it just seems like an unnecessary dependency to me,
> that might also be a soft dependency.
> 
>> Best Regards,
>> Sergei Kostiaev
>> 
>>> 3 нояб. 2023 г., в 00:24, Philip Kaludercic <philipk@posteo.net> написал(а):
>>> 
>>> Sergey Kostyaev <sskostyaev@gmail.com> writes:
>>> 
>>>> Hi, Philip. I'm honored. It's OK for me in general. I need to check my
>>>> job contract about signature for GNU Elpa. And I'm in Russia now, can
>>>> this be a problem? I need some time to investigate your comments. I
>>>> will reply more specifically a few days later.
>>> 
>>> I don't expect that there should be an issue wrt to Russia, but I cannot
>>> say for sure.
>>> 
>>>> Best regards,
>>>> Sergey Kostyaev 
>>>> 
>>>> 2 ноября 2023 г. 11:23:04 UTC, Philip Kaludercic <philipk@posteo.net> пишет:
>>>>> 
>>>>> Hi, I was looking into proposing the inclusion of Ellama to NonGNU ELPA
>>>>> (or ideally GNU ELPA if you are OK with it), but I first wanted to send
>>>>> you a few comments on the code:
>>>>> 
>>> 
>>> Sergey Kostyaev <sskostyaev@gmail.com> writes:
>>> 
>>>> About job contract all fine. What should I do with code by other
>>>> contributors to move project to GNU Elpa? Are there any cheatsheets
>>>> about it? About code comments I will reply later.
>>> 
>>> It is necessary that all significant contributors have signed the FSF
>>> copyright assignment (CA), but from what I see you seem to be the only one
>>> that would qualify as such (more than 15 lines of substantial code is
>>> the way this is usually approximated).
>>> 
>>> Have you already signed the CA?  If not, send an email to
>>> emacs-devel@gnu.org to request the form.
>>> 
>>>> 2 ноября 2023 г. 11:23:04 UTC, Philip Kaludercic <philipk@posteo.net> пишет:
>>>>> 
>>>>> Hi, I was looking into proposing the inclusion of Ellama to NonGNU ELPA
>>>>> (or ideally GNU ELPA if you are OK with it), but I first wanted to send
>>>>> you a few comments on the code:
>>>>> 

Re: Ellama comments

[Philip Kaludercic]

[-- Attachment #1: Type: text/plain, Size: 86 bytes --]

Sergey Kostyaev <sskostyaev@gmail.com> writes:

> Done.

OK, the package builds now.


[-- Attachment #2: Type: text/plain, Size: 509 bytes --]

diff --git a/elpa-packages b/elpa-packages
index 07f9e2373e..8695a87faf 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -258,6 +258,7 @@
  ;;(eldoc-eval		:url "https://github.com/thierryvolpiatto/eldoc-eval.git")
  (electric-spacing	:url nil)
  (elisp-benchmarks	:url nil)
+ (ellama                :url "https://github.com/s-kostyaev/ellama")
  (emacs-gc-stats	:url "https://git.sr.ht/~yantar92/emacs-gc-stats"
   :ignored-files ("COPYING"))
  ;; FIXME: Work in progress.  The copyright paperwork is ready.

[-- Attachment #3: Type: text/plain, Size: 3362 bytes --]



I would also recommend adding an .elpaignore, with these lines:

--8<---------------cut here---------------start------------->8---
.github
imgs
--8<---------------cut here---------------end--------------->8---

To avoid packaging them in the release tarball.

I'll wait a bit to see if there are any comments, and then publish the
package.

>> 14 дек. 2023 г., в 18:18, Philip Kaludercic <philipk@posteo.net> написал(а):
>> 
>> The development mailing list got dropped, I've added it again.
>> 
>> Sergey Kostyaev <sskostyaev@gmail.com> writes:
>> 
>>> Today I finally got signed CA. What’s my next steps to move ellama to GNU Elpa?
>> 
>> The first thing that you'll need to do is to update the copyright
>> string, and replace it with
>> 
>>  ;; Copyright (C) 2023  Free Software Foundation, Inc.
>> 
>> and bump the version header.
>> 
>> Unless we find any further issues, I can just add the package to
>> elpa.git and that is that.
>> 
>>> I have fixed most of your comments and fix customization group
>>> soon. Spinner instead of progress-reporter because it was contribution
>>> from other person. And I like it - it has high level api. And it’s
>>> informative enough.
>> 
>> OK, if you say so, it just seems like an unnecessary dependency to me,
>> that might also be a soft dependency.
>> 
>>> Best Regards,
>>> Sergei Kostiaev
>>> 
>>>> 3 нояб. 2023 г., в 00:24, Philip Kaludercic <philipk@posteo.net> написал(а):
>>>> 
>>>> Sergey Kostyaev <sskostyaev@gmail.com> writes:
>>>> 
>>>>> Hi, Philip. I'm honored. It's OK for me in general. I need to check my
>>>>> job contract about signature for GNU Elpa. And I'm in Russia now, can
>>>>> this be a problem? I need some time to investigate your comments. I
>>>>> will reply more specifically a few days later.
>>>> 
>>>> I don't expect that there should be an issue wrt to Russia, but I cannot
>>>> say for sure.
>>>> 
>>>>> Best regards,
>>>>> Sergey Kostyaev 
>>>>> 
>>>>> 2 ноября 2023 г. 11:23:04 UTC, Philip Kaludercic <philipk@posteo.net> пишет:
>>>>>> 
>>>>>> Hi, I was looking into proposing the inclusion of Ellama to NonGNU ELPA
>>>>>> (or ideally GNU ELPA if you are OK with it), but I first wanted to send
>>>>>> you a few comments on the code:
>>>>>> 
>>>> 
>>>> Sergey Kostyaev <sskostyaev@gmail.com> writes:
>>>> 
>>>>> About job contract all fine. What should I do with code by other
>>>>> contributors to move project to GNU Elpa? Are there any cheatsheets
>>>>> about it? About code comments I will reply later.
>>>> 
>>>> It is necessary that all significant contributors have signed the FSF
>>>> copyright assignment (CA), but from what I see you seem to be the only one
>>>> that would qualify as such (more than 15 lines of substantial code is
>>>> the way this is usually approximated).
>>>> 
>>>> Have you already signed the CA?  If not, send an email to
>>>> emacs-devel@gnu.org to request the form.
>>>> 
>>>>> 2 ноября 2023 г. 11:23:04 UTC, Philip Kaludercic <philipk@posteo.net> пишет:
>>>>>> 
>>>>>> Hi, I was looking into proposing the inclusion of Ellama to NonGNU ELPA
>>>>>> (or ideally GNU ELPA if you are OK with it), but I first wanted to send
>>>>>> you a few comments on the code:
>>>>>> 
>

-- 
Philip Kaludercic

Re: Ellama comments

[Sergey Kostyaev]

[-- Attachment #1: Type: text/plain, Size: 4274 bytes --]

.elpaignore added, thank you.

> 17 дек. 2023 г., в 19:06, Philip Kaludercic <philipk@posteo.net> написал(а):
> 
> Sergey Kostyaev <sskostyaev@gmail.com <mailto:sskostyaev@gmail.com>> writes:
> 
>> Done.
> 
> OK, the package builds now.
> 
> diff --git a/elpa-packages b/elpa-packages
> index 07f9e2373e..8695a87faf 100644
> --- a/elpa-packages
> +++ b/elpa-packages
> @@ -258,6 +258,7 @@
>  ;;(eldoc-eval		:url "https://github.com/thierryvolpiatto/eldoc-eval.git")
>  (electric-spacing	:url nil)
>  (elisp-benchmarks	:url nil)
> + (ellama                :url "https://github.com/s-kostyaev/ellama")
>  (emacs-gc-stats	:url "https://git.sr.ht/~yantar92/emacs-gc-stats"
>   :ignored-files ("COPYING"))
>  ;; FIXME: Work in progress.  The copyright paperwork is ready.
> 
> 
> I would also recommend adding an .elpaignore, with these lines:
> 
> --8<---------------cut here---------------start------------->8---
> .github
> imgs
> --8<---------------cut here---------------end--------------->8---
> 
> To avoid packaging them in the release tarball.
> 
> I'll wait a bit to see if there are any comments, and then publish the
> package.
> 
>>> 14 дек. 2023 г., в 18:18, Philip Kaludercic <philipk@posteo.net> написал(а):
>>> 
>>> The development mailing list got dropped, I've added it again.
>>> 
>>> Sergey Kostyaev <sskostyaev@gmail.com> writes:
>>> 
>>>> Today I finally got signed CA. What’s my next steps to move ellama to GNU Elpa?
>>> 
>>> The first thing that you'll need to do is to update the copyright
>>> string, and replace it with
>>> 
>>> ;; Copyright (C) 2023  Free Software Foundation, Inc.
>>> 
>>> and bump the version header.
>>> 
>>> Unless we find any further issues, I can just add the package to
>>> elpa.git and that is that.
>>> 
>>>> I have fixed most of your comments and fix customization group
>>>> soon. Spinner instead of progress-reporter because it was contribution
>>>> from other person. And I like it - it has high level api. And it’s
>>>> informative enough.
>>> 
>>> OK, if you say so, it just seems like an unnecessary dependency to me,
>>> that might also be a soft dependency.
>>> 
>>>> Best Regards,
>>>> Sergei Kostiaev
>>>> 
>>>>> 3 нояб. 2023 г., в 00:24, Philip Kaludercic <philipk@posteo.net> написал(а):
>>>>> 
>>>>> Sergey Kostyaev <sskostyaev@gmail.com> writes:
>>>>> 
>>>>>> Hi, Philip. I'm honored. It's OK for me in general. I need to check my
>>>>>> job contract about signature for GNU Elpa. And I'm in Russia now, can
>>>>>> this be a problem? I need some time to investigate your comments. I
>>>>>> will reply more specifically a few days later.
>>>>> 
>>>>> I don't expect that there should be an issue wrt to Russia, but I cannot
>>>>> say for sure.
>>>>> 
>>>>>> Best regards,
>>>>>> Sergey Kostyaev 
>>>>>> 
>>>>>> 2 ноября 2023 г. 11:23:04 UTC, Philip Kaludercic <philipk@posteo.net> пишет:
>>>>>>> 
>>>>>>> Hi, I was looking into proposing the inclusion of Ellama to NonGNU ELPA
>>>>>>> (or ideally GNU ELPA if you are OK with it), but I first wanted to send
>>>>>>> you a few comments on the code:
>>>>>>> 
>>>>> 
>>>>> Sergey Kostyaev <sskostyaev@gmail.com> writes:
>>>>> 
>>>>>> About job contract all fine. What should I do with code by other
>>>>>> contributors to move project to GNU Elpa? Are there any cheatsheets
>>>>>> about it? About code comments I will reply later.
>>>>> 
>>>>> It is necessary that all significant contributors have signed the FSF
>>>>> copyright assignment (CA), but from what I see you seem to be the only one
>>>>> that would qualify as such (more than 15 lines of substantial code is
>>>>> the way this is usually approximated).
>>>>> 
>>>>> Have you already signed the CA?  If not, send an email to
>>>>> emacs-devel@gnu.org to request the form.
>>>>> 
>>>>>> 2 ноября 2023 г. 11:23:04 UTC, Philip Kaludercic <philipk@posteo.net> пишет:
>>>>>>> 
>>>>>>> Hi, I was looking into proposing the inclusion of Ellama to NonGNU ELPA
>>>>>>> (or ideally GNU ELPA if you are OK with it), but I first wanted to send
>>>>>>> you a few comments on the code:
>>>>>>> 
>> 
> 
> -- 
> Philip Kaludercic


[-- Attachment #2: Type: text/html, Size: 31373 bytes --]

Re: Ellama comments

[Philip Kaludercic]

Sergey Kostyaev <sskostyaev@gmail.com> writes:

> .elpaignore added, thank you.

OK, as there haven't been any comments I have added the package to GNU
ELPA.