From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sergey Kostyaev Newsgroups: gmane.emacs.devel Subject: Re: Ellama comments Date: Sun, 17 Dec 2023 00:05:38 +0700 Message-ID: <8992E1EE-F6BE-4532-8387-28EA22A1F0F1@gmail.com> References: <87sf5oqu07.fsf@posteo.net> <87o7gcqd96.fsf@posteo.net> <6B0DECA2-8E81-495E-99AC-A9F81B43C05E@gmail.com> <874jglnibb.fsf@posteo.net> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.300.61.1.2\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6050"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 16 19:56:00 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEZpP-0001Lp-HG for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Dec 2023 19:55:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEZon-0006IG-DM; Sat, 16 Dec 2023 13:55:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEY6u-0007CH-3v for emacs-devel@gnu.org; Sat, 16 Dec 2023 12:05:56 -0500 Original-Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEY6s-00026y-5T for emacs-devel@gnu.org; Sat, 16 Dec 2023 12:05:55 -0500 Original-Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-50e297d0692so451651e87.1 for ; Sat, 16 Dec 2023 09:05:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702746351; x=1703351151; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MO2J/xASFR56+H6VYlE59n4ovLbuRWu4Wgruv4KgTW8=; b=YUFKLdbKOijI3cibs5gdpw8oHkdzTM3LKA68F+SVSyJLNeG5m2NadcywGP8NldokOs SadqIbWyqvt3c918hiFIMCCb6qWHy/dV3FvLlyYOGWREcBtNvdQmkbmsX42VG6dKsRLm otSuqIP+wJhfbf2srQ9b0vKjZ62w4b1PQNhnJBe7pItCW3E3L655kRPbHxTfqobZJFfi kbsX2mdaCbeaW63R4ewW/d3jFrJtoe7NwTLRsCuSXqhRyFQ+8p8SQn1CIGhoUOVj7pBB YX8MnrKQJcsTAb1EWjKLwQV4ttih7MdzbcthlliL0l5SKEkNnsCNRJehIU/RIPXzda97 G0Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702746351; x=1703351151; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MO2J/xASFR56+H6VYlE59n4ovLbuRWu4Wgruv4KgTW8=; b=YxFM9bw7dsIP3ACZmDGLMiYpMnRNc5ZtAIfWh7KNJcRvHV5VnEVRgbvmg4IIvY/0qF 5u0OU21ldd69PStY4bKEoI74zK8eqO0cGTEN0RGQoWjfqMSv4YI6DeBXhRSGj+7DUT3N dyOKoxjeBVTKBfdYSbwbp1kzvW+8OEHJS81hIMF8ts0/Eex7oZbjdUzSS6sium3ToRKu o4/AW0nWKkQWjZtUne0d7Ua3cm0RvVZFkniQZQIGmcZsJHAPVxPtqWGmuMhWCVEHscyc avKTJ1XGwe/aUo1aWXPXs9BhARHPZIcCM6FjvGF8ZiUOwiRqUUh92mv1mEa3tGWcDeM/ F08g== X-Gm-Message-State: AOJu0Yz9H7c+Bnfz00gjaloLNHdl/H1hbRngrthu467KgfGrGR1DA4W4 BlJ9tT93hp7Vb3lYtr0y8X67rgo6sbU= X-Google-Smtp-Source: AGHT+IHFEGVF/YsO61ugYAJNpL73tnBz1wVmyiujJ2b4G6sKQYI5az9hAYiWOjihDKs4KIymeJKW5A== X-Received: by 2002:ac2:5588:0:b0:50e:2a36:3a66 with SMTP id v8-20020ac25588000000b0050e2a363a66mr550167lfg.8.1702746351068; Sat, 16 Dec 2023 09:05:51 -0800 (PST) Original-Received: from smtpclient.apple ([90.189.160.165]) by smtp.gmail.com with ESMTPSA id b15-20020a056512024f00b0050bf015e3c9sm2427987lfo.141.2023.12.16.09.05.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Dec 2023 09:05:50 -0800 (PST) In-Reply-To: <874jglnibb.fsf@posteo.net> X-Mailer: Apple Mail (2.3774.300.61.1.2) Received-SPF: pass client-ip=2a00:1450:4864:20::12e; envelope-from=sskostyaev@gmail.com; helo=mail-lf1-x12e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 16 Dec 2023 13:55:17 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313878 Archived-At: Done. > 14 =D0=B4=D0=B5=D0=BA. 2023=E2=80=AF=D0=B3., =D0=B2 18:18, Philip = Kaludercic =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB= (=D0=B0): >=20 > The development mailing list got dropped, I've added it again. >=20 > Sergey Kostyaev writes: >=20 >> Today I finally got signed CA. What=E2=80=99s my next steps to move = ellama to GNU Elpa? >=20 > The first thing that you'll need to do is to update the copyright > string, and replace it with >=20 > ;; Copyright (C) 2023 Free Software Foundation, Inc. >=20 > and bump the version header. >=20 > Unless we find any further issues, I can just add the package to > elpa.git and that is that. >=20 >> I have fixed most of your comments and fix customization group >> soon. Spinner instead of progress-reporter because it was = contribution >> from other person. And I like it - it has high level api. And it=E2=80=99= s >> informative enough. >=20 > OK, if you say so, it just seems like an unnecessary dependency to me, > that might also be a soft dependency. >=20 >> Best Regards, >> Sergei Kostiaev >>=20 >>> 3 =D0=BD=D0=BE=D1=8F=D0=B1. 2023=E2=80=AF=D0=B3., =D0=B2 00:24, = Philip Kaludercic =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0= =D0=BB(=D0=B0): >>>=20 >>> Sergey Kostyaev writes: >>>=20 >>>> Hi, Philip. I'm honored. It's OK for me in general. I need to check = my >>>> job contract about signature for GNU Elpa. And I'm in Russia now, = can >>>> this be a problem? I need some time to investigate your comments. I >>>> will reply more specifically a few days later. >>>=20 >>> I don't expect that there should be an issue wrt to Russia, but I = cannot >>> say for sure. >>>=20 >>>> Best regards, >>>> Sergey Kostyaev=20 >>>>=20 >>>> 2 =D0=BD=D0=BE=D1=8F=D0=B1=D1=80=D1=8F 2023 =D0=B3. 11:23:04 UTC, = Philip Kaludercic =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>>>=20 >>>>> Hi, I was looking into proposing the inclusion of Ellama to NonGNU = ELPA >>>>> (or ideally GNU ELPA if you are OK with it), but I first wanted to = send >>>>> you a few comments on the code: >>>>>=20 >>>=20 >>> Sergey Kostyaev writes: >>>=20 >>>> About job contract all fine. What should I do with code by other >>>> contributors to move project to GNU Elpa? Are there any cheatsheets >>>> about it? About code comments I will reply later. >>>=20 >>> It is necessary that all significant contributors have signed the = FSF >>> copyright assignment (CA), but from what I see you seem to be the = only one >>> that would qualify as such (more than 15 lines of substantial code = is >>> the way this is usually approximated). >>>=20 >>> Have you already signed the CA? If not, send an email to >>> emacs-devel@gnu.org to request the form. >>>=20 >>>> 2 =D0=BD=D0=BE=D1=8F=D0=B1=D1=80=D1=8F 2023 =D0=B3. 11:23:04 UTC, = Philip Kaludercic =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>>>=20 >>>>> Hi, I was looking into proposing the inclusion of Ellama to NonGNU = ELPA >>>>> (or ideally GNU ELPA if you are OK with it), but I first wanted to = send >>>>> you a few comments on the code: >>>>>=20