From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Ellama comments Date: Sun, 17 Dec 2023 12:06:21 +0000 Message-ID: <87ttohkp8i.fsf@posteo.net> References: <87sf5oqu07.fsf@posteo.net> <87o7gcqd96.fsf@posteo.net> <6B0DECA2-8E81-495E-99AC-A9F81B43C05E@gmail.com> <874jglnibb.fsf@posteo.net> <8992E1EE-F6BE-4532-8387-28EA22A1F0F1@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25671"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Sergey Kostyaev Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 17 13:06:42 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEpur-0006TT-Ga for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Dec 2023 13:06:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEpue-0002N2-RF; Sun, 17 Dec 2023 07:06:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEpuc-0002Ms-Dk for emacs-devel@gnu.org; Sun, 17 Dec 2023 07:06:26 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEpuZ-0004ty-Uo for emacs-devel@gnu.org; Sun, 17 Dec 2023 07:06:26 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id ECFE2240027 for ; Sun, 17 Dec 2023 13:06:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1702814782; bh=uOYpwX0oX3XKMlMA1BC8U3G3CQdS2szUOHKLhPRGS14=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=VO6CUgkcgy/lZ3GsR4l5+wVwy6iMklaXTXHmAteJguBTxlmrBiYKDM8ioNGCj0HVW vN+4UuovD8tqpeLPjIhHfqaZCcpvVuo01DzBh/LwvxTRJpMdv82hmHu0jBtX635AWH yqmf7u+5bZee8hwZRUw7GvDWEEt+VVgji5wFDYb0D6BtlMrH4sgaMAj9C0V4Ma8US+ c+CGq+jHzPXyEcGmApX4ijDi6dKZ/+Qy5chtIfVpEU6gUWyrAwgs69IDHcO5Hjyz6A 2j+acG0J/P/CRQOyPkcHurcbr5Js2jl5IPNe/JU1S/1vGDt6awZ7QzSVWzHlK3ppRZ NxdnvsNHIrg5Q== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4StMB53Tgqz6txS; Sun, 17 Dec 2023 13:06:21 +0100 (CET) In-Reply-To: <8992E1EE-F6BE-4532-8387-28EA22A1F0F1@gmail.com> (Sergey Kostyaev's message of "Sun, 17 Dec 2023 00:05:38 +0700") X-Hashcash: 1:20:231217:sskostyaev@gmail.com::nF6Vwz8IGkKn/+yB:8FCK X-Hashcash: 1:20:231217:emacs-devel@gnu.org::6MlrSqzdUaSXqfk4:ADEc Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313921 Archived-At: --=-=-= Content-Type: text/plain Sergey Kostyaev writes: > Done. OK, the package builds now. --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/elpa-packages b/elpa-packages index 07f9e2373e..8695a87faf 100644 --- a/elpa-packages +++ b/elpa-packages @@ -258,6 +258,7 @@ ;;(eldoc-eval :url "https://github.com/thierryvolpiatto/eldoc-eval.git") (electric-spacing :url nil) (elisp-benchmarks :url nil) + (ellama :url "https://github.com/s-kostyaev/ellama") (emacs-gc-stats :url "https://git.sr.ht/~yantar92/emacs-gc-stats" :ignored-files ("COPYING")) ;; FIXME: Work in progress. The copyright paperwork is ready. --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I would also recommend adding an .elpaignore, with these lines: --8<---------------cut here---------------start------------->8--- .github imgs --8<---------------cut here---------------end--------------->8--- To avoid packaging them in the release tarball. I'll wait a bit to see if there are any comments, and then publish the package. >> 14 =D0=B4=D0=B5=D0=BA. 2023=E2=80=AF=D0=B3., =D0=B2 18:18, Philip Kalude= rcic =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0= ): >>=20 >> The development mailing list got dropped, I've added it again. >>=20 >> Sergey Kostyaev writes: >>=20 >>> Today I finally got signed CA. What=E2=80=99s my next steps to move ell= ama to GNU Elpa? >>=20 >> The first thing that you'll need to do is to update the copyright >> string, and replace it with >>=20 >> ;; Copyright (C) 2023 Free Software Foundation, Inc. >>=20 >> and bump the version header. >>=20 >> Unless we find any further issues, I can just add the package to >> elpa.git and that is that. >>=20 >>> I have fixed most of your comments and fix customization group >>> soon. Spinner instead of progress-reporter because it was contribution >>> from other person. And I like it - it has high level api. And it=E2=80= =99s >>> informative enough. >>=20 >> OK, if you say so, it just seems like an unnecessary dependency to me, >> that might also be a soft dependency. >>=20 >>> Best Regards, >>> Sergei Kostiaev >>>=20 >>>> 3 =D0=BD=D0=BE=D1=8F=D0=B1. 2023=E2=80=AF=D0=B3., =D0=B2 00:24, Philip= Kaludercic =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB= (=D0=B0): >>>>=20 >>>> Sergey Kostyaev writes: >>>>=20 >>>>> Hi, Philip. I'm honored. It's OK for me in general. I need to check my >>>>> job contract about signature for GNU Elpa. And I'm in Russia now, can >>>>> this be a problem? I need some time to investigate your comments. I >>>>> will reply more specifically a few days later. >>>>=20 >>>> I don't expect that there should be an issue wrt to Russia, but I cann= ot >>>> say for sure. >>>>=20 >>>>> Best regards, >>>>> Sergey Kostyaev=20 >>>>>=20 >>>>> 2 =D0=BD=D0=BE=D1=8F=D0=B1=D1=80=D1=8F 2023 =D0=B3. 11:23:04 UTC, Phi= lip Kaludercic =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>>>>=20 >>>>>> Hi, I was looking into proposing the inclusion of Ellama to NonGNU E= LPA >>>>>> (or ideally GNU ELPA if you are OK with it), but I first wanted to s= end >>>>>> you a few comments on the code: >>>>>>=20 >>>>=20 >>>> Sergey Kostyaev writes: >>>>=20 >>>>> About job contract all fine. What should I do with code by other >>>>> contributors to move project to GNU Elpa? Are there any cheatsheets >>>>> about it? About code comments I will reply later. >>>>=20 >>>> It is necessary that all significant contributors have signed the FSF >>>> copyright assignment (CA), but from what I see you seem to be the only= one >>>> that would qualify as such (more than 15 lines of substantial code is >>>> the way this is usually approximated). >>>>=20 >>>> Have you already signed the CA? If not, send an email to >>>> emacs-devel@gnu.org to request the form. >>>>=20 >>>>> 2 =D0=BD=D0=BE=D1=8F=D0=B1=D1=80=D1=8F 2023 =D0=B3. 11:23:04 UTC, Phi= lip Kaludercic =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>>>>=20 >>>>>> Hi, I was looking into proposing the inclusion of Ellama to NonGNU E= LPA >>>>>> (or ideally GNU ELPA if you are OK with it), but I first wanted to s= end >>>>>> you a few comments on the code: >>>>>>=20 > --=20 Philip Kaludercic --=-=-=--