From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sergey Kostyaev Newsgroups: gmane.emacs.devel Subject: Re: Ellama comments Date: Sun, 17 Dec 2023 23:56:42 +0700 Message-ID: <135F96FD-A05A-4624-94E3-37D5EA31E8F5@gmail.com> References: <87sf5oqu07.fsf@posteo.net> <87o7gcqd96.fsf@posteo.net> <6B0DECA2-8E81-495E-99AC-A9F81B43C05E@gmail.com> <874jglnibb.fsf@posteo.net> <8992E1EE-F6BE-4532-8387-28EA22A1F0F1@gmail.com> <87ttohkp8i.fsf@posteo.net> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.300.61.1.2\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_36CB3C1F-80EE-486E-8671-D13D0DFFCF9F" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31042"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 17 18:13:40 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEuhw-0007sD-JL for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Dec 2023 18:13:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEuhi-0001Av-21; Sun, 17 Dec 2023 12:13:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEuRp-0005Db-UC for emacs-devel@gnu.org; Sun, 17 Dec 2023 11:57:01 -0500 Original-Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEuRn-0000SQ-Eg for emacs-devel@gnu.org; Sun, 17 Dec 2023 11:57:01 -0500 Original-Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-50e37febd01so231893e87.0 for ; Sun, 17 Dec 2023 08:56:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702832216; x=1703437016; darn=gnu.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=+NTUTyl16c5DGuoNfL5/YXgI6peH2nDxL1T49S3hRvY=; b=JqNs81uawWFW78ORl0rdn20ZRujjdE0WUkkusZRFgZo4zKzTOiLE/sTWuGtQmjkd/w FjxcMFKaz+wxa/OB+xBBrqmunY2VRtSOlk4sx7aPY1opkfIiRJWuhWvmuBvTfXiwwkIE KEdV9IUazULvvrKlGlHSypXW94Slyogn61RYR+ObTimTaYEjtprcnksgXvTWU+yCcq7E dtDjt50gVv1wWCQp5ie9krbCk+Brpv3JO4TMPP9JadaDzqaSOQJB0F4fA0897xPq1aQt rHCFcqVwkd8U7XGjRq4bg/oJcbqcyXQkL5UaEnIZhduo8+YOuL8+OA5O2uhWHE4c07is 05Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702832216; x=1703437016; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+NTUTyl16c5DGuoNfL5/YXgI6peH2nDxL1T49S3hRvY=; b=O4EXiJPou+o12xjeqcvHJP3lE0kcRr0D4vnqCInJOPGvJQq9/1/CVERp20Jzic9ezo ljP/m5Wj3UNutLqd9cuearOO1k/UB+3uYKREx0/7eBEVZJ60hZzBxKHGdcinMbGqOEfc lXO2j0PrVTtHLgzv3B0Ax1KB84207FG4X9UvHDY5Nzu+9nY50bT1qVJzEj5TDEZFubwi 6M3lzmZlWWM8MOtixOr9Zs40CQhklRMT9pTSMPO2S+1JriTc5141zJRZYk2h4QCubVVs p/JeZZR2Lygc8hu6SzdXv5ikr2KT6vrRb/Mfr9fnUox+h6wqd7dgCjPmOkEiWSsuJgms 4ZuQ== X-Gm-Message-State: AOJu0Yz/d8yyZAAfzxqLYGq3JClsgMrmp8+f8doqfckcDKdCtloYKVIa M+Dl/FeRQRPl8K48WH6nb30/GcwiA9w= X-Google-Smtp-Source: AGHT+IFVaMRMueHIbE3fXge0+CGrvK1pLc1lksAqcEq9P2lXShE9UsNkURFxBTqHJEql7/vwGvwRtw== X-Received: by 2002:a05:6512:6c9:b0:50b:d341:4f6c with SMTP id u9-20020a05651206c900b0050bd3414f6cmr10700430lff.6.1702832215267; Sun, 17 Dec 2023 08:56:55 -0800 (PST) Original-Received: from smtpclient.apple ([90.189.160.165]) by smtp.gmail.com with ESMTPSA id o9-20020a056512230900b0050e0d35e41dsm1318890lfu.266.2023.12.17.08.56.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Dec 2023 08:56:54 -0800 (PST) In-Reply-To: <87ttohkp8i.fsf@posteo.net> X-Mailer: Apple Mail (2.3774.300.61.1.2) Received-SPF: pass client-ip=2a00:1450:4864:20::135; envelope-from=sskostyaev@gmail.com; helo=mail-lf1-x135.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 17 Dec 2023 12:13:21 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313933 Archived-At: --Apple-Mail=_36CB3C1F-80EE-486E-8671-D13D0DFFCF9F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 .elpaignore added, thank you. > 17 =D0=B4=D0=B5=D0=BA. 2023=E2=80=AF=D0=B3., =D0=B2 19:06, Philip = Kaludercic =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB= (=D0=B0): >=20 > Sergey Kostyaev > = writes: >=20 >> Done. >=20 > OK, the package builds now. >=20 > diff --git a/elpa-packages b/elpa-packages > index 07f9e2373e..8695a87faf 100644 > --- a/elpa-packages > +++ b/elpa-packages > @@ -258,6 +258,7 @@ > ;;(eldoc-eval :url = "https://github.com/thierryvolpiatto/eldoc-eval.git") > (electric-spacing :url nil) > (elisp-benchmarks :url nil) > + (ellama :url "https://github.com/s-kostyaev/ellama") > (emacs-gc-stats :url = "https://git.sr.ht/~yantar92/emacs-gc-stats" > :ignored-files ("COPYING")) > ;; FIXME: Work in progress. The copyright paperwork is ready. >=20 >=20 > I would also recommend adding an .elpaignore, with these lines: >=20 > --8<---------------cut here---------------start------------->8--- > .github > imgs > --8<---------------cut here---------------end--------------->8--- >=20 > To avoid packaging them in the release tarball. >=20 > I'll wait a bit to see if there are any comments, and then publish the > package. >=20 >>> 14 =D0=B4=D0=B5=D0=BA. 2023=E2=80=AF=D0=B3., =D0=B2 18:18, Philip = Kaludercic =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB= (=D0=B0): >>>=20 >>> The development mailing list got dropped, I've added it again. >>>=20 >>> Sergey Kostyaev writes: >>>=20 >>>> Today I finally got signed CA. What=E2=80=99s my next steps to move = ellama to GNU Elpa? >>>=20 >>> The first thing that you'll need to do is to update the copyright >>> string, and replace it with >>>=20 >>> ;; Copyright (C) 2023 Free Software Foundation, Inc. >>>=20 >>> and bump the version header. >>>=20 >>> Unless we find any further issues, I can just add the package to >>> elpa.git and that is that. >>>=20 >>>> I have fixed most of your comments and fix customization group >>>> soon. Spinner instead of progress-reporter because it was = contribution >>>> from other person. And I like it - it has high level api. And = it=E2=80=99s >>>> informative enough. >>>=20 >>> OK, if you say so, it just seems like an unnecessary dependency to = me, >>> that might also be a soft dependency. >>>=20 >>>> Best Regards, >>>> Sergei Kostiaev >>>>=20 >>>>> 3 =D0=BD=D0=BE=D1=8F=D0=B1. 2023=E2=80=AF=D0=B3., =D0=B2 00:24, = Philip Kaludercic =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0= =D0=BB(=D0=B0): >>>>>=20 >>>>> Sergey Kostyaev writes: >>>>>=20 >>>>>> Hi, Philip. I'm honored. It's OK for me in general. I need to = check my >>>>>> job contract about signature for GNU Elpa. And I'm in Russia now, = can >>>>>> this be a problem? I need some time to investigate your comments. = I >>>>>> will reply more specifically a few days later. >>>>>=20 >>>>> I don't expect that there should be an issue wrt to Russia, but I = cannot >>>>> say for sure. >>>>>=20 >>>>>> Best regards, >>>>>> Sergey Kostyaev=20 >>>>>>=20 >>>>>> 2 =D0=BD=D0=BE=D1=8F=D0=B1=D1=80=D1=8F 2023 =D0=B3. 11:23:04 UTC, = Philip Kaludercic =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>>>>>=20 >>>>>>> Hi, I was looking into proposing the inclusion of Ellama to = NonGNU ELPA >>>>>>> (or ideally GNU ELPA if you are OK with it), but I first wanted = to send >>>>>>> you a few comments on the code: >>>>>>>=20 >>>>>=20 >>>>> Sergey Kostyaev writes: >>>>>=20 >>>>>> About job contract all fine. What should I do with code by other >>>>>> contributors to move project to GNU Elpa? Are there any = cheatsheets >>>>>> about it? About code comments I will reply later. >>>>>=20 >>>>> It is necessary that all significant contributors have signed the = FSF >>>>> copyright assignment (CA), but from what I see you seem to be the = only one >>>>> that would qualify as such (more than 15 lines of substantial code = is >>>>> the way this is usually approximated). >>>>>=20 >>>>> Have you already signed the CA? If not, send an email to >>>>> emacs-devel@gnu.org to request the form. >>>>>=20 >>>>>> 2 =D0=BD=D0=BE=D1=8F=D0=B1=D1=80=D1=8F 2023 =D0=B3. 11:23:04 UTC, = Philip Kaludercic =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>>>>>=20 >>>>>>> Hi, I was looking into proposing the inclusion of Ellama to = NonGNU ELPA >>>>>>> (or ideally GNU ELPA if you are OK with it), but I first wanted = to send >>>>>>> you a few comments on the code: >>>>>>>=20 >>=20 >=20 > --=20 > Philip Kaludercic --Apple-Mail=_36CB3C1F-80EE-486E-8671-D13D0DFFCF9F Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 .elpaignore = added, thank you.

17 =D0=B4=D0=B5=D0=BA. 2023=E2=80=AF=D0=B3., =D0=B2 = 19:06, Philip Kaludercic <philipk@posteo.net> = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0):

Sergey Kostyaev <sskostyaev@gmail.com> = writes:

Done.

OK, the = package builds now.

diff = --git a/elpa-packages b/elpa-packages
index = 07f9e2373e..8695a87faf 100644
--- = a/elpa-packages
+++ = b/elpa-packages
@@ = -258,6 +258,7 @@
 ;;(eldoc-eval = :url "https://github.com/thierryvolpiatto/eldoc-eval.git")
 (electric-spacing = :url nil)
 (elisp-benchmarks :url nil)
+ (ellama =             &n= bsp;  :url "https://github.com/s-kostyaev/ellama")
 (emacs-gc-stats = :url "https://git.sr.ht/~yantar92/emacs-gc-stats"
  :ignored-files ("COPYING"))
 ;; FIXME: Work in progress.  The = copyright paperwork is ready.


I would = also recommend adding an .elpaignore, with these lines:

--8<---------------cut = here---------------start------------->8---
.github
imgs
--8<---------------cut = here---------------end--------------->8---

To avoid packaging them in the release = tarball.

I'll wait a bit to see = if there are any comments, and then publish the
package.

14 =D0=B4=D0=B5=D0=BA. = 2023=E2=80=AF=D0=B3., =D0=B2 18:18, Philip Kaludercic = <philipk@posteo.net> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0= ):

The development mailing list got dropped, I've added it = again.

Sergey Kostyaev <sskostyaev@gmail.com> = writes:

Today I finally got signed CA. = What=E2=80=99s my next steps to move ellama to GNU = Elpa?

The first thing that you'll need to do is to = update the copyright
string, and replace it with

;; Copyright = (C) 2023  Free Software Foundation, Inc.

and bump the = version header.

Unless we find any further issues, I can just add = the package to
elpa.git and that is that.

I have fixed most of your comments and fix customization = group
soon. Spinner instead of progress-reporter because it was = contribution
from other person. And I like it - it has high level = api. And it=E2=80=99s
informative enough.

OK, if = you say so, it just seems like an unnecessary dependency to me,
that = might also be a soft dependency.

Best = Regards,
Sergei Kostiaev

3 =D0=BD=D0=BE= =D1=8F=D0=B1. 2023=E2=80=AF=D0=B3., =D0=B2 00:24, Philip Kaludercic = <philipk@posteo.net> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0= ):

Sergey Kostyaev <sskostyaev@gmail.com> = writes:

Hi, Philip. I'm honored. It's = OK for me in general. I need to check my
job contract about signature = for GNU Elpa. And I'm in Russia now, can
this be a problem? I need = some time to investigate your comments. I
will reply more = specifically a few days later.

I don't expect that = there should be an issue wrt to Russia, but I cannot
say for = sure.

Best regards,
Sergey = Kostyaev 

2 = =D0=BD=D0=BE=D1=8F=D0=B1=D1=80=D1=8F 2023 =D0=B3. 11:23:04 UTC, Philip = Kaludercic <philipk@posteo.net> =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
<= blockquote type=3D"cite">
Hi, I was looking into proposing the = inclusion of Ellama to NonGNU ELPA
(or ideally GNU ELPA if you are OK = with it), but I first wanted to send
you a few comments on the = code:


Sergey Kostyaev = <sskostyaev@gmail.com> writes:

About job contract all fine. What should I do with code by = other
contributors to move project to GNU Elpa? Are there any = cheatsheets
about it? About code comments I will reply = later.

It is necessary that all significant = contributors have signed the FSF
copyright assignment (CA), but from = what I see you seem to be the only one
that would qualify as such = (more than 15 lines of substantial code is
the way this is usually = approximated).

Have you already signed the CA?  If not, send = an email to
emacs-devel@gnu.org to request the = form.

2 =D0=BD=D0=BE=D1=8F=D0=B1=D1=80=D1= =8F 2023 =D0=B3. 11:23:04 UTC, Philip Kaludercic = <philipk@posteo.net> =D0=BF=D0=B8=D1=88=D0=B5=D1=82:

Hi, I was looking into proposing the inclusion of = Ellama to NonGNU ELPA
(or ideally GNU ELPA if you are OK with it), = but I first wanted to send
you a few comments on the = code:



-- 
Philip = Kaludercic

= --Apple-Mail=_36CB3C1F-80EE-486E-8671-D13D0DFFCF9F--