unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Alfred M. Szmidt" <ams@gnu.org>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: vc-modify-change-comment for "modern" backend fix
Date: Wed, 18 May 2022 14:29:02 +0300	[thread overview]
Message-ID: <83pmkbf5a9.fsf@gnu.org> (raw)
In-Reply-To: <E1nrDGi-0006Q7-Fy@fencepost.gnu.org> (ams@gnu.org)

> From: "Alfred M. Szmidt" <ams@gnu.org>
> Cc: emacs-devel@gnu.org
> Date: Wed, 18 May 2022 02:34:48 -0400
> 
> What about something like this, I've tested it briefly with a
> vc-fossil-get-log-entry, and with RCS and it seems to behave as it
> does previously -- though slightly confused by what it does for RCS
> (it inserts the header, but not the commit?).

Maybe it's me, but it looks a bit inelegant: log-view calls the VC
backend, which then turns around and calls back into log-view? a VC
method that isn't implemented in any backend, but instead does TRT for
each backend "by hand"?  Can't we come up with something cleaner, even
if that requires to add a new function?

Thanks.



  reply	other threads:[~2022-05-18 11:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17  7:04 vc-modify-change-comment for "modern" backend fix Alfred M. Szmidt
2022-05-17  8:36 ` Alfred M. Szmidt
2022-05-17 12:02   ` Eli Zaretskii
2022-05-17 18:31   ` Stefan Monnier
2022-05-17 19:10     ` Alfred M. Szmidt
2022-05-17 23:20       ` Dmitry Gutov
2022-05-18  6:34     ` Alfred M. Szmidt
2022-05-18 11:29       ` Eli Zaretskii [this message]
2022-05-19  6:11         ` Alfred M. Szmidt
2022-05-19 14:47           ` Stefan Monnier
2022-05-19  0:05       ` Dmitry Gutov
2022-05-19  6:11         ` Alfred M. Szmidt
2022-05-19  9:25           ` Dmitry Gutov
2022-05-19  9:58             ` Alfred M. Szmidt
2022-05-19 10:24               ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pmkbf5a9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=ams@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).