From: Dmitry Gutov <dgutov@yandex.ru>
To: "Alfred M. Szmidt" <ams@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: vc-modify-change-comment for "modern" backend fix
Date: Wed, 18 May 2022 02:20:59 +0300 [thread overview]
Message-ID: <45226141-ef02-656b-e99a-2ca53c91d2f2@yandex.ru> (raw)
In-Reply-To: <E1nr2a0-0006Ly-CO@fencepost.gnu.org>
On 17.05.2022 22:10, Alfred M. Szmidt wrote:
> Thanks Eli, and Stefan.
>
> Note that maybe you don't want "just the commit message text" because
> you may want to preserve extra info such as the `Author:`.
>
> There is I think a very deep hole -- creation time, author, committer,
> branch colour, etc, etc, etc. As it is now, modify-change-comment is
> quite specific in what it wants to do.
The command could return the contents of the log-edit buffer, including
the recognized headers, which currently include, for Git,
Author, Date, No-Verify and Sign-Off.
There's also "Amend", and you may or may not reuse it to implement this
functionality. Depending on whether you intend to support editing of
older commits (not just the tip one).
next prev parent reply other threads:[~2022-05-17 23:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 7:04 vc-modify-change-comment for "modern" backend fix Alfred M. Szmidt
2022-05-17 8:36 ` Alfred M. Szmidt
2022-05-17 12:02 ` Eli Zaretskii
2022-05-17 18:31 ` Stefan Monnier
2022-05-17 19:10 ` Alfred M. Szmidt
2022-05-17 23:20 ` Dmitry Gutov [this message]
2022-05-18 6:34 ` Alfred M. Szmidt
2022-05-18 11:29 ` Eli Zaretskii
2022-05-19 6:11 ` Alfred M. Szmidt
2022-05-19 14:47 ` Stefan Monnier
2022-05-19 0:05 ` Dmitry Gutov
2022-05-19 6:11 ` Alfred M. Szmidt
2022-05-19 9:25 ` Dmitry Gutov
2022-05-19 9:58 ` Alfred M. Szmidt
2022-05-19 10:24 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45226141-ef02-656b-e99a-2ca53c91d2f2@yandex.ru \
--to=dgutov@yandex.ru \
--cc=ams@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).