From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Alfred M. Szmidt" <ams@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: vc-modify-change-comment for "modern" backend fix
Date: Thu, 19 May 2022 10:47:01 -0400 [thread overview]
Message-ID: <jwv5ym1fupz.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1nrZNS-0001w8-LJ@fencepost.gnu.org> (Alfred M. Szmidt's message of "Thu, 19 May 2022 02:11:14 -0400")
> I think the modify-change-comment functionality hasn't seen much use,
> and still quite confused how it is intended to work. E.g., in RCS, I
> have this as the latest commit (and in log view mode):
>
> ----------------------------
> revision 1.3
> date: 2022/05/18 06:32:36; author: ams; state: Exp; lines: +2 -1
> Summary: this is a test message
> ----------------------------
>
> At the beginning of the buffer, log-view-modify-change-comment, then
> you get a new buffer with the following:
>
> revision 1.3
> date: 2022/05/18 06:32:36; author: ams; state: Exp; lines: +2 -1
That's a bug. It should contain "Summary: this is a test message".
FWIW I implemented this functionality originally for CVS and I can't
remember ever testing it on another VCS, so I'm not surprised it doesn't
work right for other VCS. I also remember having trouble using it last
time I needed it in CVS (which was quite some years ago), so it might
also be broken for CVS. :-(
Stefan
next prev parent reply other threads:[~2022-05-19 14:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 7:04 vc-modify-change-comment for "modern" backend fix Alfred M. Szmidt
2022-05-17 8:36 ` Alfred M. Szmidt
2022-05-17 12:02 ` Eli Zaretskii
2022-05-17 18:31 ` Stefan Monnier
2022-05-17 19:10 ` Alfred M. Szmidt
2022-05-17 23:20 ` Dmitry Gutov
2022-05-18 6:34 ` Alfred M. Szmidt
2022-05-18 11:29 ` Eli Zaretskii
2022-05-19 6:11 ` Alfred M. Szmidt
2022-05-19 14:47 ` Stefan Monnier [this message]
2022-05-19 0:05 ` Dmitry Gutov
2022-05-19 6:11 ` Alfred M. Szmidt
2022-05-19 9:25 ` Dmitry Gutov
2022-05-19 9:58 ` Alfred M. Szmidt
2022-05-19 10:24 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv5ym1fupz.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=ams@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).