From: "Alfred M. Szmidt" <ams@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: vc-modify-change-comment for "modern" backend fix
Date: Thu, 19 May 2022 02:11:11 -0400 [thread overview]
Message-ID: <E1nrZNP-0001vp-OC@fencepost.gnu.org> (raw)
In-Reply-To: <9f1b5ce9-270a-2cb4-d958-f7545fd7d373@yandex.ru> (message from Dmitry Gutov on Thu, 19 May 2022 03:05:30 +0300)
On 18.05.2022 09:34, Alfred M. Szmidt wrote:
> + "Extract the commit message for the current file."
> + (vc-call-backend log-view-vc-backend
> + 'get-log-entry
> + (log-view-current-file)
> + (log-view-current-tag)))
Why not customize the extraction function only for backends that need it?
This does that, no? If you don't have get-log-entry, then things work
as previously.
The backend command could be called 'extract-comment'. Which is somewhat
different from "log entry" because the latter seems to include the
headers, in VC parlance.
And you haven't explained thus far your plan for implementing
'modify-change-comment' for e.g. Git.
I have no plans on implementing such functionality for git.
next prev parent reply other threads:[~2022-05-19 6:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 7:04 vc-modify-change-comment for "modern" backend fix Alfred M. Szmidt
2022-05-17 8:36 ` Alfred M. Szmidt
2022-05-17 12:02 ` Eli Zaretskii
2022-05-17 18:31 ` Stefan Monnier
2022-05-17 19:10 ` Alfred M. Szmidt
2022-05-17 23:20 ` Dmitry Gutov
2022-05-18 6:34 ` Alfred M. Szmidt
2022-05-18 11:29 ` Eli Zaretskii
2022-05-19 6:11 ` Alfred M. Szmidt
2022-05-19 14:47 ` Stefan Monnier
2022-05-19 0:05 ` Dmitry Gutov
2022-05-19 6:11 ` Alfred M. Szmidt [this message]
2022-05-19 9:25 ` Dmitry Gutov
2022-05-19 9:58 ` Alfred M. Szmidt
2022-05-19 10:24 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1nrZNP-0001vp-OC@fencepost.gnu.org \
--to=ams@gnu.org \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).