From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: vc-modify-change-comment for "modern" backend fix Date: Wed, 18 May 2022 14:29:02 +0300 Message-ID: <83pmkbf5a9.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35089"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: "Alfred M. Szmidt" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 18 13:33:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nrHwC-0008yD-0z for ged-emacs-devel@m.gmane-mx.org; Wed, 18 May 2022 13:33:56 +0200 Original-Received: from localhost ([::1]:42258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrHwA-0001g1-OJ for ged-emacs-devel@m.gmane-mx.org; Wed, 18 May 2022 07:33:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrHrl-0007GB-7G for emacs-devel@gnu.org; Wed, 18 May 2022 07:29:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55090) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrHrk-0003A5-HX; Wed, 18 May 2022 07:29:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=E4gl4evzp+fnPubaYt17M4FA4CtNv2beXa73i3waFYY=; b=NDIXEiBb0zWZ ulQQqC4XmwzqEMA6vF0HRY5h4ZxNbNw/w/5VPsaS/x+3MLXY9eiRBPSkVyMVq/ubxugYhbeJueweH mmopIRtFDc/7W6WIhbrZfYRAbDW3FswOx915ly+0eoe+/V+ekELe0EFfoKfhcexEkmpgFtSvpFjDO kWm+axnbhQo1beeJr2yEbvM9gz7itflvS3trvHynGsarR2jmkemezInItjFuW02qU1ZMR8FctzLEF rDWw0jvnrlospb1B2D+Ah5+6R5coPB6y1mGAoQklVqQJ7sINu8OhwpbKbST++wjRd8xB18k5EyowL AEu8DX8C6IjI/hIl5VSqYg==; Original-Received: from [87.69.77.57] (port=3187 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrHrZ-0002ql-FH; Wed, 18 May 2022 07:29:10 -0400 In-Reply-To: (ams@gnu.org) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289916 Archived-At: > From: "Alfred M. Szmidt" > Cc: emacs-devel@gnu.org > Date: Wed, 18 May 2022 02:34:48 -0400 > > What about something like this, I've tested it briefly with a > vc-fossil-get-log-entry, and with RCS and it seems to behave as it > does previously -- though slightly confused by what it does for RCS > (it inserts the header, but not the commit?). Maybe it's me, but it looks a bit inelegant: log-view calls the VC backend, which then turns around and calls back into log-view? a VC method that isn't implemented in any backend, but instead does TRT for each backend "by hand"? Can't we come up with something cleaner, even if that requires to add a new function? Thanks.