From: "Alfred M. Szmidt" <ams@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: vc-modify-change-comment for "modern" backend fix
Date: Thu, 19 May 2022 02:11:14 -0400 [thread overview]
Message-ID: <E1nrZNS-0001w8-LJ@fencepost.gnu.org> (raw)
In-Reply-To: <83pmkbf5a9.fsf@gnu.org> (message from Eli Zaretskii on Wed, 18 May 2022 14:29:02 +0300)
> What about something like this, I've tested it briefly with a
> vc-fossil-get-log-entry, and with RCS and it seems to behave as it
> does previously -- though slightly confused by what it does for RCS
> (it inserts the header, but not the commit?).
Maybe it's me, but it looks a bit inelegant: log-view calls the VC
backend, which then turns around and calls back into log-view? a VC
method that isn't implemented in any backend, but instead does TRT for
each backend "by hand"? Can't we come up with something cleaner, even
if that requires to add a new function?
It is a bit of a kludge, yes. If someone can come up with an idea how
this could look like, I can try implementing that. But I won't be
able to test this for SCSS, CVS, SVN or Hg which seem to support this
-- the current patch should still keep those working as previously
though which is probobly the only thing it has going for it...
I think the modify-change-comment functionality hasn't seen much use,
and still quite confused how it is intended to work. E.g., in RCS, I
have this as the latest commit (and in log view mode):
----------------------------
revision 1.3
date: 2022/05/18 06:32:36; author: ams; state: Exp; lines: +2 -1
Summary: this is a test message
----------------------------
At the beginning of the buffer, log-view-modify-change-comment, then
you get a new buffer with the following:
revision 1.3
date: 2022/05/18 06:32:36; author: ams; state: Exp; lines: +2 -1
Note the lack of the actual log message. And when you C-c C-c that
you get basically something that isn't very useful...
----------------------------
revision 1.3
date: 2022/05/18 06:32:36; author: ams; state: Exp; lines: +2 -1
revision 1.3
date: 2022/05/18 06:32:36; author: ams; state: Exp; lines: +2 -1
----------------------------
next prev parent reply other threads:[~2022-05-19 6:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 7:04 vc-modify-change-comment for "modern" backend fix Alfred M. Szmidt
2022-05-17 8:36 ` Alfred M. Szmidt
2022-05-17 12:02 ` Eli Zaretskii
2022-05-17 18:31 ` Stefan Monnier
2022-05-17 19:10 ` Alfred M. Szmidt
2022-05-17 23:20 ` Dmitry Gutov
2022-05-18 6:34 ` Alfred M. Szmidt
2022-05-18 11:29 ` Eli Zaretskii
2022-05-19 6:11 ` Alfred M. Szmidt [this message]
2022-05-19 14:47 ` Stefan Monnier
2022-05-19 0:05 ` Dmitry Gutov
2022-05-19 6:11 ` Alfred M. Szmidt
2022-05-19 9:25 ` Dmitry Gutov
2022-05-19 9:58 ` Alfred M. Szmidt
2022-05-19 10:24 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1nrZNS-0001w8-LJ@fencepost.gnu.org \
--to=ams@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).