unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Kevin Foley <kevin@kevinjfoley.me>
To: Stefan Kangas <stefan@marxist.se>, Lars Ingebrigtsen <larsi@gnus.org>
Cc: 44202@debbugs.gnu.org
Subject: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer
Date: Mon, 26 Oct 2020 18:05:03 -0400	[thread overview]
Message-ID: <m2mu08y774.fsf@Kevins-MBP.home.lan> (raw)
In-Reply-To: <CADwFkmmp7G1k-8rtEPoeyv-2ffG=ox-4erym20z-A4vUBjyx5g@mail.gmail.com>

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I am a bit worried about incompatibles by hoisting that code up to
> `revert-buffer'...

Fair point, that probably isn't a good approach.

> `help-mode' does bind `g' to `revert-buffer'?  So I think I don't quite
> understand what you're asking.

Never mind, I was mistaken about which function was bound.

Stefan Kangas <stefan@marxist.se> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> I've looked at some of the different usages of `revert-buffer-function',
>> and the help-functions one seems to be an outlier -- very few of the
>> non-file ones ask at all (I haven't found one yet, but I've only looked
>> at a handful).  Which makes me wonder why the *Help* one does?  I've
>> always found that pretty odd.  What's the use case for prompting the
>> user when the user hits `g' here?
>
> Thank you for looking into this more deeply.  I think not prompting
> here could work, unless there is some important reason not to.

I agree, I've never found this useful which was the inspiration for the
original patch.

So would the solution be to remove the prompt all together?  Or would it
the approach used in the patch to provide an option to control it
specifically for *Help*?

Kevin Foley






  reply	other threads:[~2020-10-26 22:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-24 20:25 bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer Kevin Foley
2020-10-24 23:40 ` Drew Adams
2020-10-25  0:01 ` Stefan Kangas
2020-10-25 13:39   ` Kevin Foley
2020-10-25 13:50     ` Lars Ingebrigtsen
2020-10-25 14:47       ` Kevin Foley
2020-10-25 16:50         ` Lars Ingebrigtsen
2020-10-25 18:42           ` Stefan Kangas
2020-10-25 20:08             ` Kevin Foley
2020-10-26 10:22               ` Lars Ingebrigtsen
2020-10-26 14:59                 ` Stefan Kangas
2020-10-26 22:05                   ` Kevin Foley [this message]
2020-10-27  7:27                     ` Lars Ingebrigtsen
2020-11-17 13:04                       ` Stefan Kangas
2020-11-24  5:26                         ` Lars Ingebrigtsen
2020-11-24 15:57                           ` Stefan Kangas
2020-11-25  7:01                             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2mu08y774.fsf@Kevins-MBP.home.lan \
    --to=kevin@kevinjfoley.me \
    --cc=44202@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).