From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Kevin Foley Newsgroups: gmane.emacs.bugs Subject: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer Date: Mon, 26 Oct 2020 18:05:03 -0400 Message-ID: References: <87lffu9zye.fsf@gnus.org> <87a6wa8d1w.fsf@gnus.org> <87sga1477z.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26960"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44202@debbugs.gnu.org To: Stefan Kangas , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 26 23:12:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXAj0-0006uJ-BQ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Oct 2020 23:12:22 +0100 Original-Received: from localhost ([::1]:60426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXAiy-0007wZ-Im for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Oct 2020 18:12:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXAct-0007oy-6t for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 18:06:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58496) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXAcs-0005hx-FM for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 18:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kXAcs-0007sG-79 for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 18:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kevin Foley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 22:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44202 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44202-submit@debbugs.gnu.org id=B44202.160374992330205 (code B ref 44202); Mon, 26 Oct 2020 22:06:02 +0000 Original-Received: (at 44202) by debbugs.gnu.org; 26 Oct 2020 22:05:23 +0000 Original-Received: from localhost ([127.0.0.1]:41809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXAcE-0007r7-R5 for submit@debbugs.gnu.org; Mon, 26 Oct 2020 18:05:23 -0400 Original-Received: from mout-p-101.mailbox.org ([80.241.56.151]:32556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXAcD-0007qn-1X for 44202@debbugs.gnu.org; Mon, 26 Oct 2020 18:05:21 -0400 Original-Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4CKpmV5bWczQkJg; Mon, 26 Oct 2020 23:05:14 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Original-Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de [80.241.56.117]) (amavisd-new, port 10030) with ESMTP id zIgk1OfHCc8S; Mon, 26 Oct 2020 23:05:07 +0100 (CET) In-Reply-To: X-Rspamd-Score: -5.65 / 15.00 / 15.00 X-Rspamd-Queue-Id: 5076B17DD X-Rspamd-UID: c1a0e6 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191679 Archived-At: Lars Ingebrigtsen writes: > I am a bit worried about incompatibles by hoisting that code up to > `revert-buffer'... Fair point, that probably isn't a good approach. > `help-mode' does bind `g' to `revert-buffer'? So I think I don't quite > understand what you're asking. Never mind, I was mistaken about which function was bound. Stefan Kangas writes: > Lars Ingebrigtsen writes: > >> I've looked at some of the different usages of `revert-buffer-function', >> and the help-functions one seems to be an outlier -- very few of the >> non-file ones ask at all (I haven't found one yet, but I've only looked >> at a handful). Which makes me wonder why the *Help* one does? I've >> always found that pretty odd. What's the use case for prompting the >> user when the user hits `g' here? > > Thank you for looking into this more deeply. I think not prompting > here could work, unless there is some important reason not to. I agree, I've never found this useful which was the inspiration for the original patch. So would the solution be to remove the prompt all together? Or would it the approach used in the patch to provide an option to control it specifically for *Help*? Kevin Foley