From: Drew Adams <drew.adams@oracle.com>
To: Kevin Foley <kevin@kevinjfoley.me>, 44202@debbugs.gnu.org
Subject: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer
Date: Sat, 24 Oct 2020 16:40:39 -0700 (PDT) [thread overview]
Message-ID: <9b8f80b0-34ec-4ab9-8546-0c1e51da5696@default> (raw)
In-Reply-To: <m2mu0bl6bv.fsf@Kevins-MBP.home.lan>
> +(defcustom help-mode-revert-buffer-noconfirm nil
> + "Indicates whether to prompt for confirmation when reverting a
> +help buffer."
A minor comment (and others may disagree with me).
I think the first line of the doc string should
say what a true value means, because the option
name does that.
Or at least the doc string should somehow make
clear which Boolean value means which behavior.
E.g.:
Non-nil means do not prompt for confirmation when reverting a help buffer.
If you just say "whether" there's no way to know
which value means what, except to guess from the
option name, in which case the doc string doesn't
add anything.
next prev parent reply other threads:[~2020-10-24 23:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 20:25 bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer Kevin Foley
2020-10-24 23:40 ` Drew Adams [this message]
2020-10-25 0:01 ` Stefan Kangas
2020-10-25 13:39 ` Kevin Foley
2020-10-25 13:50 ` Lars Ingebrigtsen
2020-10-25 14:47 ` Kevin Foley
2020-10-25 16:50 ` Lars Ingebrigtsen
2020-10-25 18:42 ` Stefan Kangas
2020-10-25 20:08 ` Kevin Foley
2020-10-26 10:22 ` Lars Ingebrigtsen
2020-10-26 14:59 ` Stefan Kangas
2020-10-26 22:05 ` Kevin Foley
2020-10-27 7:27 ` Lars Ingebrigtsen
2020-11-17 13:04 ` Stefan Kangas
2020-11-24 5:26 ` Lars Ingebrigtsen
2020-11-24 15:57 ` Stefan Kangas
2020-11-25 7:01 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b8f80b0-34ec-4ab9-8546-0c1e51da5696@default \
--to=drew.adams@oracle.com \
--cc=44202@debbugs.gnu.org \
--cc=kevin@kevinjfoley.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).