From: Kevin Foley <kevin@kevinjfoley.me>
To: Stefan Kangas <stefan@marxist.se>, Lars Ingebrigtsen <larsi@gnus.org>
Cc: 44202@debbugs.gnu.org
Subject: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer
Date: Sun, 25 Oct 2020 16:08:07 -0400 [thread overview]
Message-ID: <m2d016kr14.fsf@Kevins-MBP.home.lan> (raw)
In-Reply-To: <CADwFkmnLCbNNzhe+Fiiy-y+s1CfvrjFahYaZLJYR=oUtC+=U-Q@mail.gmail.com>
Stefan Kangas <stefan@marxist.se> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> But... I think it would be helpful if help-mode-revert-buffer (and
>> other similar functions) did heed that variable -- then there'd be one
>> simple way to control all this.
>
> Agreed. It would seem logical to just be able to say:
>
> (add-to-list 'revert-without-query "\\`\\*Help\\*\\'")
I also agree with this. I think this was how I originally tried to
solve this problem (it was a while ago) but it didn't seem supported.
>> Or even perhaps have revert-buffer look at that variable and do the
>> right thing instead of punting to revert-buffer--default.
>>
>> That is, it would look at file names for buffers visiting files, and
>> buffer names for other buffers.
>
> If we could get `revert-buffer' to handle this, it seems to me that it
> would be even better.
I could update `revert-buffer' to include the logic for IGNORE-AUTO and
NOCONFIRM that are used in `revert-buffer--default' with some additional
logic to handle buffers without associated files.
Should I leave this logic in `revert-buffer--default' as well or have it
only exist in `revert-buffer'?
I believe that would also require changing `help-mode' to use
`revert-buffer-function' and `revert-buffer' instead of binding
`help-mode-revert-buffer', right?
Kevin Foley
next prev parent reply other threads:[~2020-10-25 20:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 20:25 bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer Kevin Foley
2020-10-24 23:40 ` Drew Adams
2020-10-25 0:01 ` Stefan Kangas
2020-10-25 13:39 ` Kevin Foley
2020-10-25 13:50 ` Lars Ingebrigtsen
2020-10-25 14:47 ` Kevin Foley
2020-10-25 16:50 ` Lars Ingebrigtsen
2020-10-25 18:42 ` Stefan Kangas
2020-10-25 20:08 ` Kevin Foley [this message]
2020-10-26 10:22 ` Lars Ingebrigtsen
2020-10-26 14:59 ` Stefan Kangas
2020-10-26 22:05 ` Kevin Foley
2020-10-27 7:27 ` Lars Ingebrigtsen
2020-11-17 13:04 ` Stefan Kangas
2020-11-24 5:26 ` Lars Ingebrigtsen
2020-11-24 15:57 ` Stefan Kangas
2020-11-25 7:01 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d016kr14.fsf@Kevins-MBP.home.lan \
--to=kevin@kevinjfoley.me \
--cc=44202@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).