unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Kevin Foley <kevin@kevinjfoley.me>
Cc: Stefan Kangas <stefan@marxist.se>, 44202@debbugs.gnu.org
Subject: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer
Date: Tue, 27 Oct 2020 08:27:11 +0100	[thread overview]
Message-ID: <87lffsruwg.fsf@gnus.org> (raw)
In-Reply-To: <m2mu08y774.fsf@Kevins-MBP.home.lan> (Kevin Foley's message of "Mon, 26 Oct 2020 18:05:03 -0400")

Kevin Foley <kevin@kevinjfoley.me> writes:

> So would the solution be to remove the prompt all together?  Or would it
> the approach used in the patch to provide an option to control it
> specifically for *Help*?

I looked at the VC log for the *Help* function to see whether there was
a particular reason this function required confirmation (when most other
non-file buffer reverting functions didn't), and I couldn't find
anything.  My guess is that since the revert-buffer functions have a
NOCONFIRM parameter, then it was just implemented that way without,
since that seems logical.  (And it would be, if the NOCONFIRM parameter
was more...  logical.)

So I've just removed the prompting in *Help* unconditionally on the
trunk now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-10-27  7:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-24 20:25 bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer Kevin Foley
2020-10-24 23:40 ` Drew Adams
2020-10-25  0:01 ` Stefan Kangas
2020-10-25 13:39   ` Kevin Foley
2020-10-25 13:50     ` Lars Ingebrigtsen
2020-10-25 14:47       ` Kevin Foley
2020-10-25 16:50         ` Lars Ingebrigtsen
2020-10-25 18:42           ` Stefan Kangas
2020-10-25 20:08             ` Kevin Foley
2020-10-26 10:22               ` Lars Ingebrigtsen
2020-10-26 14:59                 ` Stefan Kangas
2020-10-26 22:05                   ` Kevin Foley
2020-10-27  7:27                     ` Lars Ingebrigtsen [this message]
2020-11-17 13:04                       ` Stefan Kangas
2020-11-24  5:26                         ` Lars Ingebrigtsen
2020-11-24 15:57                           ` Stefan Kangas
2020-11-25  7:01                             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lffsruwg.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=44202@debbugs.gnu.org \
    --cc=kevin@kevinjfoley.me \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).