From: Lars Ingebrigtsen <larsi@gnus.org>
To: Kevin Foley <kevin@kevinjfoley.me>
Cc: Stefan Kangas <stefan@marxist.se>, 44202@debbugs.gnu.org
Subject: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer
Date: Mon, 26 Oct 2020 11:22:40 +0100 [thread overview]
Message-ID: <87sga1477z.fsf@gnus.org> (raw)
In-Reply-To: <m2d016kr14.fsf@Kevins-MBP.home.lan> (Kevin Foley's message of "Sun, 25 Oct 2020 16:08:07 -0400")
Kevin Foley <kevin@kevinjfoley.me> writes:
> I could update `revert-buffer' to include the logic for IGNORE-AUTO and
> NOCONFIRM that are used in `revert-buffer--default' with some additional
> logic to handle buffers without associated files.
Let's see... That would be this bit from --default, I guess:
((or noconfirm
(and (not (buffer-modified-p))
(catch 'found
(dolist (regexp revert-without-query)
(when (string-match regexp file-name)
(throw 'found t)))))
(yes-or-no-p (format "Revert buffer from file %s? "
file-name)))
I am a bit worried about incompatibles by hoisting that code up to
`revert-buffer'...
I've looked at some of the different usages of `revert-buffer-function',
and the help-functions one seems to be an outlier -- very few of the
non-file ones ask at all (I haven't found one yet, but I've only looked
at a handful). Which makes me wonder why the *Help* one does? I've
always found that pretty odd. What's the use case for prompting the
user when the user hits `g' here?
> I believe that would also require changing `help-mode' to use
> `revert-buffer-function' and `revert-buffer' instead of binding
> `help-mode-revert-buffer', right?
`help-mode' does bind `g' to `revert-buffer'? So I think I don't quite
understand what you're asking.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-10-26 10:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 20:25 bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer Kevin Foley
2020-10-24 23:40 ` Drew Adams
2020-10-25 0:01 ` Stefan Kangas
2020-10-25 13:39 ` Kevin Foley
2020-10-25 13:50 ` Lars Ingebrigtsen
2020-10-25 14:47 ` Kevin Foley
2020-10-25 16:50 ` Lars Ingebrigtsen
2020-10-25 18:42 ` Stefan Kangas
2020-10-25 20:08 ` Kevin Foley
2020-10-26 10:22 ` Lars Ingebrigtsen [this message]
2020-10-26 14:59 ` Stefan Kangas
2020-10-26 22:05 ` Kevin Foley
2020-10-27 7:27 ` Lars Ingebrigtsen
2020-11-17 13:04 ` Stefan Kangas
2020-11-24 5:26 ` Lars Ingebrigtsen
2020-11-24 15:57 ` Stefan Kangas
2020-11-25 7:01 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sga1477z.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=44202@debbugs.gnu.org \
--cc=kevin@kevinjfoley.me \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).