bug#53853: [PATCH] Don't use string-replace in flymake

["João Távora" <joaotavora@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]

Well, technically, I did "show the patch" even though I didn't author said
patch myself. I answered:

> It would seem that the right thing to do is to keep 26.1 dep and do what
Guillaume Pasquet suggests:
> "or substitute the `string-replace` call with `replace-regexp-in-string`
to maintain compatibility as I have done here:
>
https://github.com/Etenil/flymake/commit/9f5f76907b1c258645f65728dd71e7cacffe6d22

Anyway, all good now, just bring the Emacs dep down to 26.1.  Thanks.

João


On Tue, Feb 8, 2022 at 1:55 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: João Távora <joaotavora@gmail.com>
> > Date: Tue, 8 Feb 2022 13:18:44 +0000
> > Cc: Robert Pluim <rpluim@gmail.com>, Brian Leung <leungbk@posteo.net>,
> >       Lars Ingebrigtsen <larsi@gnus.org>, 53853@debbugs.gnu.org
> >
> > Alright.  Seems that the discussion died down and there was never the
> fix and
> > reversion we (presumably?) agreed on. So I think if the incompatible
> string-something has
> > been now replaced by the replace-regexp-something that is compatible, we
> should now
> > put the 26.1 in the header again.  If everyone agrees, I ask someone
> with a Emacs
> > master/emacs-28 checkout nearby to do that change and also bump
> flymake.el's version.
>
> We didn't really agree on the revert: I asked to see the change as a
> prerequisite for my agreement, and never saw any response.
>
> I see that Lars already installed such a change on emacs-28, and it is
> indeed quite simple.  So I'm okay with going with that.
>


-- 
João Távora

[-- Attachment #2: Type: text/html, Size: 2521 bytes --]