bug#53853: [PATCH] Don't use string-replace in flymake

[Robert Pluim <rpluim@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

>>>>> On Tue, 8 Feb 2022 14:09:34 +0000, João Távora <joaotavora@gmail.com> said:

    João> Well, technically, I did "show the patch" even though I didn't author said
    João> patch myself. I answered:

    >> It would seem that the right thing to do is to keep 26.1 dep and do what
    João> Guillaume Pasquet suggests:
    >> "or substitute the `string-replace` call with `replace-regexp-in-string`
    João> to maintain compatibility as I have done here:
    >> 
    João> https://github.com/Etenil/flymake/commit/9f5f76907b1c258645f65728dd71e7cacffe6d22

    João> Anyway, all good now, just bring the Emacs dep down to 26.1.  Thanks.

Just so weʼre all clear, we want this in emacs-28 (on top of Lars's
change to use `replace-regexp-in-string'?


[-- Attachment #2: 0001-Mark-flymake-as-compatible-with-emacs-26.1.patch --]
[-- Type: text/x-diff, Size: 1111 bytes --]

From 31af9bca99fa88350271e1a905c9b435eaec28cf Mon Sep 17 00:00:00 2001
From: Robert Pluim <rpluim@gmail.com>
Date: Tue, 8 Feb 2022 16:04:15 +0100
Subject: [PATCH] Mark flymake as compatible with emacs-26.1
To: emacs-devel@gnu.org

* lisp/progmodes/flymake.el: Bump package version and set
emacs version in Package-Requires to 26.1 (Bug#53853).
---
 lisp/progmodes/flymake.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index e369cb1f21..83d7bc8641 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -4,9 +4,9 @@
 
 ;; Author: Pavel Kobyakov <pk_at_work@yahoo.com>
 ;; Maintainer: João Távora <joaotavora@gmail.com>
-;; Version: 1.2.1
+;; Version: 1.2.2
 ;; Keywords: c languages tools
-;; Package-Requires: ((emacs "28.1") (eldoc "1.1.0") (project "0.7.1"))
+;; Package-Requires: ((emacs "26.1") (eldoc "1.1.0") (project "0.7.1"))
 
 ;; This is a GNU ELPA :core package.  Avoid functionality that is not
 ;; compatible with the version of Emacs recorded above.
-- 
2.34.0


[-- Attachment #3: Type: text/plain, Size: 12 bytes --]


Robert
--