unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: leungbk@posteo.net, rpluim@gmail.com, larsi@gnus.org,
	53853@debbugs.gnu.org
Subject: bug#53853: [PATCH] Don't use string-replace in flymake
Date: Tue, 08 Feb 2022 15:54:47 +0200	[thread overview]
Message-ID: <83fsotwjiw.fsf@gnu.org> (raw)
In-Reply-To: <CALDnm511tMxH6s+iSzfmke-3WnQaWrGWCM8RgqjX2sgU=Ts5Zw@mail.gmail.com> (message from João Távora on Tue, 8 Feb 2022 13:18:44 +0000)

> From: João Távora <joaotavora@gmail.com>
> Date: Tue, 8 Feb 2022 13:18:44 +0000
> Cc: Robert Pluim <rpluim@gmail.com>, Brian Leung <leungbk@posteo.net>, 
> 	Lars Ingebrigtsen <larsi@gnus.org>, 53853@debbugs.gnu.org
> 
> Alright.  Seems that the discussion died down and there was never the fix and 
> reversion we (presumably?) agreed on. So I think if the incompatible string-something has 
> been now replaced by the replace-regexp-something that is compatible, we should now 
> put the 26.1 in the header again.  If everyone agrees, I ask someone with a Emacs 
> master/emacs-28 checkout nearby to do that change and also bump flymake.el's version.

We didn't really agree on the revert: I asked to see the change as a
prerequisite for my agreement, and never saw any response.

I see that Lars already installed such a change on emacs-28, and it is
indeed quite simple.  So I'm okay with going with that.





  reply	other threads:[~2022-02-08 13:54 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07 16:11 bug#53853: [PATCH] Don't use string-replace in flymake Brian Leung
2022-02-07 17:32 ` Robert Pluim
2022-02-08  2:17   ` Brian Leung
2022-02-08  6:16     ` Lars Ingebrigtsen
2022-02-08  8:21       ` Robert Pluim
2022-02-08  8:28         ` Brian Leung
2022-02-08  8:35           ` Robert Pluim
2022-02-08  9:20             ` João Távora
2022-02-08  9:50               ` Robert Pluim
2022-02-08  9:54                 ` João Távora
2022-02-08  9:58                   ` João Távora
2022-02-08 13:03                     ` Eli Zaretskii
2022-02-08 13:18                       ` João Távora
2022-02-08 13:54                         ` Eli Zaretskii [this message]
2022-02-08 14:09                           ` João Távora
2022-02-08 15:07                             ` Robert Pluim
2022-02-08 15:30                               ` João Távora
2022-02-08 15:47                                 ` Robert Pluim
2022-02-08 15:51                                   ` João Távora
2022-02-08 16:02                                     ` Robert Pluim
2022-02-08 16:43                                       ` João Távora
2022-02-08 17:02                                         ` Robert Pluim
2022-02-08 17:55                                         ` Dmitry Gutov
2022-02-08 17:08                                 ` Dmitry Gutov
2022-02-09  8:55                                   ` Robert Pluim
2022-02-08  9:52         ` João Távora
2022-02-08 10:19           ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fsotwjiw.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=53853@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=larsi@gnus.org \
    --cc=leungbk@posteo.net \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).