bug#53853: [PATCH] Don't use string-replace in flymake

[Robert Pluim <rpluim@gmail.com>]

>>>>> On Tue, 8 Feb 2022 09:52:34 +0000, João Távora <joaotavora@gmail.com> said:

    João> On Tue, Feb 8, 2022 at 9:26 AM Robert Pluim <rpluim@gmail.com> wrote:
    >> >>>>> On Tue, 08 Feb 2022 07:16:40 +0100, Lars Ingebrigtsen <
    >> larsi@gnus.org> said:
    >> 
    Lars> Brian Leung <leungbk@posteo.net> writes:
    >> >> OK, I've updated the patch per your suggestions. I've also made the
    >> >> commit apply to the emacs-28 branch, as opposed to the master
    >> branch.
    >> 
    Lars> Thanks; pushed to emacs-28.
    >> 
    >> Iʼm not au fait with how core packages work, does this require a bump
    >> in flymake's package version?


    João> Yes, Robert, I believe so. Else the core package won't get regenerated into
    João> GNU ELPA.

OK

    João> What _doesn't_ require a bump is, for example, `eglot.el` usage of it.  So
    João> if you
    João> bump flymake.el to, say, 1.9 now and eglot.el is still asking for 1.8, I
    João> think package.el
    João> will pull in the latest one regardless and the problem for eglot.el users
    João> will be fixed.

    João> I suspect though, that this problem only happened because the user was using
    João> the straight.el package manager, which will try to fetch the very latest
    João> (i.e.
    João> not go through GNU ELPA as package.el does).

    João> Anyway, thanks for fixing this.

I donʼt think weʼre quite there yet. Let's see what Eli says in the
other thread.

Robert
--