From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#53853: [PATCH] Don't use string-replace in flymake Date: Tue, 8 Feb 2022 14:09:34 +0000 Message-ID: References: <87r18e7fb7.fsf@gmail.com> <87zgn1ublj.fsf@gnus.org> <87mtj17oqg.fsf@gmail.com> <87ee4d7o3f.fsf@gmail.com> <875ypp7kmu.fsf@gmail.com> <83iltpwlwn.fsf@gnu.org> <83fsotwjiw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000001097eb05d7824236" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22876"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Brian Leung , Robert Pluim , Lars Ingebrigtsen , 53853@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 08 16:57:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHSs2-0005mi-MT for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 16:57:34 +0100 Original-Received: from localhost ([::1]:55354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHSs1-0005I8-Jv for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 10:57:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHRBy-0002MT-T5 for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 09:10:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHRBy-0003Dm-Ic for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 09:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHRBy-0004Nm-Bq for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 09:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Feb 2022 14:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53853-submit@debbugs.gnu.org id=B53853.164432934616755 (code B ref 53853); Tue, 08 Feb 2022 14:10:02 +0000 Original-Received: (at 53853) by debbugs.gnu.org; 8 Feb 2022 14:09:06 +0000 Original-Received: from localhost ([127.0.0.1]:45928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHRB4-0004MB-7C for submit@debbugs.gnu.org; Tue, 08 Feb 2022 09:09:06 -0500 Original-Received: from mail-oi1-f175.google.com ([209.85.167.175]:33671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHRB1-0004Lg-6J for 53853@debbugs.gnu.org; Tue, 08 Feb 2022 09:09:04 -0500 Original-Received: by mail-oi1-f175.google.com with SMTP id x193so20757966oix.0 for <53853@debbugs.gnu.org>; Tue, 08 Feb 2022 06:09:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ftO+VpoTzgZPY8VBELstzF62GK1imiGVSxb9KDgC7VM=; b=ePvCLoyHAzNfB6L+Q5+Gzh2usxH2zWg1nuv9G0r1nFT9bIwLDQwUgmBcOsko2ViaLP SR9V3jX5fLIyHNp/H+JlaLhtWnp47H3RQ3vvw+by4ywwfVRPAt8CcgGycm5UdyHMy34h Sx7RB1MS/tOjKeW70XSRwBM8P70yr8qP8Kz0NdzkcVMBab/vxIGH5+1HBvSKrsXq3v3y kLVbkFyD+TRuLlcfvaSja0qDgp+FWk3jb9eV3+75abB3hxzoxztk/leukh8/4BHXjnVx Cu/f+tcXfagnBnUguqMBXSC0gZexK2qUI+LeQWRuH5Behvh2f9phrKIat+eBknhuqgFC cgxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ftO+VpoTzgZPY8VBELstzF62GK1imiGVSxb9KDgC7VM=; b=SvYNGIXAWfFrVfRGZwWjeu1zuf/8EUxaJMfh9DFt6gNZqj/QLyRKZXYflUNLyvBPLP NPsMSkQtiXoymCvnaRiAVfejCdOYRhgI6YZJnIWZSzujIxdYjhzfnGRLjBZ/1+FGYbof 0giUMPbHnhc5JgRe6r77RLM7l4FuOgix2JjGuFwJRk2dkc9JEH8NbsJeNm7EwNfqe1A/ yD2M9M0L9JprTlhIG9ukdHnIT7hlP7QTD1m4EpSr5ZYOQnWk0ME/ytnXLkyZNKkgwTTk +daR4m5bqpRmPZZCLmcOI4NcvxNbI/YklZdtKx5Ak/rXCCE4JV8ZqTWgb3IcIPLP0yvp F3AQ== X-Gm-Message-State: AOAM530H4IKQyOQ7e7Bj3FbJ0B33nEz7CXDtKzMiHbppnmFvB18VEFfl 6g/mr966aZyoj0a5w3VjAJzFfcgFWBFpzjxuFLU= X-Google-Smtp-Source: ABdhPJx0614OBiAZwd1loTVfPHwLJgDh4/HEonT2CTVsnxvV8sV2snYp1rWRKrOdvc67sgnakpO9BrnYYVXYGiI7CQI= X-Received: by 2002:a05:6808:2016:: with SMTP id q22mr539800oiw.249.1644329337656; Tue, 08 Feb 2022 06:08:57 -0800 (PST) In-Reply-To: <83fsotwjiw.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226382 Archived-At: --0000000000001097eb05d7824236 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Well, technically, I did "show the patch" even though I didn't author said patch myself. I answered: > It would seem that the right thing to do is to keep 26.1 dep and do what Guillaume Pasquet suggests: > "or substitute the `string-replace` call with `replace-regexp-in-string` to maintain compatibility as I have done here: > https://github.com/Etenil/flymake/commit/9f5f76907b1c258645f65728dd71e7cacf= fe6d22 Anyway, all good now, just bring the Emacs dep down to 26.1. Thanks. Jo=C3=A3o On Tue, Feb 8, 2022 at 1:55 PM Eli Zaretskii wrote: > > From: Jo=C3=A3o T=C3=A1vora > > Date: Tue, 8 Feb 2022 13:18:44 +0000 > > Cc: Robert Pluim , Brian Leung , > > Lars Ingebrigtsen , 53853@debbugs.gnu.org > > > > Alright. Seems that the discussion died down and there was never the > fix and > > reversion we (presumably?) agreed on. So I think if the incompatible > string-something has > > been now replaced by the replace-regexp-something that is compatible, w= e > should now > > put the 26.1 in the header again. If everyone agrees, I ask someone > with a Emacs > > master/emacs-28 checkout nearby to do that change and also bump > flymake.el's version. > > We didn't really agree on the revert: I asked to see the change as a > prerequisite for my agreement, and never saw any response. > > I see that Lars already installed such a change on emacs-28, and it is > indeed quite simple. So I'm okay with going with that. > --=20 Jo=C3=A3o T=C3=A1vora --0000000000001097eb05d7824236 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Well, technically, I did "show the patch" e= ven though I didn't author said patch myself. I answered:

> It would seem that the right thing to do is to keep 26= .1 dep and do what Guillaume Pasquet suggests:
> "or substitute = the `string-replace` call with `replace-regexp-in-string` to maintain compa= tibility as I have done here:
> h= ttps://github.com/Etenil/flymake/commit/9f5f76907b1c258645f65728dd71e7cacff= e6d22

Anyway, all good now, just bring the= Emacs dep down to 26.1.=C2=A0 Thanks.

Jo=C3=A3o


On Tue, Feb 8, 2022 at 1:55 PM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Jo=C3=A3o T=C3=A1vora &= lt;joaotavora@gma= il.com>
> Date: Tue, 8 Feb 2022 13:18:44 +0000
> Cc: Robert Pluim <rpluim@gmail.com>, Brian Leung <leungbk@posteo.net>,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0Lars Ingebrigtsen <larsi@gnus.org>, 53853@debbugs.gnu.org
>
> Alright.=C2=A0 Seems that the discussion died down and there was never= the fix and
> reversion we (presumably?) agreed on. So I think if the incompatible s= tring-something has
> been now replaced by the replace-regexp-something that is compatible, = we should now
> put the 26.1 in the header again.=C2=A0 If everyone agrees, I ask some= one with a Emacs
> master/emacs-28 checkout nearby to do that change and also bump flymak= e.el's version.

We didn't really agree on the revert: I asked to see the change as a prerequisite for my agreement, and never saw any response.

I see that Lars already installed such a change on emacs-28, and it is
indeed quite simple.=C2=A0 So I'm okay with going with that.


--
Jo=C3=A3o T=C3=A1vora
--0000000000001097eb05d7824236--