bug#53853: [PATCH] Don't use string-replace in flymake

[Brian Leung <leungbk@posteo.net>]

[-- Attachment #1: Type: text/plain, Size: 848 bytes --]

Tags: patch

Tags: patch

See attached. Older Emacsen don't have string-replace.

In GNU Emacs 28.0.91 (build 1, aarch64-apple-darwin21.3.0, Carbon Version 165 AppKit 2113.3)
 of 2022-02-02 built on Brians-Mac-mini.local
Windowing system distributor 'Apple Inc.', version 12.2.0
System Description:  macOS 12.2

Configured using:
 'configure --enable-locallisppath=/opt/homebrew/share/emacs/site-lisp
 --infodir=/opt/homebrew/Cellar/emacs-mac/HEAD-674407f/share/info/emacs
 --prefix=/opt/homebrew/Cellar/emacs-mac/HEAD-674407f --with-mac
 --enable-mac-app=/opt/homebrew/Cellar/emacs-mac/HEAD-674407f
 --with-gnutls --with-modules --with-native-compilation
 'CFLAGS=-I/opt/homebrew/opt/gcc/include
 -I/opt/homebrew/opt/libgccjit/include'
 'LDFLAGS=-L/opt/homebrew/lib/gcc/11 -I/opt/homebrew/opt/gcc/include
 -I/opt/homebrew/opt/libgccjit/include''


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Don-t-use-string-replace-in-flymake.patch --]
[-- Type: text/patch, Size: 1149 bytes --]

From e08cd430e2c0acbf063ad2d6a2d8d093745a5c7c Mon Sep 17 00:00:00 2001
From: Brian Leung <leungbk@posteo.net>
Date: Mon, 7 Feb 2022 07:56:13 -0800
Subject: [PATCH] Don't use string-replace in flymake

* lisp/progmodes/flymake.el (flymake--log-1): Stay compatible with
older Emacsen.
---
 lisp/progmodes/flymake.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 0c16ddedcb..e369cb1f21 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -267,8 +267,8 @@ If set to nil, don't suppress any zero counters."
          (format " [%s %s]"
                  (or sublog 'flymake)
                  ;; Handle file names with "%" correctly.  (Bug#51549)
-                 (string-replace "%" "%%"
-                                 (buffer-name (current-buffer))))))
+                 (replace-regexp-in-string "%" "%%"
+                                           (buffer-name (current-buffer))))))
     (display-warning (list 'flymake sublog)
                      (apply #'format-message msg args)
                      (if (numberp level)
-- 
2.34.1