From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#53853: [PATCH] Don't use string-replace in flymake Date: Tue, 08 Feb 2022 11:19:03 +0100 Message-ID: <87tud964q0.fsf@gmail.com> References: <87r18e7fb7.fsf@gmail.com> <87zgn1ublj.fsf@gnus.org> <87mtj17oqg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39874"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Brian Leung , Lars Ingebrigtsen , 53853@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 08 11:58:50 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHOCw-000AGE-SO for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 11:58:50 +0100 Original-Received: from localhost ([::1]:51902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHOCv-0003Jp-9z for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 05:58:49 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHNbO-0007us-8V for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 05:20:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51552) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHNbN-0004V0-SV for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 05:20:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHNbN-0008C8-OC for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 05:20:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Feb 2022 10:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53853-submit@debbugs.gnu.org id=B53853.164431555431439 (code B ref 53853); Tue, 08 Feb 2022 10:20:01 +0000 Original-Received: (at 53853) by debbugs.gnu.org; 8 Feb 2022 10:19:14 +0000 Original-Received: from localhost ([127.0.0.1]:45449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHNac-0008B1-1J for submit@debbugs.gnu.org; Tue, 08 Feb 2022 05:19:14 -0500 Original-Received: from mail-wm1-f42.google.com ([209.85.128.42]:51921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHNaY-0008Al-Ep for 53853@debbugs.gnu.org; Tue, 08 Feb 2022 05:19:12 -0500 Original-Received: by mail-wm1-f42.google.com with SMTP id r131so6223668wma.1 for <53853@debbugs.gnu.org>; Tue, 08 Feb 2022 02:19:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=DcZCKtiwk0RmVrDds0Mz+TOQLA62EsUTkx9uh32nW6A=; b=YzZzLNwPFS//wTtNQ10VTxE50OeHKQGBkvvyQdSN6D762YBMcoNohgc43kqkd+dJxo S5jNYz7+F6NYkbJUTb8mRpmyAQGXnwc2ct5IDOQLdjQ9QHKRpNxhGxB0VCg2sRuCrlIf xoHt2Iq4DrXWhj4Y1KR0SW6wuwUOLEOTLoncEcBxi86mV3LpCsfWH5llo4Q4FKf1FoQQ RoKFaPj5EJU9uKGICWcE0vQr6P6k1t7u0BBl2rn/RpanZj9A3GTrpuqjvQ/lnAzN9oRM nkjaMy9K37q6WxIZbEuklJKTz/huvHCw0YluWTCTUPRLBWbYlVOz1CUNlLX7zwQch4t5 Hf2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=DcZCKtiwk0RmVrDds0Mz+TOQLA62EsUTkx9uh32nW6A=; b=YqdXkdY9mjdeT00a4XJ4eQs4cjB9aTOVEFUPN5ahaEl5L0XgkDBLBaEfqDKJ102oeX tC9bDrCvlNjl6ipCFwFevRlTs5ks2EXFPhFRuX7osaPYL4jLYK7gEgdZR/PJZxK8HDVJ mvB+/uCeDAsPGW0ksPEbeUM+Uy9QwPJvTTPMZV8j8Mr3ALLkiKBFBxy2SAHzhAEZzfC7 8rhf9wdxZQPfvBIDFU09nxvdd1jIshmJu3NRBOOY5vA5PFclKfazppuYjF2b08ouHL3s ZpcSy6LZhKbuNJgjRQAsXjwzv02BtKh0b8kNOnySaZglwGrGk8jMnn9hf39+HBYE7yFM PusQ== X-Gm-Message-State: AOAM531j2i9PKT/EykqQUC2zy3dCB88yL82paZ4JPhRIXIsJPPO7S1gr z0flUjiHmHQDzEu5Iu3Ee+BVPkSYheU= X-Google-Smtp-Source: ABdhPJyWVx/5rrUCp+HWyNBg3V0vSp7a+wvogogF84djvOk8IwPH5WLabU5NqYzYUiJVbAPhAsp0uw== X-Received: by 2002:a1c:f403:: with SMTP id z3mr490553wma.83.1644315544427; Tue, 08 Feb 2022 02:19:04 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb50:a7fc:d931:6725:24e8]) by smtp.gmail.com with ESMTPSA id o2sm1870272wmq.21.2022.02.08.02.19.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 02:19:03 -0800 (PST) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Tue, 8 Feb 2022 09:52:34 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226360 Archived-At: >>>>> On Tue, 8 Feb 2022 09:52:34 +0000, Jo=C3=A3o T=C3=A1vora said: Jo=C3=A3o> On Tue, Feb 8, 2022 at 9:26 AM Robert Pluim wrote: >> >>>>> On Tue, 08 Feb 2022 07:16:40 +0100, Lars Ingebrigtsen < >> larsi@gnus.org> said: >>=20 Lars> Brian Leung writes: >> >> OK, I've updated the patch per your suggestions. I've also made t= he >> >> commit apply to the emacs-28 branch, as opposed to the master >> branch. >>=20 Lars> Thanks; pushed to emacs-28. >>=20 >> I=CA=BCm not au fait with how core packages work, does this require = a bump >> in flymake's package version? Jo=C3=A3o> Yes, Robert, I believe so. Else the core package won't get r= egenerated into Jo=C3=A3o> GNU ELPA. OK Jo=C3=A3o> What _doesn't_ require a bump is, for example, `eglot.el` us= age of it. So Jo=C3=A3o> if you Jo=C3=A3o> bump flymake.el to, say, 1.9 now and eglot.el is still askin= g for 1.8, I Jo=C3=A3o> think package.el Jo=C3=A3o> will pull in the latest one regardless and the problem for e= glot.el users Jo=C3=A3o> will be fixed. Jo=C3=A3o> I suspect though, that this problem only happened because th= e user was using Jo=C3=A3o> the straight.el package manager, which will try to fetch the= very latest Jo=C3=A3o> (i.e. Jo=C3=A3o> not go through GNU ELPA as package.el does). Jo=C3=A3o> Anyway, thanks for fixing this. I don=CA=BCt think we=CA=BCre quite there yet. Let's see what Eli says in t= he other thread. Robert --=20