From: Visuwesh <visuweshm@gmail.com>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: Protesilaos Stavrou <info@protesilaos.com>,
64799@debbugs.gnu.org, Philip Kaludercic <philipk@posteo.net>
Subject: bug#64799: [PATCH] Add 'project-prompt-key' face
Date: Wed, 23 Aug 2023 16:05:14 +0530 [thread overview]
Message-ID: <87ttsq2gil.fsf@gmail.com> (raw)
In-Reply-To: <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> (Dmitry Gutov's message of "Thu, 27 Jul 2023 04:28:08 +0300")
[வியாழன் ஜூலை 27, 2023] Dmitry Gutov wrote:
> On 26/07/2023 07:50, Protesilaos Stavrou wrote:
>> For my use, and Emacs 28+, I want this:
>> (format "%s %s"
>> (propertize (key-description key) 'face 'project-prompt-key)
>> label)
>> The reason I mentioned the possibility of a user option is because
>> without the square brackets the bold face will not have the same effect
>> as the current design. The square brackets help add structure and make
>> it easier to identify the keys. The use of 'bold' without the square
>> brackets may make it more difficult for users to spot the keys.
>
> The change in format seems to go hand-in-hand with the change in face,
> though, because help-key-binding has a box already.
>
> Does this look good to everybody?
Sorry for replying so late. I make help-key-binding look the same as
the default face, and now I can't distinguish the keys from the labels
anymore since the former aren't bold anymore. :-(
Can there a way to get them back? If you think it would be too ugly,
then I can locally patch the function.
[ FWIW, I liked the bold approach since it is similar to what
read-multiple-choice does. ]
next prev parent reply other threads:[~2023-08-23 10:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 8:19 bug#64799: [PATCH] Add 'project-prompt-key' face Protesilaos Stavrou
2023-07-23 13:41 ` Philip Kaludercic
2023-07-23 13:49 ` Protesilaos Stavrou
2023-07-23 13:59 ` Philip Kaludercic
2023-07-24 5:53 ` Protesilaos Stavrou
2023-07-25 1:56 ` Dmitry Gutov
2023-07-25 6:39 ` Philip Kaludercic
2023-07-25 13:05 ` Dmitry Gutov
2023-07-26 4:50 ` Protesilaos Stavrou
2023-07-26 11:10 ` Eli Zaretskii
2023-07-27 1:01 ` Dmitry Gutov
2023-07-27 5:28 ` Eli Zaretskii
2023-07-28 0:56 ` Dmitry Gutov
2023-07-28 5:51 ` Eli Zaretskii
2023-07-27 1:28 ` Dmitry Gutov
2023-07-28 3:33 ` Protesilaos Stavrou
2023-08-12 0:35 ` Dmitry Gutov
2023-07-28 6:35 ` Philip Kaludercic
2023-08-23 10:35 ` Visuwesh [this message]
2023-08-23 12:18 ` Philip Kaludercic
2023-08-23 12:44 ` Dmitry Gutov
2023-08-23 14:13 ` Visuwesh
2023-08-23 15:24 ` Dmitry Gutov
2023-08-23 15:35 ` Visuwesh
2023-08-23 15:37 ` Dmitry Gutov
2023-08-23 15:45 ` Visuwesh
2023-08-23 16:40 ` Dmitry Gutov
2023-08-23 17:36 ` Visuwesh
2023-08-24 11:59 ` Mauro Aranda
2023-08-24 12:34 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttsq2gil.fsf@gmail.com \
--to=visuweshm@gmail.com \
--cc=64799@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=info@protesilaos.com \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).