From: Philip Kaludercic <philipk@posteo.net>
To: Protesilaos Stavrou <info@protesilaos.com>
Cc: 64799@debbugs.gnu.org
Subject: bug#64799: [PATCH] Add 'project-prompt-key' face
Date: Sun, 23 Jul 2023 13:59:41 +0000 [thread overview]
Message-ID: <87sf9ehgoi.fsf@posteo.net> (raw)
In-Reply-To: <874jluspp4.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Sun, 23 Jul 2023 16:49:27 +0300")
Protesilaos Stavrou <info@protesilaos.com> writes:
>> From: Philip Kaludercic <philipk@posteo.net>
>> Date: Sun, 23 Jul 2023 13:41:43 +0000
>>
>> Protesilaos Stavrou <info@protesilaos.com> writes:
>>
>>> Dear maintainers,
>>>
>>> I noticed that the project switching dispatch menu hardcodes its face to
>>> 'bold'. Adding a new face here allows themes/users to customise that
>>> style (e.g. to inherit the 'help-key-binding' face).
>>
>> Does this even need a separate face, or shouldn't `help-key-binding' be
>> reused directly?
>
> That would be my choice, though also with the removal of the square
> brackets around it. The proposed patch is for backward-compatibility.
Backwards-compatible to what? Can someone depend on this specific
behaviour? I think it would be better to replace the current code with
what you are suggesting, as a step towards ensuring a more consistent
user interface.
next prev parent reply other threads:[~2023-07-23 13:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 8:19 bug#64799: [PATCH] Add 'project-prompt-key' face Protesilaos Stavrou
2023-07-23 13:41 ` Philip Kaludercic
2023-07-23 13:49 ` Protesilaos Stavrou
2023-07-23 13:59 ` Philip Kaludercic [this message]
2023-07-24 5:53 ` Protesilaos Stavrou
2023-07-25 1:56 ` Dmitry Gutov
2023-07-25 6:39 ` Philip Kaludercic
2023-07-25 13:05 ` Dmitry Gutov
2023-07-26 4:50 ` Protesilaos Stavrou
2023-07-26 11:10 ` Eli Zaretskii
2023-07-27 1:01 ` Dmitry Gutov
2023-07-27 5:28 ` Eli Zaretskii
2023-07-28 0:56 ` Dmitry Gutov
2023-07-28 5:51 ` Eli Zaretskii
2023-07-27 1:28 ` Dmitry Gutov
2023-07-28 3:33 ` Protesilaos Stavrou
2023-08-12 0:35 ` Dmitry Gutov
2023-07-28 6:35 ` Philip Kaludercic
2023-08-23 10:35 ` Visuwesh
2023-08-23 12:18 ` Philip Kaludercic
2023-08-23 12:44 ` Dmitry Gutov
2023-08-23 14:13 ` Visuwesh
2023-08-23 15:24 ` Dmitry Gutov
2023-08-23 15:35 ` Visuwesh
2023-08-23 15:37 ` Dmitry Gutov
2023-08-23 15:45 ` Visuwesh
2023-08-23 16:40 ` Dmitry Gutov
2023-08-23 17:36 ` Visuwesh
2023-08-24 11:59 ` Mauro Aranda
2023-08-24 12:34 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sf9ehgoi.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=64799@debbugs.gnu.org \
--cc=info@protesilaos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).