From: Dmitry Gutov <dmitry@gutov.dev>
To: Protesilaos Stavrou <info@protesilaos.com>,
Philip Kaludercic <philipk@posteo.net>
Cc: 64799-done@debbugs.gnu.org
Subject: bug#64799: [PATCH] Add 'project-prompt-key' face
Date: Sat, 12 Aug 2023 03:35:34 +0300 [thread overview]
Message-ID: <0e3bcc19-ded4-7612-5b7d-d5147c8842d9@gutov.dev> (raw)
In-Reply-To: <875y64wvyz.fsf@protesilaos.com>
Version: 30.1
On 28/07/2023 06:33, Protesilaos Stavrou wrote:
>> From: Dmitry Gutov<dmitry@gutov.dev>
>> Date: Thu, 27 Jul 2023 04:28:08 +0300
>> [... 14 lines elided]
>> The change in format seems to go hand-in-hand with the change in face,
>> though, because help-key-binding has a box already.
>>
>> Does this look good to everybody?
>>
>> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
>> index d482cc24d70..3611757fb82 100644
>> --- a/lisp/progmodes/project.el
>> +++ b/lisp/progmodes/project.el
>> @@ -1781,9 +1781,13 @@ project--keymap-prompt
>> (let ((key (if key
>> (vector key)
>> (where-is-internal cmd (list project-prefix-map) t))))
>> - (format "[%s] %s"
>> - (propertize (key-description key) 'face 'bold)
>> - label)))
>> + (if (facep 'help-key-binding)
>> + (format "%s %s"
>> + (propertize (key-description key) 'face
>> 'help-key-binding)
>> + label)
>> + (format "[%s] %s"
>> + (propertize (key-description key) 'face 'bold)
>> + label))))
>> project-switch-commands
>> " "))
> I am fine with this approach, thank you!
Now pushed to master, thanks all!
next prev parent reply other threads:[~2023-08-12 0:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 8:19 bug#64799: [PATCH] Add 'project-prompt-key' face Protesilaos Stavrou
2023-07-23 13:41 ` Philip Kaludercic
2023-07-23 13:49 ` Protesilaos Stavrou
2023-07-23 13:59 ` Philip Kaludercic
2023-07-24 5:53 ` Protesilaos Stavrou
2023-07-25 1:56 ` Dmitry Gutov
2023-07-25 6:39 ` Philip Kaludercic
2023-07-25 13:05 ` Dmitry Gutov
2023-07-26 4:50 ` Protesilaos Stavrou
2023-07-26 11:10 ` Eli Zaretskii
2023-07-27 1:01 ` Dmitry Gutov
2023-07-27 5:28 ` Eli Zaretskii
2023-07-28 0:56 ` Dmitry Gutov
2023-07-28 5:51 ` Eli Zaretskii
2023-07-27 1:28 ` Dmitry Gutov
2023-07-28 3:33 ` Protesilaos Stavrou
2023-08-12 0:35 ` Dmitry Gutov [this message]
2023-07-28 6:35 ` Philip Kaludercic
2023-08-23 10:35 ` Visuwesh
2023-08-23 12:18 ` Philip Kaludercic
2023-08-23 12:44 ` Dmitry Gutov
2023-08-23 14:13 ` Visuwesh
2023-08-23 15:24 ` Dmitry Gutov
2023-08-23 15:35 ` Visuwesh
2023-08-23 15:37 ` Dmitry Gutov
2023-08-23 15:45 ` Visuwesh
2023-08-23 16:40 ` Dmitry Gutov
2023-08-23 17:36 ` Visuwesh
2023-08-24 11:59 ` Mauro Aranda
2023-08-24 12:34 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e3bcc19-ded4-7612-5b7d-d5147c8842d9@gutov.dev \
--to=dmitry@gutov.dev \
--cc=64799-done@debbugs.gnu.org \
--cc=info@protesilaos.com \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).