unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Mauro Aranda <maurooaranda@gmail.com>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: Philip Kaludercic <philipk@posteo.net>,
	64799@debbugs.gnu.org, Protesilaos Stavrou <info@protesilaos.com>,
	Visuwesh <visuweshm@gmail.com>
Subject: bug#64799: [PATCH] Add 'project-prompt-key' face
Date: Thu, 24 Aug 2023 08:59:13 -0300	[thread overview]
Message-ID: <43bb13ec-98d3-7b9b-4129-72030b08a5ab@gmail.com> (raw)
In-Reply-To: <43a50ddb-8702-ba2e-7bac-6fba75176882@gutov.dev>

Dmitry Gutov <dmitry@gutov.dev> writes:

 > On 23/08/2023 18:45, Visuwesh wrote:
 >> [புதன் ஆகஸ்ட் 23, 2023] Dmitry Gutov wrote:
 >>
 >>> On 23/08/2023 18:35, Visuwesh wrote:
 >>>>> Anyway, if you want the option, can you suggest how it will be 
called?
 >>>>> Will it be just boolean?
 >>>> A boolean option will be fine.  The facep condition can then be 
changed
 >>>> to (and NEW-OPTION (facep 'help-key-binding)).
 >>> Any ideas for the name?
 >> project-prompt-key-use-bold-face?  I am unfortunately terrible at naming
 >> things.
 >
 > Ok, I've added project-key-prompt-style.
 >
 > Please test whenever convenient.

Hi Dmitry,

 > (defcustom project-key-prompt-style (if (facep 'help-key-binding)
 >                                         t
 >                                       'brackets)
 >   "Which presentation to use when asking to choose a command by key.
 >
 > When `brackets', use text brackets and `bold' for the character.
 > Otherwise, use the face `help-key-binding' in the prompt."
 >   :type 'boolean
 >   :group 'project
 >   :version "30.1")

Shouldn't the :type be a choice between t and brackets?






  parent reply	other threads:[~2023-08-24 11:59 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-23  8:19 bug#64799: [PATCH] Add 'project-prompt-key' face Protesilaos Stavrou
2023-07-23 13:41 ` Philip Kaludercic
2023-07-23 13:49   ` Protesilaos Stavrou
2023-07-23 13:59     ` Philip Kaludercic
2023-07-24  5:53       ` Protesilaos Stavrou
2023-07-25  1:56         ` Dmitry Gutov
2023-07-25  6:39           ` Philip Kaludercic
2023-07-25 13:05             ` Dmitry Gutov
2023-07-26  4:50               ` Protesilaos Stavrou
2023-07-26 11:10                 ` Eli Zaretskii
2023-07-27  1:01                   ` Dmitry Gutov
2023-07-27  5:28                     ` Eli Zaretskii
2023-07-28  0:56                       ` Dmitry Gutov
2023-07-28  5:51                         ` Eli Zaretskii
2023-07-27  1:28                 ` Dmitry Gutov
2023-07-28  3:33                   ` Protesilaos Stavrou
2023-08-12  0:35                     ` Dmitry Gutov
2023-07-28  6:35                   ` Philip Kaludercic
2023-08-23 10:35                   ` Visuwesh
2023-08-23 12:18                     ` Philip Kaludercic
2023-08-23 12:44                       ` Dmitry Gutov
2023-08-23 14:13                         ` Visuwesh
2023-08-23 15:24                           ` Dmitry Gutov
2023-08-23 15:35                             ` Visuwesh
2023-08-23 15:37                               ` Dmitry Gutov
2023-08-23 15:45                                 ` Visuwesh
2023-08-23 16:40                                   ` Dmitry Gutov
2023-08-23 17:36                                     ` Visuwesh
2023-08-24 11:59                                     ` Mauro Aranda [this message]
2023-08-24 12:34                                       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43bb13ec-98d3-7b9b-4129-72030b08a5ab@gmail.com \
    --to=maurooaranda@gmail.com \
    --cc=64799@debbugs.gnu.org \
    --cc=dmitry@gutov.dev \
    --cc=info@protesilaos.com \
    --cc=philipk@posteo.net \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).