unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Protesilaos Stavrou <info@protesilaos.com>
To: Dmitry Gutov <dmitry@gutov.dev>, Philip Kaludercic <philipk@posteo.net>
Cc: 64799@debbugs.gnu.org
Subject: bug#64799: [PATCH] Add 'project-prompt-key' face
Date: Wed, 26 Jul 2023 07:50:26 +0300	[thread overview]
Message-ID: <87jzun5l9p.fsf@protesilaos.com> (raw)
In-Reply-To: <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev>

> From: Dmitry Gutov <dmitry@gutov.dev>
> Date: Tue, 25 Jul 2023 16:05:15 +0300

> [... 13 lines elided]

>> Alternatively, we could add a version/facep check and always prefer
>> `help-key-binding' if it is available, otherwise fall-back to the
>> current option.
>
> That works for me.

Me too!

>>>> Perhaps a user option for the whole 'format' would be better?
>>>
>>> We can add a user option. But while we could also apply 'face'
>>> property on that option's string value, that doesn't seem like a very
>>> user-friendly approach toward someone who will want to change the face
>>> used (it will require some Lisp knowledge from the user).
>>>
>>> But a user option to change how the prompt text is constructed -- why
>>> not. E.g. one defaulting to "[%s] %s".
>> 
>> Is there really such a wide range of options that users might be
>> interested in here?
>
> Protesilaos wanted to use a different format?

For my use, and Emacs 28+, I want this:

    (format "%s %s"
               (propertize (key-description key) 'face 'project-prompt-key)
               label)

The reason I mentioned the possibility of a user option is because
without the square brackets the bold face will not have the same effect
as the current design.  The square brackets help add structure and make
it easier to identify the keys.  The use of 'bold' without the square
brackets may make it more difficult for users to spot the keys.

-- 
Protesilaos Stavrou
https://protesilaos.com





  reply	other threads:[~2023-07-26  4:50 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-23  8:19 bug#64799: [PATCH] Add 'project-prompt-key' face Protesilaos Stavrou
2023-07-23 13:41 ` Philip Kaludercic
2023-07-23 13:49   ` Protesilaos Stavrou
2023-07-23 13:59     ` Philip Kaludercic
2023-07-24  5:53       ` Protesilaos Stavrou
2023-07-25  1:56         ` Dmitry Gutov
2023-07-25  6:39           ` Philip Kaludercic
2023-07-25 13:05             ` Dmitry Gutov
2023-07-26  4:50               ` Protesilaos Stavrou [this message]
2023-07-26 11:10                 ` Eli Zaretskii
2023-07-27  1:01                   ` Dmitry Gutov
2023-07-27  5:28                     ` Eli Zaretskii
2023-07-28  0:56                       ` Dmitry Gutov
2023-07-28  5:51                         ` Eli Zaretskii
2023-07-27  1:28                 ` Dmitry Gutov
2023-07-28  3:33                   ` Protesilaos Stavrou
2023-08-12  0:35                     ` Dmitry Gutov
2023-07-28  6:35                   ` Philip Kaludercic
2023-08-23 10:35                   ` Visuwesh
2023-08-23 12:18                     ` Philip Kaludercic
2023-08-23 12:44                       ` Dmitry Gutov
2023-08-23 14:13                         ` Visuwesh
2023-08-23 15:24                           ` Dmitry Gutov
2023-08-23 15:35                             ` Visuwesh
2023-08-23 15:37                               ` Dmitry Gutov
2023-08-23 15:45                                 ` Visuwesh
2023-08-23 16:40                                   ` Dmitry Gutov
2023-08-23 17:36                                     ` Visuwesh
2023-08-24 11:59                                     ` Mauro Aranda
2023-08-24 12:34                                       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzun5l9p.fsf@protesilaos.com \
    --to=info@protesilaos.com \
    --cc=64799@debbugs.gnu.org \
    --cc=dmitry@gutov.dev \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).