From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#64799: [PATCH] Add 'project-prompt-key' face Date: Wed, 23 Aug 2023 16:05:14 +0530 Message-ID: <87ttsq2gil.fsf@gmail.com> References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14115"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Protesilaos Stavrou , 64799@debbugs.gnu.org, Philip Kaludercic To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 23 12:36:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qYlDi-0003Oa-8s for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Aug 2023 12:36:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qYlDV-00017N-C2; Wed, 23 Aug 2023 06:36:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYlDT-00016t-He for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 06:35:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qYlDT-0003su-9S for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 06:35:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qYlDW-0004TD-CS for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 06:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Aug 2023 10:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64799-submit@debbugs.gnu.org id=B64799.169278692917140 (code B ref 64799); Wed, 23 Aug 2023 10:36:02 +0000 Original-Received: (at 64799) by debbugs.gnu.org; 23 Aug 2023 10:35:29 +0000 Original-Received: from localhost ([127.0.0.1]:32885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYlCy-0004SN-Qx for submit@debbugs.gnu.org; Wed, 23 Aug 2023 06:35:29 -0400 Original-Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:45353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYlCw-0004SA-PV for 64799@debbugs.gnu.org; Wed, 23 Aug 2023 06:35:27 -0400 Original-Received: by mail-pl1-x644.google.com with SMTP id d9443c01a7336-1bf7423ef3eso22727155ad.3 for <64799@debbugs.gnu.org>; Wed, 23 Aug 2023 03:35:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692786917; x=1693391717; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x2QSezNLkGz78rdv/jdGp6UbPlL+tod1TovS+MDcgFE=; b=HOFhBB+8lm4jKpwwVGXwUnpDE9hGWDDzoKk6bhgSR/PVCiSuThDCNymW9JLwheyA7j P3SqEPy0Ci8cFmrudtsRbRx7FufZQAGcoWUkSTFo5hIk44utY/JjJwyLyCmgv1qKASBT d9grlR+0Gzv++7g4vEjuUd6jDAuGM/HQvgzcDcxPs/3Y4KWWIzl+AJrfzcM8ZtZafH0Q PH/BSysdu/UyWb10y9O6vwvcqa+vVssE0xI8Rr6PD3qIrfiM3fEHfLoYT7MElI3++EYK NR8n1jQxLCu+pD8ainri1c7/8OXz3D8iReWP180FAb9nfhgWNxXEWtImsc97FeKkWSme 4Zpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692786917; x=1693391717; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=x2QSezNLkGz78rdv/jdGp6UbPlL+tod1TovS+MDcgFE=; b=R/cS1ZXsBdjCVbzyQRWOyYIkAl7uzB4YS8LXTN0EV+io3Y3i1j36+pgkt02IBH6WBm sGo4RIWSgl2a/GbHCo4SQvB95jxRpPwXynvmWX7T+RyX167kAcu5U60arAzqws4MwOMO 0/M1KN30I+pygmAQkCnPTN/Fokv3khULXwmHEQ9KAIqfAY1bsBNwpSIHzl+pa21BYent nkuV81pVktcGF5zM06auzq+N8oz5JZV41PSDwHSBMn+x7471Bh1whrsOzlmwra57pot8 rvBqdP9n13yIvdh7HNiUhr7bbmJG5bDVpOQnktERgHG4k1QukZb4L2g/ArU6VDVjloUW bYYw== X-Gm-Message-State: AOJu0Yyb8Y4X1bY8wy67jyS43UvLpTSAvUUL6QWdmgmTzDdlyf87qfOz 0oA/NzbeCq5E6IPoNZVVgBA= X-Google-Smtp-Source: AGHT+IH78WV69RtRbdrkZ2wylrvx0tIocED+N5UaiFhNBYc3DOje6tiKsttEAjKJ9WrdcloXL7JrkA== X-Received: by 2002:a17:903:124b:b0:1b7:e646:4cc4 with SMTP id u11-20020a170903124b00b001b7e6464cc4mr12215403plh.28.1692786917421; Wed, 23 Aug 2023 03:35:17 -0700 (PDT) Original-Received: from localhost ([14.139.216.98]) by smtp.gmail.com with ESMTPSA id i3-20020a170902c94300b001b890009634sm10576223pla.139.2023.08.23.03.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Aug 2023 03:35:16 -0700 (PDT) In-Reply-To: <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> (Dmitry Gutov's message of "Thu, 27 Jul 2023 04:28:08 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268218 Archived-At: [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE=9C= =E0=AF=82=E0=AE=B2=E0=AF=88 27, 2023] Dmitry Gutov wrote: > On 26/07/2023 07:50, Protesilaos Stavrou wrote: >> For my use, and Emacs 28+, I want this: >> (format "%s %s" >> (propertize (key-description key) 'face 'project-prompt-= key) >> label) >> The reason I mentioned the possibility of a user option is because >> without the square brackets the bold face will not have the same effect >> as the current design. The square brackets help add structure and make >> it easier to identify the keys. The use of 'bold' without the square >> brackets may make it more difficult for users to spot the keys. > > The change in format seems to go hand-in-hand with the change in face, > though, because help-key-binding has a box already. > > Does this look good to everybody? Sorry for replying so late. I make help-key-binding look the same as the default face, and now I can't distinguish the keys from the labels anymore since the former aren't bold anymore. :-( Can there a way to get them back? If you think it would be too ugly, then I can locally patch the function. [ FWIW, I liked the bold approach since it is similar to what read-multiple-choice does. ]