From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#64799: [PATCH] Add 'project-prompt-key' face Date: Sun, 23 Jul 2023 13:59:41 +0000 Message-ID: <87sf9ehgoi.fsf@posteo.net> References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8187"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64799@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 23 16:00:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qNZdD-0001wP-Rv for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Jul 2023 16:00:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNZcz-0003R5-3N; Sun, 23 Jul 2023 10:00:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNZcx-0003Qf-Dv for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 10:00:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qNZcw-0003dP-P3 for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 10:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qNZcw-0004Uh-K5 for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 10:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jul 2023 14:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64799-submit@debbugs.gnu.org id=B64799.169012079117226 (code B ref 64799); Sun, 23 Jul 2023 14:00:02 +0000 Original-Received: (at 64799) by debbugs.gnu.org; 23 Jul 2023 13:59:51 +0000 Original-Received: from localhost ([127.0.0.1]:41079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNZck-0004Tm-SY for submit@debbugs.gnu.org; Sun, 23 Jul 2023 09:59:51 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:47311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNZci-0004TZ-8N for 64799@debbugs.gnu.org; Sun, 23 Jul 2023 09:59:48 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id AD19A240028 for <64799@debbugs.gnu.org>; Sun, 23 Jul 2023 15:59:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1690120782; bh=dhGLZ68G93PKyMC5k4cgGvjw4J9VAT5xa3SvW5Rd1Mg=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=AP3L+OUTbR2AAJhQvVtN9ao0Zhp/S7KI7siTO292FNqCAlzd78HeXqW20vHjFdgEb qQTi1yc+j1OrVKKY3Cgsu0+pbJf6AoxwLZt21JHgU9lqWyCoQaklFdv528wC4mSPNT pH/JdsOYm3oF9g4fFXFumxXvAHSj7Os28UxLuiOWeEkFXLLJN6Ip2buvJyn2xjwdm7 K+QvOb7kxP3OVAFj9k8McE7jhmU5wX86OB21mLDAOemC7Qhx5qJmUfqH0qINpy49rR cE+c/Quozx/7RDvhEsLlsphYjKmo+qAOm1Tfvo7xA0QUPZc+PYzAVykC8tjosJ3seH nF+ejL1DSMv8A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R84fk2YW2z9rxL; Sun, 23 Jul 2023 15:59:42 +0200 (CEST) In-Reply-To: <874jluspp4.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Sun, 23 Jul 2023 16:49:27 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265908 Archived-At: Protesilaos Stavrou writes: >> From: Philip Kaludercic >> Date: Sun, 23 Jul 2023 13:41:43 +0000 >> >> Protesilaos Stavrou writes: >> >>> Dear maintainers, >>> >>> I noticed that the project switching dispatch menu hardcodes its face to >>> 'bold'. Adding a new face here allows themes/users to customise that >>> style (e.g. to inherit the 'help-key-binding' face). >> >> Does this even need a separate face, or shouldn't `help-key-binding' be >> reused directly? > > That would be my choice, though also with the removal of the square > brackets around it. The proposed patch is for backward-compatibility. Backwards-compatible to what? Can someone depend on this specific behaviour? I think it would be better to replace the current code with what you are suggesting, as a step towards ensuring a more consistent user interface.