unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 47012@debbugs.gnu.org
Subject: bug#47012: xref copies keymap properties to minibuffer
Date: Tue, 30 Mar 2021 22:16:07 +0300	[thread overview]
Message-ID: <87pmzgtr80.fsf@mail.linkov.net> (raw)
In-Reply-To: <4228b128-039c-2bcd-002c-5ac830d7a4d3@yandex.ru> (Dmitry Gutov's message of "Fri, 26 Mar 2021 00:12:21 +0200")

>>>    (defvar project-regexp-history-variable 'grep-regexp-history)
>>>
>>> will be good enough.
>> This would a good thing to do.
>
> Let's go with this one, then. At least for now.
>
> Meaning, your patch plus a change of the default value to
> 'grep-regexp-history.

Now patch is pushed.

BTW, it was a big hassle to use project-find-regexp
until I realized where is the problem.  There is
no such problem in grep because in the grep output
file names are placed separately on the left,
and output lines are on the right on the same lines.
So it's easy to scan output lines visually.

But the output of project-find-regexp is a mess
because output lines are interspersed with file names
where output lines are almost indistinguishable
from file lines.  Indeed, file names are currently
highlighted in green color, but such green foreground
doesn't help to distinguish file names from output lines,
so it's very hard to read the output.

Then I realized that this problem is already solved
in diff-mode where the faces 'diff-header' and
'diff-file-header' use the grey background to separate diff hunks.

Using the same solution of 'diff-header' and
'diff-file-header' for 'xref-file-header'
improves the readability significantly:

#+begin_src diff
diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
index ea52befec5..f2aa8bfba4 100644
--- a/lisp/progmodes/xref.el
+++ b/lisp/progmodes/xref.el
@@ -513,7 +513,7 @@ xref-pop-to-location
 (defconst xref-buffer-name "*xref*"
   "The name of the buffer to show xrefs.")
 
-(defface xref-file-header '((t :inherit compilation-info))
+(defface xref-file-header '((t :background "grey90" :extend t))
   "Face used to highlight file header in the xref buffer."
   :version "27.1")
#+end_src





  reply	other threads:[~2021-03-30 19:16 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08 20:03 bug#47012: xref copies keymap properties to minibuffer Juri Linkov
2021-03-09  2:08 ` Dmitry Gutov
2021-03-11 20:58   ` Juri Linkov
2021-03-24 20:38     ` Juri Linkov
2021-03-24 21:57       ` Dmitry Gutov
2021-03-25  9:40         ` Juri Linkov
2021-03-25 10:57           ` Dmitry Gutov
2021-03-25 21:28             ` Juri Linkov
2021-03-25 22:12               ` Dmitry Gutov
2021-03-30 19:16                 ` Juri Linkov [this message]
2021-03-31 15:47                   ` Dmitry Gutov
2021-03-31 15:59                     ` Eli Zaretskii
2021-03-31 16:10                       ` Dmitry Gutov
2021-03-31 16:57                         ` Eli Zaretskii
2021-04-01  0:25                           ` Dmitry Gutov
2021-04-01  7:17                             ` Eli Zaretskii
2021-03-31 17:05                     ` Juri Linkov
2021-04-01  1:16                       ` Dmitry Gutov
2021-04-01  8:43                         ` Juri Linkov
2021-04-01 14:13                           ` Dmitry Gutov
2021-04-01 18:45                             ` Juri Linkov
2021-04-01 19:06                               ` Eli Zaretskii
2021-04-01 21:28                                 ` Dmitry Gutov
2021-04-02  6:08                                   ` Eli Zaretskii
2021-04-02 23:50                                     ` Dmitry Gutov
2021-04-03  7:24                                       ` Eli Zaretskii
2021-04-03 18:12                                         ` Dmitry Gutov
2021-04-03 18:19                                           ` Eli Zaretskii
2021-04-02  8:20                                 ` Juri Linkov
2021-04-01 22:43                               ` Dmitry Gutov
2021-04-02  8:25                                 ` Juri Linkov
2021-04-02 23:23                                   ` Dmitry Gutov
2021-04-04 22:55                                     ` Juri Linkov
2021-04-05  2:15                                       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmzgtr80.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=47012@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).