unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 47012@debbugs.gnu.org, juri@linkov.net
Subject: bug#47012: xref copies keymap properties to minibuffer
Date: Sat, 3 Apr 2021 02:50:52 +0300	[thread overview]
Message-ID: <977f95e6-4e83-c376-54b2-76bc64ef32b0@yandex.ru> (raw)
In-Reply-To: <83blaxfcbb.fsf@gnu.org>

On 02.04.2021 09:08, Eli Zaretskii wrote:

>> Did you like any of the options I suggested?
> 
> I didn't try them, and re-reading the thread now I don't think I
> understand which options are you referring to here.  There was one
> suggestion, to add the bold attribute to the existing face, which you
> later retracted because that face is already bold, but I see no other
> concrete suggestions for changes in that face.  What am I missing?
> Could you please list those options for which you'd like my opinion?

See bug#47574 for a self-contained explanation.

>>> In general, when discussing faces used by some feature (in this case
>>> Xref and project.el), please don't change the defaults of unrelated
>>> faces, let alone more general ones.
>>
>> I agree it should be a separate change/discussion.
>>
>> Should we continue that in a new bug report or on emacs-devel?
> 
> If it's an important issue, probably the latter.

Important enough for me to file a bug, but not to spend much time 
fighting over it.

> If it's just a tool
> to fix some other face, I'd prefer not to change Occur faces at all,
> and instead find an independent way of doing TRT with Xref and/or
> project.el faces.
Yes, of course. I'm suggesting to change the 'match' face definition 
because I think all its uses will benefit from it (including Occur and 
Grep which I made sure to try with all proposed colors).

'xref-match' face is customizable separately, but I don't think it will 
be productive to change only it but not 'match'.

The faces are used similarly enough, so it's hard to justify making them 
look different in the default configuration.





  reply	other threads:[~2021-04-02 23:50 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08 20:03 bug#47012: xref copies keymap properties to minibuffer Juri Linkov
2021-03-09  2:08 ` Dmitry Gutov
2021-03-11 20:58   ` Juri Linkov
2021-03-24 20:38     ` Juri Linkov
2021-03-24 21:57       ` Dmitry Gutov
2021-03-25  9:40         ` Juri Linkov
2021-03-25 10:57           ` Dmitry Gutov
2021-03-25 21:28             ` Juri Linkov
2021-03-25 22:12               ` Dmitry Gutov
2021-03-30 19:16                 ` Juri Linkov
2021-03-31 15:47                   ` Dmitry Gutov
2021-03-31 15:59                     ` Eli Zaretskii
2021-03-31 16:10                       ` Dmitry Gutov
2021-03-31 16:57                         ` Eli Zaretskii
2021-04-01  0:25                           ` Dmitry Gutov
2021-04-01  7:17                             ` Eli Zaretskii
2021-03-31 17:05                     ` Juri Linkov
2021-04-01  1:16                       ` Dmitry Gutov
2021-04-01  8:43                         ` Juri Linkov
2021-04-01 14:13                           ` Dmitry Gutov
2021-04-01 18:45                             ` Juri Linkov
2021-04-01 19:06                               ` Eli Zaretskii
2021-04-01 21:28                                 ` Dmitry Gutov
2021-04-02  6:08                                   ` Eli Zaretskii
2021-04-02 23:50                                     ` Dmitry Gutov [this message]
2021-04-03  7:24                                       ` Eli Zaretskii
2021-04-03 18:12                                         ` Dmitry Gutov
2021-04-03 18:19                                           ` Eli Zaretskii
2021-04-02  8:20                                 ` Juri Linkov
2021-04-01 22:43                               ` Dmitry Gutov
2021-04-02  8:25                                 ` Juri Linkov
2021-04-02 23:23                                   ` Dmitry Gutov
2021-04-04 22:55                                     ` Juri Linkov
2021-04-05  2:15                                       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=977f95e6-4e83-c376-54b2-76bc64ef32b0@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=47012@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).