unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 47012@debbugs.gnu.org
Subject: bug#47012: xref copies keymap properties to minibuffer
Date: Wed, 24 Mar 2021 22:38:34 +0200	[thread overview]
Message-ID: <87sg4kb839.fsf@mail.linkov.net> (raw)
In-Reply-To: <87a6r9v24b.fsf@mail.linkov.net> (Juri Linkov's message of "Thu,  11 Mar 2021 22:58:44 +0200")

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

>> FWIW, it's was project.el's problem, not xref's.
>
> I thought it's the xref's problem because Help says it's in xref.el.
> Typing 'C-h f project--read-regexp RET' shows:
>
>   project--read-regexp is a Lisp function in ‘xref.el’.
>
> But this is because I tried to override this function in the init file:
>
> ;; Redefine to use `minibuffer-history':
> (with-eval-after-load 'project
>   (defun project--read-regexp ()
>     (let ((sym (thing-at-point 'symbol t)))
>       (read-regexp "Find regexp"
>                    (and sym (regexp-quote sym))
>                    'minibuffer-history))))
>
> Oh, well, need to find another way to do this
> (no feature request for this :-)

Actually, can't do this without feature request,
and can't use it as is, because never use regexp
while searching in project, whereas it pollutes
the regexp history for commands where I really
use regexps, not just strings.

A simple patch could be a saver to use with e.g.
(setq project-regexp-history-variable 'minibuffer-history):


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: project-regexp-history-variable.patch --]
[-- Type: text/x-diff, Size: 630 bytes --]

diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index b6a886f731..280a8d8929 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -781,9 +781,12 @@ project--find-regexp-in-files
       (user-error "No matches for: %s" regexp))
     xrefs))
 
+(defvar project-regexp-history-variable nil)
+
 (defun project--read-regexp ()
   (let ((sym (thing-at-point 'symbol t)))
-    (read-regexp "Find regexp" (and sym (regexp-quote sym)))))
+    (read-regexp "Find regexp" (and sym (regexp-quote sym))
+                 project-regexp-history-variable)))
 
 ;;;###autoload
 (defun project-find-file ()

  reply	other threads:[~2021-03-24 20:38 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08 20:03 bug#47012: xref copies keymap properties to minibuffer Juri Linkov
2021-03-09  2:08 ` Dmitry Gutov
2021-03-11 20:58   ` Juri Linkov
2021-03-24 20:38     ` Juri Linkov [this message]
2021-03-24 21:57       ` Dmitry Gutov
2021-03-25  9:40         ` Juri Linkov
2021-03-25 10:57           ` Dmitry Gutov
2021-03-25 21:28             ` Juri Linkov
2021-03-25 22:12               ` Dmitry Gutov
2021-03-30 19:16                 ` Juri Linkov
2021-03-31 15:47                   ` Dmitry Gutov
2021-03-31 15:59                     ` Eli Zaretskii
2021-03-31 16:10                       ` Dmitry Gutov
2021-03-31 16:57                         ` Eli Zaretskii
2021-04-01  0:25                           ` Dmitry Gutov
2021-04-01  7:17                             ` Eli Zaretskii
2021-03-31 17:05                     ` Juri Linkov
2021-04-01  1:16                       ` Dmitry Gutov
2021-04-01  8:43                         ` Juri Linkov
2021-04-01 14:13                           ` Dmitry Gutov
2021-04-01 18:45                             ` Juri Linkov
2021-04-01 19:06                               ` Eli Zaretskii
2021-04-01 21:28                                 ` Dmitry Gutov
2021-04-02  6:08                                   ` Eli Zaretskii
2021-04-02 23:50                                     ` Dmitry Gutov
2021-04-03  7:24                                       ` Eli Zaretskii
2021-04-03 18:12                                         ` Dmitry Gutov
2021-04-03 18:19                                           ` Eli Zaretskii
2021-04-02  8:20                                 ` Juri Linkov
2021-04-01 22:43                               ` Dmitry Gutov
2021-04-02  8:25                                 ` Juri Linkov
2021-04-02 23:23                                   ` Dmitry Gutov
2021-04-04 22:55                                     ` Juri Linkov
2021-04-05  2:15                                       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg4kb839.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=47012@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).