From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 47012@debbugs.gnu.org
Subject: bug#47012: xref copies keymap properties to minibuffer
Date: Thu, 11 Mar 2021 22:58:44 +0200 [thread overview]
Message-ID: <87a6r9v24b.fsf@mail.linkov.net> (raw)
In-Reply-To: <87czw9tnu9.fsf@mail.linkov.net>
>> 0. emacs -Q
>> 1. C-x p g expose_frame RET
>> 2. put point e.g. on "tab_bar_window"
>> 3. C-x p g M-n
>> 4. click mouse on the default value
>> Instead of moving point to the clicked position, it visits the xref hit.
>> This is because the copied default value is not stripped from the
>> text property 'keymap'.
>> I noticed this problem after adding RET binding to xref--button-map,
>> so typing RET on the default value doesn't accept it for new search,
>> but uses its local keymap to visit old reference.
>
> Thanks for the report, should now be fixed in master, commit 8538108132836.
Confirmed, thanks.
> FWIW, it's was project.el's problem, not xref's.
I thought it's the xref's problem because Help says it's in xref.el.
Typing 'C-h f project--read-regexp RET' shows:
project--read-regexp is a Lisp function in ‘xref.el’.
But this is because I tried to override this function in the init file:
;; Redefine to use `minibuffer-history':
(with-eval-after-load 'project
(defun project--read-regexp ()
(let ((sym (thing-at-point 'symbol t)))
(read-regexp "Find regexp"
(and sym (regexp-quote sym))
'minibuffer-history))))
Oh, well, need to find another way to do this
(no feature request for this :-)
next prev parent reply other threads:[~2021-03-11 20:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 20:03 bug#47012: xref copies keymap properties to minibuffer Juri Linkov
2021-03-09 2:08 ` Dmitry Gutov
2021-03-11 20:58 ` Juri Linkov [this message]
2021-03-24 20:38 ` Juri Linkov
2021-03-24 21:57 ` Dmitry Gutov
2021-03-25 9:40 ` Juri Linkov
2021-03-25 10:57 ` Dmitry Gutov
2021-03-25 21:28 ` Juri Linkov
2021-03-25 22:12 ` Dmitry Gutov
2021-03-30 19:16 ` Juri Linkov
2021-03-31 15:47 ` Dmitry Gutov
2021-03-31 15:59 ` Eli Zaretskii
2021-03-31 16:10 ` Dmitry Gutov
2021-03-31 16:57 ` Eli Zaretskii
2021-04-01 0:25 ` Dmitry Gutov
2021-04-01 7:17 ` Eli Zaretskii
2021-03-31 17:05 ` Juri Linkov
2021-04-01 1:16 ` Dmitry Gutov
2021-04-01 8:43 ` Juri Linkov
2021-04-01 14:13 ` Dmitry Gutov
2021-04-01 18:45 ` Juri Linkov
2021-04-01 19:06 ` Eli Zaretskii
2021-04-01 21:28 ` Dmitry Gutov
2021-04-02 6:08 ` Eli Zaretskii
2021-04-02 23:50 ` Dmitry Gutov
2021-04-03 7:24 ` Eli Zaretskii
2021-04-03 18:12 ` Dmitry Gutov
2021-04-03 18:19 ` Eli Zaretskii
2021-04-02 8:20 ` Juri Linkov
2021-04-01 22:43 ` Dmitry Gutov
2021-04-02 8:25 ` Juri Linkov
2021-04-02 23:23 ` Dmitry Gutov
2021-04-04 22:55 ` Juri Linkov
2021-04-05 2:15 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6r9v24b.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=47012@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).