From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#47012: xref copies keymap properties to minibuffer Date: Tue, 30 Mar 2021 22:16:07 +0300 Organization: LINKOV.NET Message-ID: <87pmzgtr80.fsf@mail.linkov.net> References: <87czw9tnu9.fsf@mail.linkov.net> <3aad442a-7319-5db5-2fc6-560bb032c34d@yandex.ru> <87a6r9v24b.fsf@mail.linkov.net> <87sg4kb839.fsf@mail.linkov.net> <871rc3bls6.fsf@mail.linkov.net> <871rc2ly7x.fsf@mail.linkov.net> <4228b128-039c-2bcd-002c-5ac830d7a4d3@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35520"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 47012@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 30 21:25:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRJzE-00098d-Dd for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Mar 2021 21:25:12 +0200 Original-Received: from localhost ([::1]:43002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRJzD-0008H2-BG for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Mar 2021 15:25:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRJz4-0008Fq-CW for bug-gnu-emacs@gnu.org; Tue, 30 Mar 2021 15:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41317) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lRJz4-0000Pw-5M for bug-gnu-emacs@gnu.org; Tue, 30 Mar 2021 15:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lRJz4-0002KB-0r for bug-gnu-emacs@gnu.org; Tue, 30 Mar 2021 15:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Mar 2021 19:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47012 X-GNU-PR-Package: emacs Original-Received: via spool by 47012-submit@debbugs.gnu.org id=B47012.16171322908895 (code B ref 47012); Tue, 30 Mar 2021 19:25:01 +0000 Original-Received: (at 47012) by debbugs.gnu.org; 30 Mar 2021 19:24:50 +0000 Original-Received: from localhost ([127.0.0.1]:52859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRJys-0002JO-15 for submit@debbugs.gnu.org; Tue, 30 Mar 2021 15:24:50 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:47169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRJyq-0002J7-Cj for 47012@debbugs.gnu.org; Tue, 30 Mar 2021 15:24:49 -0400 X-Originating-IP: 91.129.107.223 Original-Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 0CECDE000C; Tue, 30 Mar 2021 19:24:40 +0000 (UTC) In-Reply-To: <4228b128-039c-2bcd-002c-5ac830d7a4d3@yandex.ru> (Dmitry Gutov's message of "Fri, 26 Mar 2021 00:12:21 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203326 Archived-At: >>> (defvar project-regexp-history-variable 'grep-regexp-history) >>> >>> will be good enough. >> This would a good thing to do. > > Let's go with this one, then. At least for now. > > Meaning, your patch plus a change of the default value to > 'grep-regexp-history. Now patch is pushed. BTW, it was a big hassle to use project-find-regexp until I realized where is the problem. There is no such problem in grep because in the grep output file names are placed separately on the left, and output lines are on the right on the same lines. So it's easy to scan output lines visually. But the output of project-find-regexp is a mess because output lines are interspersed with file names where output lines are almost indistinguishable from file lines. Indeed, file names are currently highlighted in green color, but such green foreground doesn't help to distinguish file names from output lines, so it's very hard to read the output. Then I realized that this problem is already solved in diff-mode where the faces 'diff-header' and 'diff-file-header' use the grey background to separate diff hunks. Using the same solution of 'diff-header' and 'diff-file-header' for 'xref-file-header' improves the readability significantly: #+begin_src diff diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index ea52befec5..f2aa8bfba4 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -513,7 +513,7 @@ xref-pop-to-location (defconst xref-buffer-name "*xref*" "The name of the buffer to show xrefs.") -(defface xref-file-header '((t :inherit compilation-info)) +(defface xref-file-header '((t :background "grey90" :extend t)) "Face used to highlight file header in the xref buffer." :version "27.1") #+end_src