unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 47012@debbugs.gnu.org
Subject: bug#47012: xref copies keymap properties to minibuffer
Date: Thu, 25 Mar 2021 23:28:34 +0200	[thread overview]
Message-ID: <871rc2ly7x.fsf@mail.linkov.net> (raw)
In-Reply-To: <f907c58c-5f48-7c47-a1a4-486311773c7e@yandex.ru> (Dmitry Gutov's message of "Thu, 25 Mar 2021 12:57:19 +0200")

>> Sharing regexp history between grep and project-find-regexp would be
>> the most desirable.  How better to achieve this?
>
> Either by using 'grep-regexp-history directly, or with either of the
> options below.
>
>> Some commands already use variable *-history-variable, so adding
>> project-regexp-history-variable wouldn't cause a new precedent.
>
> Could you give an example?

What I tried is C-h v *-history-variable TAB

  minibuffer-history-variable
  query-replace-from-history-variable
  query-replace-to-history-variable
  y-or-n-p-history-variable

Maybe other commands use another suffix (probably not).

> And ideally, we should be also able to answer the question why some
> packages have their own variables, and others have "-variable variables".

I don't know.

> If it's just historical reasons, as it often is, maybe
>
>   (defvar project-regexp-history-variable 'grep-regexp-history)
>
> will be good enough.

This would a good thing to do.

>> Whereas using defalias is something new, maybe it could work too:
>>    (defalias 'grep-regexp-history 'project-regexp-history)
>
> Yup, that's what I meant. It does feel a bit hackish, though.
>
> Another possible approach would be some categories based system, together
> with user customization, like completion-category-overrides, but it's
> probably overkill for this problem.

I agree on both these statements.





  reply	other threads:[~2021-03-25 21:28 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08 20:03 bug#47012: xref copies keymap properties to minibuffer Juri Linkov
2021-03-09  2:08 ` Dmitry Gutov
2021-03-11 20:58   ` Juri Linkov
2021-03-24 20:38     ` Juri Linkov
2021-03-24 21:57       ` Dmitry Gutov
2021-03-25  9:40         ` Juri Linkov
2021-03-25 10:57           ` Dmitry Gutov
2021-03-25 21:28             ` Juri Linkov [this message]
2021-03-25 22:12               ` Dmitry Gutov
2021-03-30 19:16                 ` Juri Linkov
2021-03-31 15:47                   ` Dmitry Gutov
2021-03-31 15:59                     ` Eli Zaretskii
2021-03-31 16:10                       ` Dmitry Gutov
2021-03-31 16:57                         ` Eli Zaretskii
2021-04-01  0:25                           ` Dmitry Gutov
2021-04-01  7:17                             ` Eli Zaretskii
2021-03-31 17:05                     ` Juri Linkov
2021-04-01  1:16                       ` Dmitry Gutov
2021-04-01  8:43                         ` Juri Linkov
2021-04-01 14:13                           ` Dmitry Gutov
2021-04-01 18:45                             ` Juri Linkov
2021-04-01 19:06                               ` Eli Zaretskii
2021-04-01 21:28                                 ` Dmitry Gutov
2021-04-02  6:08                                   ` Eli Zaretskii
2021-04-02 23:50                                     ` Dmitry Gutov
2021-04-03  7:24                                       ` Eli Zaretskii
2021-04-03 18:12                                         ` Dmitry Gutov
2021-04-03 18:19                                           ` Eli Zaretskii
2021-04-02  8:20                                 ` Juri Linkov
2021-04-01 22:43                               ` Dmitry Gutov
2021-04-02  8:25                                 ` Juri Linkov
2021-04-02 23:23                                   ` Dmitry Gutov
2021-04-04 22:55                                     ` Juri Linkov
2021-04-05  2:15                                       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rc2ly7x.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=47012@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).