bug#63141: Incorrect indentation in csharp-mode

bug#63141: Incorrect indentation in csharp-mode

[Jen-Chieh Shen]

[-- Attachment #1: Type: text/plain, Size: 25594 bytes --]

It seems like there is an indentation error with the following C# code:

```csharp
public class Foo {
    [Header("")]

        [Tooltip("")]
        [SerializeField]
        private Block mBlockUp = null;
}
```

expected behavior:

```csharp
public class Foo {
    [Header("")]

    [Tooltip("")]
    [SerializeField]
    private Block mBlockUp = null;
}
```

I've tested this bug with emacs -q, and the bug persists.


In GNU Emacs 29.0.60 (build 1, x86_64-w64-mingw32) of 2023-03-10 built
 on AVALON
Repository revision: 6fe9075ff3814ce825c9869c901903edad9d0b44
Repository branch: emacs-29
Windowing system distributor 'Microsoft Corp.', version 10.0.22621
System Description: Microsoft Windows 10 Home (v10.0.2009.22621.1635)

Configured using:
 'configure --with-modules --without-dbus --with-native-compilation
 --without-compress-install --with-tree-sitter CFLAGS=-O2'

Configured features:
ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP
NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB

(NATIVE_COMP present but libgccjit not available)

Important settings:
  value of $LANG: ENU
  locale-coding-system: cp1252

Major mode: C#//l

Minor modes in effect:
  vc-refresh-mode: t
  editorconfig-mode: t
  global-diff-hl-mode: t
  diff-hl-mode: t
  windmove-mode: t
  undo-tree-vf-mode: t
  global-undo-tree-mode: t
  undo-tree-mode: t
  sideline-mode: t
  lsp-modeline-workspace-status-mode: t
  dap-tooltip-mode: t
  dap-ui-many-windows-mode: t
  dap-ui-controls-mode: t
  dap-ui-mode: t
  lsp-ui-mode: t
  lsp-ui-doc-mode: t
  highlight-doxygen-mode: t
  ts-docstr-mode: t
  ts-fold-indicators-mode: t
  ts-fold-line-comment-mode: t
  ts-fold-mode: t
  vs-electric-spacing-mode: t
  treemacs-filewatch-mode: t
  treemacs-follow-mode: t
  treemacs-git-mode: t
  treemacs-fringe-indicator-mode: t
  dap-auto-configure-mode: t
  dap-mode: t
  lsp-mode: t
  global-so-long-mode: t
  tree-sitter-hl-mode: t
  global-tree-sitter-mode: t
  tree-sitter-mode: t
  npm-global-mode: t
  npm-mode: t
  auto-read-only-mode: t
  flycheck-mode: t
  region-state-mode: t
  nerd-icons-buffer-menu-mode: t
  buffer-menu-filter-mode: t
  whole-line-or-region-global-mode: t
  whole-line-or-region-local-mode: t
  global-whitespace-cleanup-mode: t
  whitespace-cleanup-mode: t
  which-key-mode: t
  vs-revbuf-mode: t
  repos-window-mode: t
  global-region-occurrences-highlighter-mode: t
  region-occurrences-highlighter-mode: t
  recentf-excl-mode: t
  global-page-break-lines-mode: t
  minibuffer-depth-indicate-mode: t
  message-clean-mode: t
  global-goto-address-mode: t
  goto-address-mode: t
  gcmh-mode: t
  ff-guard-mode: t
  eval-mark-mode: t
  electric-indent-sexp-mode: t
  diminish-buffer-mode: t
  delete-selection-mode: t
  balanced-windows-mode: t
  marginalia-mode: t
  vertico-multiform-mode: t
  vertico-flx-mode: t
  vertico-mode: t
  right-click-context-mode: t
  jcs-modeline-mode: t
  minions-mode: t
  jcs-frametitle-mode: t
  jcs-echobar-mode: t
  echo-bar-mode: t
  global-hl-todo-mode: t
  hl-todo-mode: t
  global-hl-line-mode: t
  company-fuzzy-mode: t
  vs-comment-return-mode: t
  vsc-edit-mode: t
  yas-minor-mode: t
  company-box-mode: t
  global-company-mode: t
  company-mode: t
  indent-control-mode: t
  electric-pair-mode: t
  vs-edit-mode: t
  highlight-numbers-mode: t
  highlight-indent-guides-mode: t
  doxygen-asterisk-mode: t
  indicators-mode: t
  line-reminder-mode: t
  display-line-numbers-mode: t
  display-fill-column-indicator-mode: t
  auto-highlight-symbol-mode: t
  alt-codes-mode: t
  recentf-mode: t
  override-global-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  window-divider-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
c:/Users/JenChieh/AppData/Roaming/.emacs.d/elpa/emacsql-psql-20230225.2205/emacsql-psql
hides
c:/Users/JenChieh/AppData/Roaming/.emacs.d/elpa/emacsql-20230417.1448/emacsql-psql
c:/Users/JenChieh/AppData/Roaming/.emacs.d/elpa/emacsql-mysql-20230225.2205/emacsql-mysql
hides
c:/Users/JenChieh/AppData/Roaming/.emacs.d/elpa/emacsql-20230417.1448/emacsql-mysql
c:/Users/JenChieh/AppData/Roaming/.emacs.d/elpa/transient-20230315.1520/transient
hides c:/Program
Files/Emacs/emacs-29.0.60/share/emacs/29.0.60/lisp/transient
c:/Users/JenChieh/AppData/Roaming/.emacs.d/elpa/less-css-mode-20161001.453/less-css-mode
hides c:/Program
Files/Emacs/emacs-29.0.60/share/emacs/29.0.60/lisp/textmodes/less-css-mode
c:/Users/JenChieh/AppData/Roaming/.emacs.d/elpa/csharp-mode-20221126.2005/csharp-mode
hides c:/Program
Files/Emacs/emacs-29.0.60/share/emacs/29.0.60/lisp/progmodes/csharp-mode

Features:
(shadow sort mail-extr emacsbug message yank-media rfc822 mml mml-sec
epa gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr ts-docstr-c++ editorconfig-conf-mode editorconfig-generate
two-column csharp-tree-sitter tree-sitter-indent misearch multi-isearch
better-scroll elisp-def elisp-demos shortdoc cl-print help-fns
radix-tree vc-git gitignore-templates git-modes gitignore-mode
gitconfig-mode conf-mode gitattributes-mode vc-refresh editorconfig
editorconfig-core editorconfig-core-handle editorconfig-fnmatch diff-hl
log-view pcvs-util vc-dir vc vc-dispatcher diff-mode buffer-wrap
toggle-profiler profiler mule-util block-travel buffer-move windmove
undo-tree-vf fill-page undo-tree diff queue sideline-flymake
sideline-lsp sideline-color flycheck-grammarly flycheck-languagetool
flycheck-cask flycheck-eask flycheck-elsa flycheck-package package-lint
let-alist flycheck-relint relint xr sideline-flycheck sideline rect
flycheck-clang-analyzer flycheck-deno flycheck-haskell lsp-diagnostics
lsp-headerline lsp-icons lsp-modeline dap-mouse dap-ui gdb-mi gud bui
bui-list bui-info bui-entry bui-core bui-history bui-button bui-utils
lsp-ui lsp-ui-flycheck lsp-ui-doc lsp-ui-imenu lsp-ui-peek
lsp-ui-sideline lsp-ui-util lsp-zig lsp-tilt lsp-steep lsp-svelte
lsp-sqls lsp-ruby-syntax-tree lsp-ruby-lsp lsp-yaml lsp-xml
lsp-vimscript lsp-vhdl lsp-volar lsp-vetur lsp-html lsp-verilog lsp-vala
lsp-v lsp-typeprof lsp-ttcn3 lsp-toml lsp-tex lsp-tailwindcss
lsp-sonarlint shr pixel-fill kinsoku url-file svg cus-edit lsp-sourcekit
lsp lsp-sorbet lsp-solargraph lsp-rust lsp-rf lsp-ruff-lsp lsp-remark
lsp-racket lsp-r lsp-purescript lsp-pyright lsp-pylsp lsp-pyls lsp-pwsh
lsp-php lsp-pls lsp-perlnavigator lsp-perl lsp-pascal lsp-openscad
lsp-ocaml lsp-mssql lsp-metals view lsp-metals-treeview
treemacs-extensions treemacs-mouse-interface treemacs-tags
lsp-metals-protocol lsp-magik lsp-nix lsp-nim lsp-nginx lsp-mint
lsp-marksman lsp-markdown lsp-lua lsp-ltex github-tags lsp-latex
lsp-kotlin lsp-json lsp-javascript dap-java lsp-java lsp-idris lsp-haxe
lsp-haskell haskell-mode haskell-cabal haskell-utils haskell-font-lock
haskell-indentation haskell-string haskell-sort-imports haskell-lexeme
haskell-align-imports haskell-complete-module haskell-ghc-support
dabbrev haskell-customize lsp-groovy lsp-grammarly grammarly websocket
bindat request mailheader mail-utils lsp-hack lsp-graphql lsp-glsl
lsp-gleam lsp-go lsp-completion lsp-gdscript lsp-fsharp lsp-fortran
lsp-eslint lsp-erlang lsp-emmet lsp-elixir lsp-elm lsp-dockerfile
lsp-dhall lsp-d lsp-css lsp-csharp gnutls lsp-crystal lsp-cmake
lsp-clojure lsp-semantic-tokens lsp-clangd lsp-beancount lsp-bash
lsp-astro lsp-ansible lsp-angular lsp-ada lsp-actionscript ccls
ccls-member-hierarchy ccls-inheritance-hierarchy ccls-call-hierarchy
ccls-tree ccls-code-lens ccls-semantic-highlight ccls-common
highlight-doxygen ts-docstr-key ts-docstr-csharp ts-docstr refine loop
ts-fold-indicators ts-fold ts-fold-summary ts-fold-parsers ts-fold-util
company-clang company-kaomoji kaomoji kaomoji-data vs-electric-spacing
typescript-mode csharp-mode csharp-compilation cc-langs lsp-dart
lsp-dart-commands lsp-dart-flutter-widget-guide
lsp-dart-flutter-fringe-colors lsp-dart-flutter-colors lsp-dart-outline
lsp-dart-code-lens lsp-lens lsp-dart-test-tree lsp-treemacs
lsp-treemacs-generic lsp-treemacs-themes treemacs-treelib
treemacs-nerd-icons treemacs treemacs-header-line treemacs-compatibility
treemacs-mode treemacs-interface treemacs-persistence
treemacs-filewatch-mode treemacs-follow-mode treemacs-rendering
treemacs-annotations treemacs-async treemacs-workspaces treemacs-dom
treemacs-visuals treemacs-fringe-indicator pulse treemacs-faces
treemacs-icons treemacs-scope treemacs-themes treemacs-core-utils
pfuture treemacs-logging treemacs-customization treemacs-macros
lsp-dart-test-output lsp-dart-test-support lsp-dart-dap
lsp-dart-devtools lsp-dart-flutter-daemon jsonrpc ert debug backtrace
dap-utils xml dap-mode dap-tasks dap-launch lsp-docker yaml posframe
dap-overlays lsp-dart-closing-labels lsp-dart-utils lsp-dart-protocol
lsp-mode lsp-protocol spinner network-stream puny nsm expand-region
text-mode-expansions cc-mode-expansions web-mode-expansions
html-mode-expansions er-basic-expansions expand-region-core
expand-region-custom htmltagwrap emmet-mode cl auto-rename-tag
impatient-mode htmlize simple-httpd php-mode mode-local speedbar ezimage
dframe company-c-headers cc-mode cc-fonts cc-guess cc-menus cc-cmds
cc-styles cc-align php-face php php-project flymake-proc flymake
cc-engine cc-vars cc-defs sgml-mode facemenu dom web-mode markdown-mode
edit-indirect noutline outline lv inline imenu filenotify ewoc epg
rfc6068 epg-config so-long tree-sitter-langs tree-sitter-langs-build
tar-mode arc-mode archive-mode pp tree-sitter-hl tree-sitter
tree-sitter-load tree-sitter-cli tsc tsc-dyn tsc-dyn-get compile
text-property-search comint ansi-osc dired-aux dired dired-loaddefs
tsc-obsolete npm-mode auto-read-only vertico-directory cus-start
cus-load flycheck ansi-color time-date region-state
nerd-icons-buffer-menu buffer-menu-filter buffer-menu-project
whole-line-or-region whitespace-cleanup-mode whitespace which-key
vs-revbuf fextern repos-window region-occurrences-highlighter hi-lock
recentf-excl page-break-lines mb-depth message-clean-mode goto-addr gcmh
ff-guard eval-mark electric-indent-sexp diminish-buffer delsel
company-yasnippet company-gtags company-etags etags fileloop generator
xref ring company-paths company-files company-dabbrev-code
company-dabbrev company-elisp-keywords finder finder-inf find-func
lisp-mnt company-abbrev company-dict company-keywords company-semantic
company-template company-capf balanced-windows marginalia time
list-utils jcs-edit vertico-multiform vertico-flx flx-style flx-rs-core
flx-rs flx mbs vertico right-click-context ordinal popup jcs-modeline
nerd-icons nerd-icons-faces nerd-icons-data-material-design
nerd-icons-data-font-logos nerd-icons-data-codicons
nerd-icons-data-devicons nerd-icons-data-seti-ui-custom
nerd-icons-data-weather-icons nerd-icons-data-font-awesome
nerd-icons-data-powerline nerd-icons-data-octicons
nerd-icons-data-pomicons nerd-icons-data-iec-power-symbols minions moody
jcs-frametitle jcs-echobar keycast format-spec show-eol echo-bar hl-todo
compat hl-line auto-scroll-bar eask-api company-fuzzy f f-shortdoc s
vs-comment-return vsc-edit-mode yasnippet-snippets yasnippet company-box
company-box-icons company-box-doc face-remap company-box-util
frame-local asoc company mwim indent-control elec-pair vs-edit-mode
highlight-numbers parent-mode highlight-indent-guides advice color
doxygen-asterisk indicators line-reminder ov fringe-helper
display-line-numbers display-fill-column-indicator auto-highlight-symbol
ht alt-codes vs-dark-theme use-ttf on dashboard-ls project dashboard
dashboard-widgets recentf tree-widget wid-edit ffap file-header
thingatpt jcs-key jcs-hook comp comp-cstr warnings icons jcs-module
jcs-project noflet cl-indent dash jcs-template jcs-theme jcs-ui jcs-disp
jcs-env edmacro kmacro use-package-bind-key bind-key easy-mmode
jcs-function jcs-window jcs-util jcs-log msgu jcs-package pkg-dm elenv
cl-extra help-mode use-package-ensure use-package-core
zoom-window-autoloads zig-mode-autoloads yuck-mode-autoloads
yasnippet-snippets-autoloads yarn-mode-autoloads winum-autoloads
whole-line-or-region-autoloads whitespace-cleanup-mode-autoloads
which-key-autoloads web-mode-autoloads wat-mode-autoloads
vue-mode-autoloads vue-html-mode-autoloads
vsc-multiple-cursors-autoloads vsc-edit-mode-autoloads
yasnippet-autoloads vs-revbuf-autoloads vs-light-theme-autoloads
vs-electric-spacing-autoloads vs-edit-mode-autoloads
vs-dark-theme-autoloads vs-comment-return-autoloads
visual-regexp-autoloads visual-basic-mode-autoloads vimrc-mode-autoloads
vertico-flx-autoloads vertico-autoloads vc-refresh-autoloads
vbscript-mode-autoloads vbs-repl-autoloads use-ttf-autoloads
unfill-autoloads undo-tree-vf-autoloads undo-tree-autoloads
typescript-mode-autoloads turbo-log-autoloads ts-fold-autoloads
ts-docstr-autoloads treemacs-nerd-icons-autoloads
tree-sitter-langs-autoloads tree-sitter-indent-autoloads
transwin-autoloads transpose-frame-autoloads topsy-autoloads
toggle-window-autoloads toggle-profiler-autoloads togetherly-autoloads
toc-org-autoloads terminal-here-autoloads swift-mode-autoloads
suggest-autoloads ssh-config-mode-autoloads ssass-mode-autoloads
sql-indent-autoloads sort-words-autoloads snow-autoloads smex-autoloads
smart-comment-autoloads sln-mode-autoloads site-lisp-autoloads
sideline-lsp-autoloads sideline-flymake-autoloads
sideline-flycheck-autoloads sideline-color-autoloads
sideline-blame-autoloads vc-msg-autoloads sideline-autoloads
shrink-whitespace-autoloads shift-number-autoloads shell-pop-autoloads
shader-mode-autoloads scss-mode-autoloads
scrollable-quick-peek-autoloads scad-mode-autoloads rust-mode-autoloads
robots-txt-mode-autoloads right-click-context-autoloads
reveal-in-folder-autoloads restart-emacs-autoloads
repos-window-autoloads region-state-autoloads
region-occurrences-highlighter-autoloads refine-autoloads
rainbow-mode-autoloads racket-mode-autoloads quickrun-autoloads
quick-peek-autoloads queue-autoloads quelpa-autoloads qml-mode-autoloads
python-mode-autoloads purescript-mode-autoloads protobuf-mode-autoloads
project-abbrev-autoloads processing-mode-autoloads prettier-autoloads
powershell-autoloads pkgbuild-mode-autoloads pkg-dm-autoloads
recentf-excl-autoloads prt-autoloads pip-requirements-autoloads
phpt-mode-autoloads polymode-autoloads php-mode-autoloads
password-mode-autoloads password-generator-autoloads parse-it-autoloads
pangu-spacing-autoloads page-break-lines-autoloads
package-build-autoloads derived organize-imports-java-autoloads
org-superstar-autoloads org-sticky-header-autoloads
org-fancy-priorities-autoloads ordinal-autoloads on-autoloads
nvm-autoloads npm-mode-autoloads nov-autoloads nocomments-mode-autoloads
nix-mode-autoloads ninja-mode-autoloads nim-mode-autoloads
nginx-mode-autoloads nerd-icons-ibuffer-autoloads
nerd-icons-dired-autoloads nerd-icons-buffer-menu-autoloads
noflet-autoloads nasm-mode-autoloads mwim-autoloads
multiple-cursors-autoloads multi-shell-autoloads move-text-autoloads
most-used-words-autoloads mmm-mode-autoloads mint-mode-autoloads
minimap-autoloads meta-view-autoloads message-clean-mode-autoloads
meson-mode-autoloads mbs-autoloads masm-mode-autoloads
markdown-toc-autoloads marginalia-autoloads
manage-minor-mode-table-autoloads manage-minor-mode-autoloads
makefile-executor-autoloads magit-todos-autoloads pcre2el-autoloads
lsp-tailwindcss-autoloads lsp-sourcekit-autoloads
lsp-sonarlint-autoloads lsp-pyright-autoloads lsp-pascal-autoloads
lsp-mssql-autoloads lsp-metals-autoloads scala-mode-autoloads
lsp-ltex-autoloads lsp-latex-autoloads lsp-julia-autoloads
lsp-java-autoloads lsp-haskell-autoloads lsp-grammarly-autoloads
lsp-dart-autoloads logview-autoloads logms-autoloads log4e-autoloads
literate-calc-mode-autoloads list-utils-autoloads
list-environment-autoloads line-reminder-autoloads ov-autoloads
license-templates-autoloads kubernetes-autoloads kotlin-mode-autoloads
keypression-autoloads kconfig-mode-autoloads k8s-mode-autoloads
julia-mode-autoloads json-mode-autoloads json-snatcher-autoloads
jenkinsfile-mode-autoloads jcs-poptip-autoloads preview-it-autoloads
lsp-ui-autoloads jcs-modeline-autoloads nerd-icons-autoloads
minions-autoloads moody-autoloads jcs-frametitle-autoloads
jcs-echobar-autoloads keycast-autoloads show-eol-autoloads
jayces-mode-autoloads javap-mode-autoloads javadoc-lookup-autoloads
jai-mode-autoloads iter2-autoloads isearch-project-autoloads
ini-mode-autoloads indicators-autoloads indent-control-autoloads
impatient-showdown-autoloads impatient-mode-autoloads
simple-httpd-autoloads iedit-autoloads idris-mode-autoloads
prop-menu-autoloads ialign-autoloads htmltagwrap-autoloads
htmlize-autoloads hlsl-mode-autoloads hl-todo-autoloads
hl-preproc-autoloads highlight-numbers-autoloads
highlight-indent-guides-autoloads highlight-escape-sequences-autoloads
highlight-doxygen-autoloads hgignore-mode-autoloads hexo-autoloads
helpful-autoloads helafy-autoloads haxe-mode-autoloads hammy-autoloads
ts-autoloads haml-mode-autoloads groovy-mode-autoloads
graphql-mode-autoloads goto-line-preview-autoloads
goto-last-change-autoloads goto-char-preview-autoloads
google-this-autoloads gl-conf-mode-autoloads
gitlab-ci-mode-flycheck-autoloads gitlab-ci-mode-autoloads
gitignore-templates-autoloads github-tags-autoloads
github-browse-file-autoloads git-modes-autoloads git-link-autoloads
git-assembler-mode-autoloads gh-md-autoloads gdscript-mode-autoloads
gcmh-autoloads fvwm-mode-autoloads fsharp-mode-autoloads
fringe-helper-autoloads freeradius-mode-autoloads free-keys-autoloads
fountain-mode-autoloads forge-autoloads magit-autoloads pcase
magit-section-autoloads git-commit-autoloads with-editor-autoloads
ghub-autoloads treepy-autoloads font-lock-ext-autoloads fof-autoloads
flymake-shell-autoloads flymake-ruby-autoloads flymake-racket-autoloads
flymake-php-autoloads flymake-nasm-autoloads flymake-quickdef-autoloads
flymake-lua-autoloads flymake-less-autoloads less-css-mode-autoloads
flymake-haml-autoloads flymake-coffee-autoloads flymake-easy-autoloads
flycheck-swift-autoloads flycheck-relint-autoloads relint-autoloads
xr-autoloads flycheck-package-autoloads package-lint-autoloads
flycheck-ocaml-autoloads merlin-autoloads flycheck-nimsuggest-autoloads
flycheck-nim-autoloads flycheck-languagetool-autoloads
flycheck-kotlin-autoloads flycheck-haskell-autoloads
haskell-mode-autoloads flycheck-grammarly-autoloads grammarly-autoloads
websocket-autoloads flycheck-golangci-lint-autoloads
flycheck-elsa-autoloads flycheck-elm-autoloads flycheck-eask-autoloads
flycheck-deno-autoloads flycheck-crystal-autoloads
flycheck-clang-analyzer-autoloads flycheck-cask-autoloads
flycheck-autoloads pkg-info-autoloads flx-style-autoloads
flx-rs-autoloads fish-mode-autoloads fill-page-autoloads
file-header-autoloads ff-guard-autoloads fextern-autoloads
feature-mode-autoloads expand-region-autoloads execrun-autoloads
ffpc-autoloads exec-path-from-shell-autoloads eval-mark-autoloads
esxml-autoloads kv-autoloads esup-autoloads ess-autoloads
eshell-syntax-highlighting-autoloads eros-autoloads erlang-autoloads
epl-autoloads eping-autoloads epc-autoloads emp-autoloads
sound-async-autoloads emoji-github-autoloads emmet-mode-autoloads
emacsql-psql-autoloads emacsql-mysql-autoloads elm-mode-autoloads
reformatter-autoloads elixir-mode-autoloads elisp-refs-autoloads
elisp-demos-autoloads elisp-def-autoloads elfeed-autoloads
elenv-autoloads electric-indent-sexp-autoloads electric-cursor-autoloads
eldoc-toml-autoloads eldoc-meta-net-autoloads eldoc-eask-autoloads
eldoc-cmake-autoloads editorconfig-generate-autoloads
editorconfig-autoloads edit-indirect-autoloads echo-bar-autoloads
easky-autoloads marquee-header-autoloads eask-mode-autoloads
earthfile-mode-autoloads dumb-jump-autoloads doxygen-asterisk-autoloads
dotenv-mode-autoloads docker-compose-mode-autoloads yaml-mode-autoloads
docker-autoloads transient-autoloads dist-file-mode-autoloads
diredfl-autoloads diminish-buffer-autoloads diff-hl-autoloads
define-it-autoloads wiki-summary-autoloads google-translate-autoloads
define-word-autoloads pos-tip-autoloads popup-autoloads
datetime-autoloads extmap-autoloads dashboard-ls-autoloads
dashboard-autoloads dart-mode-autoloads dap-mode-autoloads
lsp-docker-autoloads yaml-autoloads lsp-treemacs-autoloads
treemacs-autoloads hydra-autoloads pfuture-autoloads d-mode-autoloads
cycle-slash-autoloads cycle-quotes-autoloads cycle-case-style-autoloads
cycle-at-point-autoloads recomplete-autoloads ctable-autoloads
csv-mode-autoloads css-eldoc-autoloads csproj-mode-autoloads
csharp-mode-autoloads crystal-mode-autoloads consult-autoloads
concurrent-autoloads deferred-autoloads comware-router-mode-autoloads
composer-autoloads php-runtime-autoloads company-terraform-autoloads
terraform-mode-autoloads hcl-mode-autoloads company-sourcekit-autoloads
sourcekit-autoloads company-shell-autoloads company-restclient-autoloads
restclient-autoloads know-your-http-well-autoloads
company-powershell-autoloads company-paths-autoloads
company-org-block-autoloads company-nixos-options-autoloads
nixos-options-autoloads company-nginx-autoloads
company-meta-net-autoloads meta-net-autoloads company-makefile-autoloads
company-lua-autoloads lua-mode-autoloads company-kaomoji-autoloads
kaomoji-autoloads company-go-autoloads go-mode-autoloads
company-glsl-autoloads glsl-mode-autoloads company-fuzzy-autoloads
company-emojify-autoloads emojify-autoloads
company-elisp-keywords-autoloads company-eask-autoloads eask-autoloads
company-dockerfile-autoloads dockerfile-mode-autoloads
company-dict-autoloads parent-mode-autoloads company-coffee-autoloads
company-cmd-autoloads company-c-headers-autoloads company-box-autoloads
frame-local-autoloads company-autoconf-autoloads
company-ansible-autoloads company-autoloads commenter-autoloads
command-log-mode-autoloads com-css-sort-autoloads coffee-mode-autoloads
codemetrics-autoloads tree-sitter-autoloads tsc-autoloads
codegpt-autoloads cobol-mode-autoloads cmake-font-lock-autoloads
cmake-mode-autoloads closql-autoloads emacsql-autoloads compat-autoloads
clojure-mode-autoloads cisco-router-mode-autoloads chatgpt-autoloads
openai-autoloads tblui-autoloads tablist-autoloads magit-popup-autoloads
request-autoloads change-case-autoloads cfrs-autoloads
posframe-autoloads centaur-tabs-autoloads powerline-autoloads
ccls-autoloads lsp-mode-autoloads lv-autoloads markdown-mode-autoloads
cask-mode-autoloads cargo-mode-autoloads caml-autoloads calfw-autoloads
caddyfile-mode-autoloads loop-autoloads buttercup-autoloads
bui-autoloads buffer-wrap-autoloads buffer-move-autoloads
buffer-menu-filter-autoloads msgu-autoloads flx-autoloads
buffer-menu-project-autoloads browse-kill-ring-autoloads
block-travel-autoloads better-scroll-autoloads beancount-autoloads
basic-mode-autoloads banner-comment-autoloads balanced-windows-autoloads
autotetris-mode-autoloads auto-scroll-bar-autoloads
auto-rename-tag-autoloads auto-read-only-autoloads
auto-highlight-symbol-autoloads ht-autoloads
auth-source-keytar-autoloads keytar-autoloads
aurora-config-mode-autoloads async-autoloads asoc-autoloads
ascii-table-autoloads arduino-mode-autoloads ede/auto eieio-base
spinner-autoloads apt-sources-list-autoloads rx
applescript-mode-autoloads apache-mode-autoloads ansible-doc-autoloads
ansible-autoloads f-autoloads dash-autoloads ansi-autoloads
annotate-autoloads alt-codes-autoloads aio-autoloads adoc-mode-autoloads
adaptive-wrap-autoloads ada-mode-autoloads gnat-compiler-autoloads info
wisi-autoloads uniquify-files-autoloads actionscript-mode-autoloads
ace-window-autoloads avy-autoloads 0xc-autoloads s-autoloads package
browse-url url url-proxy url-privacy url-expand url-methods url-history
url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers
url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache
json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs
cl-lib early-init rmc iso-transl tooltip cconv eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel dos-w32
ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq
simple cl-generic indonesian philippine cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite emoji-zwj charscript charprop case-table
epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button
loaddefs theme-loaddefs faces cus-face macroexp files window
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget keymap hashtable-print-readable backquote threads
w32notify w32 lcms2 multi-tty make-network-process native-compile emacs)

Memory information:
((conses 16 1322045 296486)
 (symbols 48 83355 0)
 (strings 32 275305 46134)
 (string-bytes 1 9314125)
 (vectors 16 211013)
 (vector-slots 8 5128627 303882)
 (floats 8 2085 1005)
 (intervals 56 53625 13600)
 (buffers 984 41))

[-- Attachment #2: Type: text/html, Size: 27349 bytes --]

bug#63141: Incorrect indentation in csharp-mode

[Eli Zaretskii]

> From: Jen-Chieh Shen <jcs090218@gmail.com>
> Date: Fri, 28 Apr 2023 00:25:16 -0700
> 
> It seems like there is an indentation error with the following C# code:
> 
> ```csharp
> public class Foo {
>     [Header("")]
> 
>         [Tooltip("")]
>         [SerializeField]
>         private Block mBlockUp = null;
> }
> ```
> 
> expected behavior:
> 
> ```csharp
> public class Foo {
>     [Header("")]
> 
>     [Tooltip("")]
>     [SerializeField]
>     private Block mBlockUp = null;
> }
> ```
> 
> I've tested this bug with emacs -q, and the bug persists.

Theo, Jostein: could you please take a look?  csharp-ts-mode behaves
correctly with this code snippet, FWIW.  But csharp-mode doesn't.

bug#63141: Incorrect indentation in csharp-mode

[Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Jen-Chieh Shen <jcs090218@gmail.com>
>> Date: Fri, 28 Apr 2023 00:25:16 -0700
>> 
>> It seems like there is an indentation error with the following C# code:
>> 
>> ```csharp
>> public class Foo {
>>     [Header("")]
>> 
>>         [Tooltip("")]
>>         [SerializeField]
>>         private Block mBlockUp = null;
>> }
>> ```
>> 
>> expected behavior:
>> 
>> ```csharp
>> public class Foo {
>>     [Header("")]
>> 
>>     [Tooltip("")]
>>     [SerializeField]
>>     private Block mBlockUp = null;
>> }
>> ```
>> 
>> I've tested this bug with emacs -q, and the bug persists.
>
> Theo, Jostein: could you please take a look?  csharp-ts-mode behaves
> correctly with this code snippet, FWIW.  But csharp-mode doesn't.

Yep, I'll look at it immediately!

Thanks for the heads up :-)

Theo

bug#63141: Incorrect indentation in csharp-mode

[Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Theodor Thornhill <theo@thornhill.no> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Jen-Chieh Shen <jcs090218@gmail.com>
>>> Date: Fri, 28 Apr 2023 00:25:16 -0700
>>> 
>>> It seems like there is an indentation error with the following C# code:
>>> 
>>> ```csharp
>>> public class Foo {
>>>     [Header("")]
>>> 
>>>         [Tooltip("")]
>>>         [SerializeField]
>>>         private Block mBlockUp = null;
>>> }
>>> ```
>>> 
>>> expected behavior:
>>> 
>>> ```csharp
>>> public class Foo {
>>>     [Header("")]
>>> 
>>>     [Tooltip("")]
>>>     [SerializeField]
>>>     private Block mBlockUp = null;
>>> }
>>> ```
>>> 
>>> I've tested this bug with emacs -q, and the bug persists.
>>
>> Theo, Jostein: could you please take a look?  csharp-ts-mode behaves
>> correctly with this code snippet, FWIW.  But csharp-mode doesn't.
>
> Yep, I'll look at it immediately!
>
> Thanks for the heads up :-)
>
> Theo

I have a fix now. Is this for emacs-29 or master?

Theo

bug#63141: Incorrect indentation in csharp-mode

[Eli Zaretskii]

> From: Theodor Thornhill <theo@thornhill.no>
> Cc: 63141@debbugs.gnu.org
> Date: Fri, 28 Apr 2023 12:00:48 +0200
> 
> I have a fix now. Is this for emacs-29 or master?

This should go to emacs-29, since this mode is new in Emacs 29.

Thanks.

bug#63141: Incorrect indentation in csharp-mode

[Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Theodor Thornhill <theo@thornhill.no>
>> Cc: 63141@debbugs.gnu.org
>> Date: Fri, 28 Apr 2023 12:00:48 +0200
>> 
>> I have a fix now. Is this for emacs-29 or master?
>
> This should go to emacs-29, since this mode is new in Emacs 29.
>
> Thanks.

Ok!

bug#63141: Incorrect indentation in csharp-mode

[Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Theodor Thornhill <theo@thornhill.no> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Theodor Thornhill <theo@thornhill.no>
>>> Cc: 63141@debbugs.gnu.org
>>> Date: Fri, 28 Apr 2023 12:00:48 +0200
>>> 
>>> I have a fix now. Is this for emacs-29 or master?
>>
>> This should go to emacs-29, since this mode is new in Emacs 29.
>>
>> Thanks.
>
> Ok!

Now done

bug#63141: Incorrect indentation in csharp-mode

[Jen-Chieh Shen]

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

Another indentation issue:

```csharp

namespace UnityEditor.Accessibility
{
    internal enum ColorBlindCondition
        {
            Default,
            Deuteranopia,
            Protanopia,
            Tritanopia,
        }
}
```

expected behavior:

```csharp
namespace UnityEditor.Accessibility
{
    internal enum ColorBlindCondition
    {
        Default,
        Deuteranopia,
        Protanopia,
        Tritanopia,
    }
}
```

Not sure if this is a feature or a bug.

On Fri, Apr 28, 2023 at 5:02 AM Theodor Thornhill <theo@thornhill.no> wrote:

> Theodor Thornhill <theo@thornhill.no> writes:
>
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> >>> From: Theodor Thornhill <theo@thornhill.no>
> >>> Cc: 63141@debbugs.gnu.org
> >>> Date: Fri, 28 Apr 2023 12:00:48 +0200
> >>>
> >>> I have a fix now. Is this for emacs-29 or master?
> >>
> >> This should go to emacs-29, since this mode is new in Emacs 29.
> >>
> >> Thanks.
> >
> > Ok!
>
> Now done
>

[-- Attachment #2: Type: text/html, Size: 1868 bytes --]

bug#63141: Incorrect indentation in csharp-mode

[Eli Zaretskii]

> From: Jen-Chieh Shen <jcs090218@gmail.com>
> Date: Fri, 28 Apr 2023 12:26:00 -0700
> Cc: Eli Zaretskii <eliz@gnu.org>, 63141@debbugs.gnu.org, jostein@kjonigsen.net
> 
> Another indentation issue:
> 
> ```csharp
> 
> namespace UnityEditor.Accessibility
> {
>     internal enum ColorBlindCondition
>         {
>             Default,
>             Deuteranopia,
>             Protanopia,
>             Tritanopia,
>         }
> }
> ```
> 
> expected behavior:
> 
> ```csharp
> namespace UnityEditor.Accessibility
> {
>     internal enum ColorBlindCondition
>     {
>         Default,
>         Deuteranopia,
>         Protanopia,
>         Tritanopia,
>     }
> }
> ```
> 
> Not sure if this is a feature or a bug.

Isn't this user preference that is customizable via c-offset-alist?

bug#63141: Incorrect indentation in csharp-mode

[Jen-Chieh Shen]

[-- Attachment #1: Type: text/plain, Size: 1828 bytes --]

> Isn't this user preference that is customizable via c-offset-alist?

Yes, it is.

csharp-mode has the following:

```elisp
(c-add-style "csharp"
             '("java"
               (c-basic-offset . 4)
               (c-comment-only-line-offset . (0 . 0))
               (c-offsets-alist . ((inline-open           . 0)
                                   (arglist-intro         . +)
                                   (arglist-close         . 0)
                                   (inexpr-class          . 0)
                                   (case-label            . +)
                                   (cpp-macro             .
c-lineup-dont-change)
                                   (substatement-open     . 0)))))
```

I consider it an awkward indentation, so better to change the default
(change to the expected behavior).

On Fri, Apr 28, 2023 at 10:46 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Jen-Chieh Shen <jcs090218@gmail.com>
> > Date: Fri, 28 Apr 2023 12:26:00 -0700
> > Cc: Eli Zaretskii <eliz@gnu.org>, 63141@debbugs.gnu.org,
> jostein@kjonigsen.net
> >
> > Another indentation issue:
> >
> > ```csharp
> >
> > namespace UnityEditor.Accessibility
> > {
> >     internal enum ColorBlindCondition
> >         {
> >             Default,
> >             Deuteranopia,
> >             Protanopia,
> >             Tritanopia,
> >         }
> > }
> > ```
> >
> > expected behavior:
> >
> > ```csharp
> > namespace UnityEditor.Accessibility
> > {
> >     internal enum ColorBlindCondition
> >     {
> >         Default,
> >         Deuteranopia,
> >         Protanopia,
> >         Tritanopia,
> >     }
> > }
> > ```
> >
> > Not sure if this is a feature or a bug.
>
> Isn't this user preference that is customizable via c-offset-alist?
>

[-- Attachment #2: Type: text/html, Size: 2922 bytes --]

bug#63141: Incorrect indentation in csharp-mode

[Eli Zaretskii]

> From: Jen-Chieh Shen <jcs090218@gmail.com>
> Date: Fri, 28 Apr 2023 22:54:15 -0700
> Cc: theo@thornhill.no, 63141@debbugs.gnu.org, jostein@kjonigsen.net
> 
> > Isn't this user preference that is customizable via c-offset-alist?
> 
> Yes, it is.

Then this is not a bug.

> csharp-mode has the following:
> 
> ```elisp
> (c-add-style "csharp"
>              '("java"
>                (c-basic-offset . 4)
>                (c-comment-only-line-offset . (0 . 0))
>                (c-offsets-alist . ((inline-open           . 0)
>                                    (arglist-intro         . +)
>                                    (arglist-close         . 0)
>                                    (inexpr-class          . 0)
>                                    (case-label            . +)
>                                    (cpp-macro             . c-lineup-dont-change)
>                                    (substatement-open     . 0)))))
> ```
> 
> I consider it an awkward indentation, so better to change the default (change to the expected
> behavior).

I'll let Theo and Jostein chime in regarding the accepted practices in
C#, but in general it is not enough to hear from one or several users
that they don't like the defaults in order for us to change the
default behavior.  These customization options exist precisely so that
people who don't like the defaults could easily adjust Emacs to their
liking.  Why would you impose your personal preferences on everyone
else, instead of letting them customize this as they see fit?

bug#63141: Incorrect indentation in csharp-mode

[Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On 29 April 2023 08:16:38 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Jen-Chieh Shen <jcs090218@gmail.com>
>> Date: Fri, 28 Apr 2023 22:54:15 -0700
>> Cc: theo@thornhill.no, 63141@debbugs.gnu.org, jostein@kjonigsen.net
>> 
>> > Isn't this user preference that is customizable via c-offset-alist?
>> 
>> Yes, it is.
>
>Then this is not a bug.
>
>> csharp-mode has the following:
>> 
>> ```elisp
>> (c-add-style "csharp"
>>              '("java"
>>                (c-basic-offset . 4)
>>                (c-comment-only-line-offset . (0 . 0))
>>                (c-offsets-alist . ((inline-open           . 0)
>>                                    (arglist-intro         . +)
>>                                    (arglist-close         . 0)
>>                                    (inexpr-class          . 0)
>>                                    (case-label            . +)
>>                                    (cpp-macro             . c-lineup-dont-change)
>>                                    (substatement-open     . 0)))))
>> ```
>> 
>> I consider it an awkward indentation, so better to change the default (change to the expected
>> behavior).
>
>I'll let Theo and Jostein chime in regarding the accepted practices in
>C#, but in general it is not enough to hear from one or several users
>that they don't like the defaults in order for us to change the
>default behavior.  These customization options exist precisely so that
>people who don't like the defaults could easily adjust Emacs to their
>liking.  Why would you impose your personal preferences on everyone
>else, instead of letting them customize this as they see fit?

I agree. It's not a bug, but could absolutely be a missing feature/consideration. I'd be happy to review a patch with the proposed changes, though.

Thanks,
Theo

bug#63141: Incorrect indentation in csharp-mode

[Eli Zaretskii]

> Date: Sat, 29 Apr 2023 12:40:30 +0200
> From: Theodor Thornhill <theo@thornhill.no>
> CC: 63141@debbugs.gnu.org, jostein@kjonigsen.net
> 
> >> (c-add-style "csharp"
> >>              '("java"
> >>                (c-basic-offset . 4)
> >>                (c-comment-only-line-offset . (0 . 0))
> >>                (c-offsets-alist . ((inline-open           . 0)
> >>                                    (arglist-intro         . +)
> >>                                    (arglist-close         . 0)
> >>                                    (inexpr-class          . 0)
> >>                                    (case-label            . +)
> >>                                    (cpp-macro             . c-lineup-dont-change)
> >>                                    (substatement-open     . 0)))))
> >> ```
> >> 
> >> I consider it an awkward indentation, so better to change the default (change to the expected
> >> behavior).
> >
> >I'll let Theo and Jostein chime in regarding the accepted practices in
> >C#, but in general it is not enough to hear from one or several users
> >that they don't like the defaults in order for us to change the
> >default behavior.  These customization options exist precisely so that
> >people who don't like the defaults could easily adjust Emacs to their
> >liking.  Why would you impose your personal preferences on everyone
> >else, instead of letting them customize this as they see fit?
> 
> I agree. It's not a bug, but could absolutely be a missing feature/consideration. I'd be happy to review a patch with the proposed changes, though.

The patch I can envision is to change the default c-offsets-alist.
But IMO we should only do that if many/most C# programs use the style
suggested by the OP.

bug#63141: Incorrect indentation in csharp-mode

[Jen-Chieh Shen]

[-- Attachment #1: Type: text/plain, Size: 2444 bytes --]

> The patch I can envision is to change the default c-offsets-alist.
But IMO we should only do that if many/most C# programs use the style
suggested by the OP.

Just want to mention, the style conflicts with Visual Studio IDE (probably
VSCode too), and Microsoft creates C#. It's probably a good idea to match
with these tool.

I don't know what’s the prefer C# style guides in the old days, but I’ve
been using C# 8+ years and I know it has always been this way (the one with
expected behavior).

LMKWYT?


On Sat, Apr 29, 2023 at 3:48 AM Eli Zaretskii <eliz@gnu.org> wrote:

> > Date: Sat, 29 Apr 2023 12:40:30 +0200
> > From: Theodor Thornhill <theo@thornhill.no>
> > CC: 63141@debbugs.gnu.org, jostein@kjonigsen.net
> >
> > >> (c-add-style "csharp"
> > >>              '("java"
> > >>                (c-basic-offset . 4)
> > >>                (c-comment-only-line-offset . (0 . 0))
> > >>                (c-offsets-alist . ((inline-open           . 0)
> > >>                                    (arglist-intro         . +)
> > >>                                    (arglist-close         . 0)
> > >>                                    (inexpr-class          . 0)
> > >>                                    (case-label            . +)
> > >>                                    (cpp-macro             .
> c-lineup-dont-change)
> > >>                                    (substatement-open     . 0)))))
> > >> ```
> > >>
> > >> I consider it an awkward indentation, so better to change the default
> (change to the expected
> > >> behavior).
> > >
> > >I'll let Theo and Jostein chime in regarding the accepted practices in
> > >C#, but in general it is not enough to hear from one or several users
> > >that they don't like the defaults in order for us to change the
> > >default behavior.  These customization options exist precisely so that
> > >people who don't like the defaults could easily adjust Emacs to their
> > >liking.  Why would you impose your personal preferences on everyone
> > >else, instead of letting them customize this as they see fit?
> >
> > I agree. It's not a bug, but could absolutely be a missing
> feature/consideration. I'd be happy to review a patch with the proposed
> changes, though.
>
> The patch I can envision is to change the default c-offsets-alist.
> But IMO we should only do that if many/most C# programs use the style
> suggested by the OP.
>

[-- Attachment #2: Type: text/html, Size: 5570 bytes --]

bug#63141: Incorrect indentation in csharp-mode

[Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On 29 April 2023 12:48:54 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Sat, 29 Apr 2023 12:40:30 +0200
>> From: Theodor Thornhill <theo@thornhill.no>
>> CC: 63141@debbugs.gnu.org, jostein@kjonigsen.net
>> 
>> >> (c-add-style "csharp"
>> >>              '("java"
>> >>                (c-basic-offset . 4)
>> >>                (c-comment-only-line-offset . (0 . 0))
>> >>                (c-offsets-alist . ((inline-open           . 0)
>> >>                                    (arglist-intro         . +)
>> >>                                    (arglist-close         . 0)
>> >>                                    (inexpr-class          . 0)
>> >>                                    (case-label            . +)
>> >>                                    (cpp-macro             . c-lineup-dont-change)
>> >>                                    (substatement-open     . 0)))))
>> >> ```
>> >> 
>> >> I consider it an awkward indentation, so better to change the default (change to the expected
>> >> behavior).
>> >
>> >I'll let Theo and Jostein chime in regarding the accepted practices in
>> >C#, but in general it is not enough to hear from one or several users
>> >that they don't like the defaults in order for us to change the
>> >default behavior.  These customization options exist precisely so that
>> >people who don't like the defaults could easily adjust Emacs to their
>> >liking.  Why would you impose your personal preferences on everyone
>> >else, instead of letting them customize this as they see fit?
>> 
>> I agree. It's not a bug, but could absolutely be a missing feature/consideration. I'd be happy to review a patch with the proposed changes, though.
>
>The patch I can envision is to change the default c-offsets-alist.
>But IMO we should only do that if many/most C# programs use the style
>suggested by the OP.

Agreed :)

bug#63141: Incorrect indentation in csharp-mode

[Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On 29 April 2023 13:00:59 CEST, Jen-Chieh Shen <jcs090218@gmail.com> wrote:
>> The patch I can envision is to change the default c-offsets-alist.
>But IMO we should only do that if many/most C# programs use the style
>suggested by the OP.
>
>Just want to mention, the style conflicts with Visual Studio IDE (probably
>VSCode too), and Microsoft creates C#. It's probably a good idea to match
>with these tool.
>
>I don't know what’s the prefer C# style guides in the old days, but I’ve
>been using C# 8+ years and I know it has always been this way (the one with
>expected behavior).
>
>LMKWYT?
>

I'm open to changing the default alist. Are you open to devising such a patch?

Theo

>
>On Sat, Apr 29, 2023 at 3:48 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
>> > Date: Sat, 29 Apr 2023 12:40:30 +0200
>> > From: Theodor Thornhill <theo@thornhill.no>
>> > CC: 63141@debbugs.gnu.org, jostein@kjonigsen.net
>> >
>> > >> (c-add-style "csharp"
>> > >>              '("java"
>> > >>                (c-basic-offset . 4)
>> > >>                (c-comment-only-line-offset . (0 . 0))
>> > >>                (c-offsets-alist . ((inline-open           . 0)
>> > >>                                    (arglist-intro         . +)
>> > >>                                    (arglist-close         . 0)
>> > >>                                    (inexpr-class          . 0)
>> > >>                                    (case-label            . +)
>> > >>                                    (cpp-macro             .
>> c-lineup-dont-change)
>> > >>                                    (substatement-open     . 0)))))
>> > >> ```
>> > >>
>> > >> I consider it an awkward indentation, so better to change the default
>> (change to the expected
>> > >> behavior).
>> > >
>> > >I'll let Theo and Jostein chime in regarding the accepted practices in
>> > >C#, but in general it is not enough to hear from one or several users
>> > >that they don't like the defaults in order for us to change the
>> > >default behavior.  These customization options exist precisely so that
>> > >people who don't like the defaults could easily adjust Emacs to their
>> > >liking.  Why would you impose your personal preferences on everyone
>> > >else, instead of letting them customize this as they see fit?
>> >
>> > I agree. It's not a bug, but could absolutely be a missing
>> feature/consideration. I'd be happy to review a patch with the proposed
>> changes, though.
>>
>> The patch I can envision is to change the default c-offsets-alist.
>> But IMO we should only do that if many/most C# programs use the style
>> suggested by the OP.
>>

bug#63141: Incorrect indentation in csharp-mode

[Jen-Chieh Shen]

[-- Attachment #1: Type: text/plain, Size: 3119 bytes --]

> I'm open to changing the default alist. Are you open to devising such a
patch?

Sorry, I don’t have the knowledge to provide an appropriate patch. :(

Thanks for opening it to change the default settings, though.

On Sat, Apr 29, 2023 at 4:54 AM Theodor Thornhill <theo@thornhill.no> wrote:

>
>
> On 29 April 2023 13:00:59 CEST, Jen-Chieh Shen <jcs090218@gmail.com>
> wrote:
> >> The patch I can envision is to change the default c-offsets-alist.
> >But IMO we should only do that if many/most C# programs use the style
> >suggested by the OP.
> >
> >Just want to mention, the style conflicts with Visual Studio IDE (probably
> >VSCode too), and Microsoft creates C#. It's probably a good idea to match
> >with these tool.
> >
> >I don't know what’s the prefer C# style guides in the old days, but I’ve
> >been using C# 8+ years and I know it has always been this way (the one
> with
> >expected behavior).
> >
> >LMKWYT?
> >
>
> I'm open to changing the default alist. Are you open to devising such a
> patch?
>
> Theo
>
> >
> >On Sat, Apr 29, 2023 at 3:48 AM Eli Zaretskii <eliz@gnu.org> wrote:
> >
> >> > Date: Sat, 29 Apr 2023 12:40:30 +0200
> >> > From: Theodor Thornhill <theo@thornhill.no>
> >> > CC: 63141@debbugs.gnu.org, jostein@kjonigsen.net
> >> >
> >> > >> (c-add-style "csharp"
> >> > >>              '("java"
> >> > >>                (c-basic-offset . 4)
> >> > >>                (c-comment-only-line-offset . (0 . 0))
> >> > >>                (c-offsets-alist . ((inline-open           . 0)
> >> > >>                                    (arglist-intro         . +)
> >> > >>                                    (arglist-close         . 0)
> >> > >>                                    (inexpr-class          . 0)
> >> > >>                                    (case-label            . +)
> >> > >>                                    (cpp-macro             .
> >> c-lineup-dont-change)
> >> > >>                                    (substatement-open     . 0)))))
> >> > >> ```
> >> > >>
> >> > >> I consider it an awkward indentation, so better to change the
> default
> >> (change to the expected
> >> > >> behavior).
> >> > >
> >> > >I'll let Theo and Jostein chime in regarding the accepted practices
> in
> >> > >C#, but in general it is not enough to hear from one or several users
> >> > >that they don't like the defaults in order for us to change the
> >> > >default behavior.  These customization options exist precisely so
> that
> >> > >people who don't like the defaults could easily adjust Emacs to their
> >> > >liking.  Why would you impose your personal preferences on everyone
> >> > >else, instead of letting them customize this as they see fit?
> >> >
> >> > I agree. It's not a bug, but could absolutely be a missing
> >> feature/consideration. I'd be happy to review a patch with the proposed
> >> changes, though.
> >>
> >> The patch I can envision is to change the default c-offsets-alist.
> >> But IMO we should only do that if many/most C# programs use the style
> >> suggested by the OP.
> >>
>

[-- Attachment #2: Type: text/html, Size: 5234 bytes --]

bug#63141: Incorrect indentation in csharp-mode

[Eli Zaretskii]

> Date: Sat, 29 Apr 2023 13:02:12 +0200
> From: Theodor Thornhill <theo@thornhill.no>
> CC: jcs090218@gmail.com, 63141@debbugs.gnu.org, jostein@kjonigsen.net
> 
> >> I agree. It's not a bug, but could absolutely be a missing feature/consideration. I'd be happy to review a patch with the proposed changes, though.
> >
> >The patch I can envision is to change the default c-offsets-alist.
> >But IMO we should only do that if many/most C# programs use the style
> >suggested by the OP.
> 
> Agreed :)

So, what's the way forward here? do we change the defaults?

bug#63141: Incorrect indentation in csharp-mode

[Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On 2 May 2023 14:57:03 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Sat, 29 Apr 2023 13:02:12 +0200
>> From: Theodor Thornhill <theo@thornhill.no>
>> CC: jcs090218@gmail.com, 63141@debbugs.gnu.org, jostein@kjonigsen.net
>> 
>> >> I agree. It's not a bug, but could absolutely be a missing feature/consideration. I'd be happy to review a patch with the proposed changes, though.
>> >
>> >The patch I can envision is to change the default c-offsets-alist.
>> >But IMO we should only do that if many/most C# programs use the style
>> >suggested by the OP.
>> 
>> Agreed :)
>
>So, what's the way forward here? do we change the defaults?

I think so. Ill try to get to it today :)

Theo

bug#63141: Incorrect indentation in csharp-mode

[Eli Zaretskii]

> Date: Wed, 03 May 2023 06:44:47 +0200
> From: Theodor Thornhill <theo@thornhill.no>
> CC: jcs090218@gmail.com, 63141@debbugs.gnu.org, jostein@kjonigsen.net
> 
> 
> 
> On 2 May 2023 14:57:03 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
> >> Date: Sat, 29 Apr 2023 13:02:12 +0200
> >> From: Theodor Thornhill <theo@thornhill.no>
> >> CC: jcs090218@gmail.com, 63141@debbugs.gnu.org, jostein@kjonigsen.net
> >> 
> >> >> I agree. It's not a bug, but could absolutely be a missing feature/consideration. I'd be happy to review a patch with the proposed changes, though.
> >> >
> >> >The patch I can envision is to change the default c-offsets-alist.
> >> >But IMO we should only do that if many/most C# programs use the style
> >> >suggested by the OP.
> >> 
> >> Agreed :)
> >
> >So, what's the way forward here? do we change the defaults?
> 
> I think so. Ill try to get to it today :)

Ping!

bug#63141: Incorrect indentation in csharp-mode

[Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Wed, 03 May 2023 06:44:47 +0200
>> From: Theodor Thornhill <theo@thornhill.no>
>> CC: jcs090218@gmail.com, 63141@debbugs.gnu.org, jostein@kjonigsen.net
>> 
>> 
>> 
>> On 2 May 2023 14:57:03 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
>> >> Date: Sat, 29 Apr 2023 13:02:12 +0200
>> >> From: Theodor Thornhill <theo@thornhill.no>
>> >> CC: jcs090218@gmail.com, 63141@debbugs.gnu.org, jostein@kjonigsen.net
>> >> 
>> >> >> I agree. It's not a bug, but could absolutely be a missing feature/consideration. I'd be happy to review a patch with the proposed changes, though.
>> >> >
>> >> >The patch I can envision is to change the default c-offsets-alist.
>> >> >But IMO we should only do that if many/most C# programs use the style
>> >> >suggested by the OP.
>> >> 
>> >> Agreed :)
>> >
>> >So, what's the way forward here? do we change the defaults?
>> 
>> I think so. Ill try to get to it today :)
>
> Ping!

Thanks!

Jen-Chieh, can you test this?

diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el
index 4f7cbc3d51d..869a207c567 100644
--- a/lisp/progmodes/csharp-mode.el
+++ b/lisp/progmodes/csharp-mode.el
@@ -464,6 +464,15 @@ csharp-at-lambda-header
 
 (defun csharp-guess-basic-syntax (orig-fun &rest args)
   (cond
+   (;; enum
+    (save-excursion
+      (goto-char (c-point 'boi))
+      (and
+       (eq (char-after) ?\{)
+       (save-excursion
+         (goto-char (c-point 'iopl))
+         (looking-at ".*enum.*"))))
+    `((class-open ,(c-point 'iopl))))
    (;; Attributes
     (save-excursion
       (goto-char (c-point 'iopl))

Theo

bug#63141: Incorrect indentation in csharp-mode

[Jen-Chieh Shen]

[-- Attachment #1: Type: text/plain, Size: 2007 bytes --]

>  Thanks!
>
>    Jen-Chieh, can you test this?
>
>  Theo

Yes! It works! Thank you!

How about the fix for the attribute?

Jen-Chieh

On Sat, May 6, 2023 at 3:03 AM Theodor Thornhill <theo@thornhill.no> wrote:

> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> Date: Wed, 03 May 2023 06:44:47 +0200
> >> From: Theodor Thornhill <theo@thornhill.no>
> >> CC: jcs090218@gmail.com, 63141@debbugs.gnu.org, jostein@kjonigsen.net
> >>
> >>
> >>
> >> On 2 May 2023 14:57:03 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
> >> >> Date: Sat, 29 Apr 2023 13:02:12 +0200
> >> >> From: Theodor Thornhill <theo@thornhill.no>
> >> >> CC: jcs090218@gmail.com, 63141@debbugs.gnu.org,
> jostein@kjonigsen.net
> >> >>
> >> >> >> I agree. It's not a bug, but could absolutely be a missing
> feature/consideration. I'd be happy to review a patch with the proposed
> changes, though.
> >> >> >
> >> >> >The patch I can envision is to change the default c-offsets-alist.
> >> >> >But IMO we should only do that if many/most C# programs use the
> style
> >> >> >suggested by the OP.
> >> >>
> >> >> Agreed :)
> >> >
> >> >So, what's the way forward here? do we change the defaults?
> >>
> >> I think so. Ill try to get to it today :)
> >
> > Ping!
>
> Thanks!
>
> Jen-Chieh, can you test this?
>
> diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el
> index 4f7cbc3d51d..869a207c567 100644
> --- a/lisp/progmodes/csharp-mode.el
> +++ b/lisp/progmodes/csharp-mode.el
> @@ -464,6 +464,15 @@ csharp-at-lambda-header
>
>  (defun csharp-guess-basic-syntax (orig-fun &rest args)
>    (cond
> +   (;; enum
> +    (save-excursion
> +      (goto-char (c-point 'boi))
> +      (and
> +       (eq (char-after) ?\{)
> +       (save-excursion
> +         (goto-char (c-point 'iopl))
> +         (looking-at ".*enum.*"))))
> +    `((class-open ,(c-point 'iopl))))
>     (;; Attributes
>      (save-excursion
>        (goto-char (c-point 'iopl))
>
> Theo
>

[-- Attachment #2: Type: text/html, Size: 3468 bytes --]

bug#63141: Incorrect indentation in csharp-mode

[Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On 6 May 2023 13:00:31 CEST, Jen-Chieh Shen <jcs090218@gmail.com> wrote:
>>  Thanks!
>>
>>    Jen-Chieh, can you test this?
>>
>>  Theo
>
>Yes! It works! Thank you!
>
>How about the fix for the attribute?
>
>Jen-Chieh

Isn't that fix already on emacs-29?


>
>On Sat, May 6, 2023 at 3:03 AM Theodor Thornhill <theo@thornhill.no> wrote:
>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> >> Date: Wed, 03 May 2023 06:44:47 +0200
>> >> From: Theodor Thornhill <theo@thornhill.no>
>> >> CC: jcs090218@gmail.com, 63141@debbugs.gnu.org, jostein@kjonigsen.net
>> >>
>> >>
>> >>
>> >> On 2 May 2023 14:57:03 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
>> >> >> Date: Sat, 29 Apr 2023 13:02:12 +0200
>> >> >> From: Theodor Thornhill <theo@thornhill.no>
>> >> >> CC: jcs090218@gmail.com, 63141@debbugs.gnu.org,
>> jostein@kjonigsen.net
>> >> >>
>> >> >> >> I agree. It's not a bug, but could absolutely be a missing
>> feature/consideration. I'd be happy to review a patch with the proposed
>> changes, though.
>> >> >> >
>> >> >> >The patch I can envision is to change the default c-offsets-alist.
>> >> >> >But IMO we should only do that if many/most C# programs use the
>> style
>> >> >> >suggested by the OP.
>> >> >>
>> >> >> Agreed :)
>> >> >
>> >> >So, what's the way forward here? do we change the defaults?
>> >>
>> >> I think so. Ill try to get to it today :)
>> >
>> > Ping!
>>
>> Thanks!
>>
>> Jen-Chieh, can you test this?
>>
>> diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el
>> index 4f7cbc3d51d..869a207c567 100644
>> --- a/lisp/progmodes/csharp-mode.el
>> +++ b/lisp/progmodes/csharp-mode.el
>> @@ -464,6 +464,15 @@ csharp-at-lambda-header
>>
>>  (defun csharp-guess-basic-syntax (orig-fun &rest args)
>>    (cond
>> +   (;; enum
>> +    (save-excursion
>> +      (goto-char (c-point 'boi))
>> +      (and
>> +       (eq (char-after) ?\{)
>> +       (save-excursion
>> +         (goto-char (c-point 'iopl))
>> +         (looking-at ".*enum.*"))))
>> +    `((class-open ,(c-point 'iopl))))
>>     (;; Attributes
>>      (save-excursion
>>        (goto-char (c-point 'iopl))
>>
>> Theo
>>

bug#63141: Incorrect indentation in csharp-mode

[Jen-Chieh Shen]

[-- Attachment #1: Type: text/plain, Size: 2505 bytes --]

Oh, I haven't pulled the latest so I guess it's fixed?

On Sat, May 6, 2023 at 4:08 AM Theodor Thornhill <theo@thornhill.no> wrote:

>
>
> On 6 May 2023 13:00:31 CEST, Jen-Chieh Shen <jcs090218@gmail.com> wrote:
> >>  Thanks!
> >>
> >>    Jen-Chieh, can you test this?
> >>
> >>  Theo
> >
> >Yes! It works! Thank you!
> >
> >How about the fix for the attribute?
> >
> >Jen-Chieh
>
> Isn't that fix already on emacs-29?
>
>
> >
> >On Sat, May 6, 2023 at 3:03 AM Theodor Thornhill <theo@thornhill.no>
> wrote:
> >
> >> Eli Zaretskii <eliz@gnu.org> writes:
> >>
> >> >> Date: Wed, 03 May 2023 06:44:47 +0200
> >> >> From: Theodor Thornhill <theo@thornhill.no>
> >> >> CC: jcs090218@gmail.com, 63141@debbugs.gnu.org,
> jostein@kjonigsen.net
> >> >>
> >> >>
> >> >>
> >> >> On 2 May 2023 14:57:03 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
> >> >> >> Date: Sat, 29 Apr 2023 13:02:12 +0200
> >> >> >> From: Theodor Thornhill <theo@thornhill.no>
> >> >> >> CC: jcs090218@gmail.com, 63141@debbugs.gnu.org,
> >> jostein@kjonigsen.net
> >> >> >>
> >> >> >> >> I agree. It's not a bug, but could absolutely be a missing
> >> feature/consideration. I'd be happy to review a patch with the proposed
> >> changes, though.
> >> >> >> >
> >> >> >> >The patch I can envision is to change the default
> c-offsets-alist.
> >> >> >> >But IMO we should only do that if many/most C# programs use the
> >> style
> >> >> >> >suggested by the OP.
> >> >> >>
> >> >> >> Agreed :)
> >> >> >
> >> >> >So, what's the way forward here? do we change the defaults?
> >> >>
> >> >> I think so. Ill try to get to it today :)
> >> >
> >> > Ping!
> >>
> >> Thanks!
> >>
> >> Jen-Chieh, can you test this?
> >>
> >> diff --git a/lisp/progmodes/csharp-mode.el
> b/lisp/progmodes/csharp-mode.el
> >> index 4f7cbc3d51d..869a207c567 100644
> >> --- a/lisp/progmodes/csharp-mode.el
> >> +++ b/lisp/progmodes/csharp-mode.el
> >> @@ -464,6 +464,15 @@ csharp-at-lambda-header
> >>
> >>  (defun csharp-guess-basic-syntax (orig-fun &rest args)
> >>    (cond
> >> +   (;; enum
> >> +    (save-excursion
> >> +      (goto-char (c-point 'boi))
> >> +      (and
> >> +       (eq (char-after) ?\{)
> >> +       (save-excursion
> >> +         (goto-char (c-point 'iopl))
> >> +         (looking-at ".*enum.*"))))
> >> +    `((class-open ,(c-point 'iopl))))
> >>     (;; Attributes
> >>      (save-excursion
> >>        (goto-char (c-point 'iopl))
> >>
> >> Theo
> >>
>

[-- Attachment #2: Type: text/html, Size: 4422 bytes --]

bug#63141: Incorrect indentation in csharp-mode

[Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On 6 May 2023 13:09:58 CEST, Jen-Chieh Shen <jcs090218@gmail.com> wrote:
>Oh, I haven't pulled the latest so I guess it's fixed?
>
>On Sat, May 6, 2023 at 4:08 AM Theodor Thornhill <theo@thornhill.no> wrote:
>
>>


It should be, yes, but not yet the one I just sent. I'll install that later today :)

Theo

>>
>> On 6 May 2023 13:00:31 CEST, Jen-Chieh Shen <jcs090218@gmail.com> wrote:
>> >>  Thanks!
>> >>
>> >>    Jen-Chieh, can you test this?
>> >>
>> >>  Theo
>> >
>> >Yes! It works! Thank you!
>> >
>> >How about the fix for the attribute?
>> >
>> >Jen-Chieh
>>
>> Isn't that fix already on emacs-29?
>>
>>
>> >
>> >On Sat, May 6, 2023 at 3:03 AM Theodor Thornhill <theo@thornhill.no>
>> wrote:
>> >
>> >> Eli Zaretskii <eliz@gnu.org> writes:
>> >>
>> >> >> Date: Wed, 03 May 2023 06:44:47 +0200
>> >> >> From: Theodor Thornhill <theo@thornhill.no>
>> >> >> CC: jcs090218@gmail.com, 63141@debbugs.gnu.org,
>> jostein@kjonigsen.net
>> >> >>
>> >> >>
>> >> >>
>> >> >> On 2 May 2023 14:57:03 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
>> >> >> >> Date: Sat, 29 Apr 2023 13:02:12 +0200
>> >> >> >> From: Theodor Thornhill <theo@thornhill.no>
>> >> >> >> CC: jcs090218@gmail.com, 63141@debbugs.gnu.org,
>> >> jostein@kjonigsen.net
>> >> >> >>
>> >> >> >> >> I agree. It's not a bug, but could absolutely be a missing
>> >> feature/consideration. I'd be happy to review a patch with the proposed
>> >> changes, though.
>> >> >> >> >
>> >> >> >> >The patch I can envision is to change the default
>> c-offsets-alist.
>> >> >> >> >But IMO we should only do that if many/most C# programs use the
>> >> style
>> >> >> >> >suggested by the OP.
>> >> >> >>
>> >> >> >> Agreed :)
>> >> >> >
>> >> >> >So, what's the way forward here? do we change the defaults?
>> >> >>
>> >> >> I think so. Ill try to get to it today :)
>> >> >
>> >> > Ping!
>> >>
>> >> Thanks!
>> >>
>> >> Jen-Chieh, can you test this?
>> >>
>> >> diff --git a/lisp/progmodes/csharp-mode.el
>> b/lisp/progmodes/csharp-mode.el
>> >> index 4f7cbc3d51d..869a207c567 100644
>> >> --- a/lisp/progmodes/csharp-mode.el
>> >> +++ b/lisp/progmodes/csharp-mode.el
>> >> @@ -464,6 +464,15 @@ csharp-at-lambda-header
>> >>
>> >>  (defun csharp-guess-basic-syntax (orig-fun &rest args)
>> >>    (cond
>> >> +   (;; enum
>> >> +    (save-excursion
>> >> +      (goto-char (c-point 'boi))
>> >> +      (and
>> >> +       (eq (char-after) ?\{)
>> >> +       (save-excursion
>> >> +         (goto-char (c-point 'iopl))
>> >> +         (looking-at ".*enum.*"))))
>> >> +    `((class-open ,(c-point 'iopl))))
>> >>     (;; Attributes
>> >>      (save-excursion
>> >>        (goto-char (c-point 'iopl))
>> >>
>> >> Theo
>> >>
>>

bug#63141: Incorrect indentation in csharp-mode

[Jen-Chieh Shen]

[-- Attachment #1: Type: text/plain, Size: 3211 bytes --]

> It should be, yes, but not yet the one I just sent. I'll install that
later today :)

Sounds good! Thank you so much for your effort!

Jen-Chieh

On Sat, May 6, 2023 at 5:05 AM Theodor Thornhill <theo@thornhill.no> wrote:

>
>
> On 6 May 2023 13:09:58 CEST, Jen-Chieh Shen <jcs090218@gmail.com> wrote:
> >Oh, I haven't pulled the latest so I guess it's fixed?
> >
> >On Sat, May 6, 2023 at 4:08 AM Theodor Thornhill <theo@thornhill.no>
> wrote:
> >
> >>
>
>
> It should be, yes, but not yet the one I just sent. I'll install that
> later today :)
>
> Theo
>
> >>
> >> On 6 May 2023 13:00:31 CEST, Jen-Chieh Shen <jcs090218@gmail.com>
> wrote:
> >> >>  Thanks!
> >> >>
> >> >>    Jen-Chieh, can you test this?
> >> >>
> >> >>  Theo
> >> >
> >> >Yes! It works! Thank you!
> >> >
> >> >How about the fix for the attribute?
> >> >
> >> >Jen-Chieh
> >>
> >> Isn't that fix already on emacs-29?
> >>
> >>
> >> >
> >> >On Sat, May 6, 2023 at 3:03 AM Theodor Thornhill <theo@thornhill.no>
> >> wrote:
> >> >
> >> >> Eli Zaretskii <eliz@gnu.org> writes:
> >> >>
> >> >> >> Date: Wed, 03 May 2023 06:44:47 +0200
> >> >> >> From: Theodor Thornhill <theo@thornhill.no>
> >> >> >> CC: jcs090218@gmail.com, 63141@debbugs.gnu.org,
> >> jostein@kjonigsen.net
> >> >> >>
> >> >> >>
> >> >> >>
> >> >> >> On 2 May 2023 14:57:03 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
> >> >> >> >> Date: Sat, 29 Apr 2023 13:02:12 +0200
> >> >> >> >> From: Theodor Thornhill <theo@thornhill.no>
> >> >> >> >> CC: jcs090218@gmail.com, 63141@debbugs.gnu.org,
> >> >> jostein@kjonigsen.net
> >> >> >> >>
> >> >> >> >> >> I agree. It's not a bug, but could absolutely be a missing
> >> >> feature/consideration. I'd be happy to review a patch with the
> proposed
> >> >> changes, though.
> >> >> >> >> >
> >> >> >> >> >The patch I can envision is to change the default
> >> c-offsets-alist.
> >> >> >> >> >But IMO we should only do that if many/most C# programs use
> the
> >> >> style
> >> >> >> >> >suggested by the OP.
> >> >> >> >>
> >> >> >> >> Agreed :)
> >> >> >> >
> >> >> >> >So, what's the way forward here? do we change the defaults?
> >> >> >>
> >> >> >> I think so. Ill try to get to it today :)
> >> >> >
> >> >> > Ping!
> >> >>
> >> >> Thanks!
> >> >>
> >> >> Jen-Chieh, can you test this?
> >> >>
> >> >> diff --git a/lisp/progmodes/csharp-mode.el
> >> b/lisp/progmodes/csharp-mode.el
> >> >> index 4f7cbc3d51d..869a207c567 100644
> >> >> --- a/lisp/progmodes/csharp-mode.el
> >> >> +++ b/lisp/progmodes/csharp-mode.el
> >> >> @@ -464,6 +464,15 @@ csharp-at-lambda-header
> >> >>
> >> >>  (defun csharp-guess-basic-syntax (orig-fun &rest args)
> >> >>    (cond
> >> >> +   (;; enum
> >> >> +    (save-excursion
> >> >> +      (goto-char (c-point 'boi))
> >> >> +      (and
> >> >> +       (eq (char-after) ?\{)
> >> >> +       (save-excursion
> >> >> +         (goto-char (c-point 'iopl))
> >> >> +         (looking-at ".*enum.*"))))
> >> >> +    `((class-open ,(c-point 'iopl))))
> >> >>     (;; Attributes
> >> >>      (save-excursion
> >> >>        (goto-char (c-point 'iopl))
> >> >>
> >> >> Theo
> >> >>
> >>
>

[-- Attachment #2: Type: text/html, Size: 6456 bytes --]

bug#63141: Incorrect indentation in csharp-mode

[Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Jen-Chieh Shen <jcs090218@gmail.com> writes:

>> It should be, yes, but not yet the one I just sent. I'll install that
> later today :)
>
> Sounds good! Thank you so much for your effort!

No worries - now installed on emacs-29.

Theo

bug#63141: Incorrect indentation in csharp-mode

[Eli Zaretskii]

> From: Theodor Thornhill <theo@thornhill.no>
> Cc: 63141@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>, jostein@kjonigsen.net
> Date: Sat, 06 May 2023 21:16:50 +0200
> 
> Jen-Chieh Shen <jcs090218@gmail.com> writes:
> 
> >> It should be, yes, but not yet the one I just sent. I'll install that
> > later today :)
> >
> > Sounds good! Thank you so much for your effort!
> 
> No worries - now installed on emacs-29.

Thanks!  I'm therefore closing this bug.

bug#63141: Incorrect indentation in csharp-mode

[Jen-Chieh Shen]

[-- Attachment #1: Type: text/plain, Size: 890 bytes --]

Hmm... I've tried the latest csharp-mode, but now you cannot indent the
whole buffer anymore!
It prints out the message `up-list: At top level`, not sure what that
means. And every command
regarding indentation is not working, e.g., indent-for-tab-command,
newline, newline-and-indent, etc.

Any thoughts?

On Sat, May 6, 2023 at 12:39 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Theodor Thornhill <theo@thornhill.no>
> > Cc: 63141@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
> jostein@kjonigsen.net
> > Date: Sat, 06 May 2023 21:16:50 +0200
> >
> > Jen-Chieh Shen <jcs090218@gmail.com> writes:
> >
> > >> It should be, yes, but not yet the one I just sent. I'll install that
> > > later today :)
> > >
> > > Sounds good! Thank you so much for your effort!
> >
> > No worries - now installed on emacs-29.
>
> Thanks!  I'm therefore closing this bug.
>

[-- Attachment #2: Type: text/html, Size: 1583 bytes --]

bug#63141: Incorrect indentation in csharp-mode

[Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Jen-Chieh Shen <jcs090218@gmail.com> writes:

> Hmm... I've tried the latest csharp-mode, but now you cannot indent the
> whole buffer anymore!
> It prints out the message `up-list: At top level`, not sure what that
> means. And every command
> regarding indentation is not working, e.g., indent-for-tab-command,
> newline, newline-and-indent, etc.
>
> Any thoughts?

I tried using a revision before my changes, and the issue seems to be
there too.  I don't think this is related to this bug, unless you
disagree?  Can you file a new bug, and I'll look at it?

Thanks,
Theo

>
> On Sat, May 6, 2023 at 12:39 PM Eli Zaretskii <eliz@gnu.org> wrote:
>
>> > From: Theodor Thornhill <theo@thornhill.no>
>> > Cc: 63141@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
>> jostein@kjonigsen.net
>> > Date: Sat, 06 May 2023 21:16:50 +0200
>> >
>> > Jen-Chieh Shen <jcs090218@gmail.com> writes:
>> >
>> > >> It should be, yes, but not yet the one I just sent. I'll install that
>> > > later today :)
>> > >
>> > > Sounds good! Thank you so much for your effort!
>> >
>> > No worries - now installed on emacs-29.
>>
>> Thanks!  I'm therefore closing this bug.
>>

bug#63141: Incorrect indentation in csharp-mode

[Jen-Chieh Shen]

[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]

> I tried using a revision before my changes, and the issue seems to be
> there too.  I don't think this is related to this bug, unless you
> disagree?  Can you file a new bug, and I'll look at it?

I've opened another issue!

Thank you!
Jen-Chieh

On Mon, May 8, 2023 at 5:08 AM Theodor Thornhill <theo@thornhill.no> wrote:

> Jen-Chieh Shen <jcs090218@gmail.com> writes:
>
> > Hmm... I've tried the latest csharp-mode, but now you cannot indent the
> > whole buffer anymore!
> > It prints out the message `up-list: At top level`, not sure what that
> > means. And every command
> > regarding indentation is not working, e.g., indent-for-tab-command,
> > newline, newline-and-indent, etc.
> >
> > Any thoughts?
>
> I tried using a revision before my changes, and the issue seems to be
> there too.  I don't think this is related to this bug, unless you
> disagree?  Can you file a new bug, and I'll look at it?
>
> Thanks,
> Theo
>
> >
> > On Sat, May 6, 2023 at 12:39 PM Eli Zaretskii <eliz@gnu.org> wrote:
> >
> >> > From: Theodor Thornhill <theo@thornhill.no>
> >> > Cc: 63141@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
> >> jostein@kjonigsen.net
> >> > Date: Sat, 06 May 2023 21:16:50 +0200
> >> >
> >> > Jen-Chieh Shen <jcs090218@gmail.com> writes:
> >> >
> >> > >> It should be, yes, but not yet the one I just sent. I'll install
> that
> >> > > later today :)
> >> > >
> >> > > Sounds good! Thank you so much for your effort!
> >> >
> >> > No worries - now installed on emacs-29.
> >>
> >> Thanks!  I'm therefore closing this bug.
> >>
>

[-- Attachment #2: Type: text/html, Size: 2645 bytes --]