From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: jcs090218@gmail.com, 63141@debbugs.gnu.org, jostein@kjonigsen.net
Subject: bug#63141: Incorrect indentation in csharp-mode
Date: Sat, 06 May 2023 12:03:15 +0200 [thread overview]
Message-ID: <877ctlhj4s.fsf@thornhill.no> (raw)
In-Reply-To: <83cz3dhmhn.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Wed, 03 May 2023 06:44:47 +0200
>> From: Theodor Thornhill <theo@thornhill.no>
>> CC: jcs090218@gmail.com, 63141@debbugs.gnu.org, jostein@kjonigsen.net
>>
>>
>>
>> On 2 May 2023 14:57:03 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
>> >> Date: Sat, 29 Apr 2023 13:02:12 +0200
>> >> From: Theodor Thornhill <theo@thornhill.no>
>> >> CC: jcs090218@gmail.com, 63141@debbugs.gnu.org, jostein@kjonigsen.net
>> >>
>> >> >> I agree. It's not a bug, but could absolutely be a missing feature/consideration. I'd be happy to review a patch with the proposed changes, though.
>> >> >
>> >> >The patch I can envision is to change the default c-offsets-alist.
>> >> >But IMO we should only do that if many/most C# programs use the style
>> >> >suggested by the OP.
>> >>
>> >> Agreed :)
>> >
>> >So, what's the way forward here? do we change the defaults?
>>
>> I think so. Ill try to get to it today :)
>
> Ping!
Thanks!
Jen-Chieh, can you test this?
diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el
index 4f7cbc3d51d..869a207c567 100644
--- a/lisp/progmodes/csharp-mode.el
+++ b/lisp/progmodes/csharp-mode.el
@@ -464,6 +464,15 @@ csharp-at-lambda-header
(defun csharp-guess-basic-syntax (orig-fun &rest args)
(cond
+ (;; enum
+ (save-excursion
+ (goto-char (c-point 'boi))
+ (and
+ (eq (char-after) ?\{)
+ (save-excursion
+ (goto-char (c-point 'iopl))
+ (looking-at ".*enum.*"))))
+ `((class-open ,(c-point 'iopl))))
(;; Attributes
(save-excursion
(goto-char (c-point 'iopl))
Theo
next prev parent reply other threads:[~2023-05-06 10:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 7:25 bug#63141: Incorrect indentation in csharp-mode Jen-Chieh Shen
2023-04-28 7:44 ` Eli Zaretskii
2023-04-28 8:50 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-28 10:00 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-28 10:29 ` Eli Zaretskii
2023-04-28 11:58 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-28 12:02 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-28 19:26 ` Jen-Chieh Shen
2023-04-29 5:46 ` Eli Zaretskii
2023-04-29 5:54 ` Jen-Chieh Shen
2023-04-29 6:16 ` Eli Zaretskii
2023-04-29 10:40 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-29 10:48 ` Eli Zaretskii
2023-04-29 11:00 ` Jen-Chieh Shen
2023-04-29 11:54 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-29 11:59 ` Jen-Chieh Shen
2023-04-29 11:02 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-02 12:57 ` Eli Zaretskii
2023-05-03 4:44 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-06 8:50 ` Eli Zaretskii
2023-05-06 10:03 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-05-06 11:00 ` Jen-Chieh Shen
2023-05-06 11:08 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-06 11:09 ` Jen-Chieh Shen
2023-05-06 12:05 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-06 19:05 ` Jen-Chieh Shen
2023-05-06 19:16 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-06 19:40 ` Eli Zaretskii
2023-05-08 8:03 ` Jen-Chieh Shen
2023-05-08 12:08 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-09 9:22 ` Jen-Chieh Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ctlhj4s.fsf@thornhill.no \
--to=bug-gnu-emacs@gnu.org \
--cc=63141@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jcs090218@gmail.com \
--cc=jostein@kjonigsen.net \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).